From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3897A39B4BC for ; Mon, 8 Jun 2026 08:03:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780905823; cv=none; b=JvhuBrb6JpvrxG/Er6t4ZFHtHMlVv9WJuIVvJNLgMWmman3xlP0MtM8/xwvs3AvHMyzpvmfRQn4koo4WCG1hn53dmjGQWXoO1+YbL+kJZkgb2bYEpaSsAZY04wSMu8ewroCG9HHg7zJ7r0zGh7V6rlziRTExdGEE81vWBFH/FS8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780905823; c=relaxed/simple; bh=ks/hAwYVsFqrHC9+E3yR5o2w1e2Yk6pAh/B8zj9H8KM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IeSx4dnkhVlNV6IERXwWQDEQh2wYNPBHCJySihEW4th4YSpgUj6Zzpg8tDwi8ZXtU0JVf6JkLoW/kBXGCO0Xh0uk6QTI5ZRn/hds9jfHU6nydttFrwqkzdNdsOkmi08uZYBFutXzicfsWmhzg6s6Zp3lTBmhGA1NCbCLO0W2BuU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=rER9hs1q; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="rER9hs1q" Received: from killaraus.ideasonboard.com (2001-14ba-70f3-e800--a06.rev.dnainternet.fi [IPv6:2001:14ba:70f3:e800::a06]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0B0D8241; Mon, 8 Jun 2026 10:03:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1780905792; bh=ks/hAwYVsFqrHC9+E3yR5o2w1e2Yk6pAh/B8zj9H8KM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rER9hs1qWWXV+A2QwFpYHEeC1UokHFyjYfi6urxZkgtOidWLYeiPJtrXITK9oPenJ v+nHbWHLXZv9/t1rBDkj3pGnsJOZmf7Bb5p0RRyQOM3VJgd6ULgKARJ9f4+RF1O7G3 seUXsJ7UsZQpONKfg/IS6TX4WSSj4ZfTJ/a5L524= Date: Mon, 8 Jun 2026 11:03:38 +0300 From: Laurent Pinchart To: Jacopo Mondi Cc: Sakari Ailus , linux-media@vger.kernel.org, hans@jjverkuil.nl, Prabhakar , Kate Hsuan , Dave Stevenson , Tommaso Merciai , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , Stefan Klug , Mirela Rabulea , =?utf-8?B?QW5kcsOp?= Apitzsch , Heimir Thor Sverrisson , Kieran Bingham , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Tomi Valkeinen , David Plowman , "Yu, Ong Hock" , "Ng, Khai Wen" , Jai Luthra , Rishikesh Donadkar Subject: Re: [PATCH v5 04/10] media: imx219: Make control handler ops for PIXEL_RATE NULL Message-ID: <20260608080338.GF370380@killaraus.ideasonboard.com> References: <20260607215356.842932-1-sakari.ailus@linux.intel.com> <20260607215356.842932-5-sakari.ailus@linux.intel.com> <20260608073653.GD370380@killaraus.ideasonboard.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Mon, Jun 08, 2026 at 09:53:17AM +0200, Jacopo Mondi wrote: > Hi Laurent > sorry if I reply in place of Sakari but I got this fresh Thanks :-) > On Mon, Jun 08, 2026 at 10:36:53AM +0300, Laurent Pinchart wrote: > > On Mon, Jun 08, 2026 at 12:53:50AM +0300, Sakari Ailus wrote: > > > The PIXEL_RATE control exists to convey the value to the userspace and has > > > no configuration that would need to be programmed to the sensor. Make the > > > control handler ops for the PIXEL_RATE control NULL and avoid a warning > > > (as well as returning an error) from the driver. > > > > I thought the standard way to handle pixel rate being read only was to > > set the V4L2_CTRL_FLAG_READ_ONLY flag, like we do for e.g. > > V4L2_CID_LINK_FREQ. Is that not correct ? > > PIXEL_RATE is RO by default > > drivers/media/v4l2-core/v4l2-ctrls-defs.c: case V4L2_CID_PIXEL_RATE: > drivers/media/v4l2-core/v4l2-ctrls-defs.c- *type = V4L2_CTRL_TYPE_INTEGER64; > drivers/media/v4l2-core/v4l2-ctrls-defs.c- *flags |= V4L2_CTRL_FLAG_READ_ONLY; > drivers/media/v4l2-core/v4l2-ctrls-defs.c- break; > > The purpose of setting the ctrl_ops member to NULL is to avoid having > to handle RO controls in the driver implementation of .s_ctrl(). Shouldn't the V4L2 control framework avoid .s_ctrl() calls for read-only controls ? I thought it did already. > > > Signed-off-by: Sakari Ailus > > > --- > > > drivers/media/i2c/imx219.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c > > > index e681f80f9e3e..86683fe8a79e 100644 > > > --- a/drivers/media/i2c/imx219.c > > > +++ b/drivers/media/i2c/imx219.c > > > @@ -556,7 +556,7 @@ static int imx219_init_controls(struct imx219 *imx219) > > > return ret; > > > > > > /* By default, PIXEL_RATE is read only */ > > > - imx219->pixel_rate = v4l2_ctrl_new_std(ctrl_hdlr, &imx219_ctrl_ops, > > > + imx219->pixel_rate = v4l2_ctrl_new_std(ctrl_hdlr, NULL, > > > V4L2_CID_PIXEL_RATE, > > > imx219_get_pixel_rate(imx219), > > > imx219_get_pixel_rate(imx219), 1, -- Regards, Laurent Pinchart