Re: [PATCH v5 1/2] media: qcom: iris: fix runtime PM reference leaks

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] `iris_disable_power_domains()` incorrectly propagates `1` on success when the device is already suspended.
--

commit 7b8fb44887231870efc4a92ebbb558afa99135b1
Author: Hungyu Lin <dennylin0707@gmail.com>

media: qcom: iris: fix runtime PM reference leaks

This commit uses pm_runtime_resume_and_get() in iris_enable_power_domains()
to prevent reference leaks on failure. It also updates
iris_disable_power_domains() to always call pm_runtime_put_sync() and capture
its result.

> diff --git a/drivers/media/platform/qcom/iris/iris_resources.c b/drivers/media/platform/qcom/iris/iris_resources.c
> --- a/drivers/media/platform/qcom/iris/iris_resources.c
> +++ b/drivers/media/platform/qcom/iris/iris_resources.c

[ ... ]

>  int iris_disable_power_domains(struct iris_core *core, struct device *pd_dev)
>  {
>  	int ret;
> +	int pm_ret;
>  
>  	ret = iris_opp_set_rate(core->dev, 0);
> -	if (ret)
> -		return ret;
>  
> -	pm_runtime_put_sync(pd_dev);
> +	pm_ret = pm_runtime_put_sync(pd_dev);
> +	if (!ret)
> +		ret = pm_ret;
>  
> -	return 0;
> +	return ret;
>  }

[Severity: Low]
Is it intentional to propagate a positive return value here?

According to the runtime PM API, pm_runtime_put_sync() returns 1 as a success
case when the device usage count drops to zero but it is already in the
RPM_SUSPENDED state.

By capturing and returning this value directly from
iris_disable_power_domains(), the function will return 1 instead of 0 on a
successful suspend. While current callers may ignore the return value, future
callers checking if (ret) could incorrectly treat this normal success case as
a failure.

Would it be safer to normalize positive return values to 0?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260608081721.82846-1-dennylin0707@gmail.com?part=1