From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C392627B50F for ; Mon, 8 Jun 2026 12:52:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780923141; cv=none; b=dnCmEekVxaThhIaT8o2F0JCPGr818kBaDRb4uk1mc1JrW0dV4oEQlX0+zRFsHdAg7ymsQGzOiR86n9FYcfJMQX+c0zXUr2s2ljEso6ECBRVaSgKKDrXZjyjCGpWvns9B4BvQHYmAJ7Kt4s3cWNhv3a6RU+FrH+rcalfmd5sZu2A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780923141; c=relaxed/simple; bh=1jivHIImqDblS0RZVQ945KsTLSsn4Qtb45kJdvRw/uo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DKObjfknbWYNBfK8B2wQxPxkWYEDt5XHxYFZ5I6+Yn8OOUyKFCxNXgXchiR4iutvqKsfOugMwysSrLNEOL92eDPr0kmaH+7WyYIFWjB1xxeC/Z5/Dw+mIngOzUZaC8pZZzFpwwNsmsHNOuto94BW8puSB0qRWejZozWjZemonh4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PZ3UvmrR; arc=none smtp.client-ip=209.85.222.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PZ3UvmrR" Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-9157b94a07aso525769885a.0 for ; Mon, 08 Jun 2026 05:52:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780923139; x=1781527939; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1jivHIImqDblS0RZVQ945KsTLSsn4Qtb45kJdvRw/uo=; b=PZ3UvmrR5IcWJG7i3M4D9gt1RI+cFVx0mXyrJA6E6YmWLsNE++jEGAJrFrBB+SkHKJ dztLgRqvDukl3CfcZ88elwFerHO2wbejHDxOAaWMNHxutBIfOc/6hlIKnbJ8dWBlfoCw RWb3KUCOy1OnCHfDKOSpKB8Jxj8sgKCbbZvWKkTouyxaoaHobUpwnjnKGuzSQM3Sggar XXbsncMiKW411eCheM3mwPQfk0FTtHAI3J1nyYVyLL2mCeeKgN08TnQAO/nbk3jVyqKd i7eWzPC/HoE8QBXG4e3pLNE6iDrA4fqKuJFMMs2zOZ/zT4bF1/4g/FHYHf2p6z0BvFmR D/vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780923139; x=1781527939; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1jivHIImqDblS0RZVQ945KsTLSsn4Qtb45kJdvRw/uo=; b=mA7jTNfDxKbgi/uYWLyEfqxk+yK+NtEMooGi5ut9Inn6Z9HWxM1AiigDeEXVmQ51zO 8wo5HRQWs6FvcfbVxU6cQ2HWFQQ/JbfXjKdMz7XaiNtGk64l7J0G2dIMH6yGs8KFEdAP g3GRvUZw1JiWwoIHnxOhMn0kqEXle9Uw10R2RXn++YchLsrNnXfE3JsWaUBJlKxznVNK uwFWnIjSoewlQf9xrXGEiEwm/R208jeJ8yx+uYrRtokpif4uI0NAp7rJ2m6LqDBHu/3w Uf17XYxAB6/FJN1C0e3oBz7nv/csK5FQGhUssRtFo+the8HV62o1hVsXb298IrS62CdQ /Q5w== X-Forwarded-Encrypted: i=1; AFNElJ9GQzoXVRmV+zTK5/eCLwo/xA/TnmRR6wW2nieKTC+r52v9Gq2f5kVRfu2N8DGPFW4MbChksw8xAHVmqdY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+TUPaXc3cpOCccvd00ASAD09ieOfw48nc/AhQQzPEFYq7eRyU a3IVToppMl3a9FHFyrq3McN4ED3wtvcLNzb7lV6rgIq69THcs9Riwbol X-Gm-Gg: Acq92OHnpp/fv4ljI74vfwNr1aRA3ZXQlZhL1/v5/mwQdONJhL31Qd0fFB2NyDSGp9k Go7sDIsmqx81SAOnSxbXTRxn2sCFr0O+H5wY3CJtopjti+AYXyE4EU8l5SSzxNvHXjZXGP1kyij a5tmWloGfbqwLhza8WrMX+ekTxQBNvUFH8TPpLBhPxezFYv148vUZ0v+uk/Fgq6vPenbOrzeOZv XceF9ZYt+Jnr9ZZmFdT7GX2wUpj+VmT+n4SqgyYfOoQDjUMeTV2wUO1X0OS19ZR4wsXN0wj9afB hCIB2d2GmGBs/f5ajBcooNVOV9MhWplCiowFu+InE1hBArc5RptlWocwwts7Q/RWH1kyBGEprNq xYphWiyrqoC3HCtfXJURkh5iKA7B11nBwsqwEqcHsUKhkQgHWtHV0ECCwNwloz9BtrsC1d73jX0 vpNeh5nSG374WGGApFTTGhJn7G8Nk5IRs/Pt0TCHt7TnXRQsU+Tx1igk8lV6Qy/uL/mh39aKldH AO1sM8= X-Received: by 2002:a05:620a:a197:20b0:915:aad5:e945 with SMTP id af79cd13be357-915aad5e9b3mr1621801585a.21.1780923138541; Mon, 08 Jun 2026 05:52:18 -0700 (PDT) Received: from fedora (pool-100-11-178-145.phlapa.fios.verizon.net. [100.11.178.145]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9158a381febsm1698475285a.23.2026.06.08.05.52.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 05:52:17 -0700 (PDT) From: Dave Carey To: johannes.goede@oss.qualcomm.com Cc: platform-driver-x86@vger.kernel.org, pithenrich2d@googlemail.com, mpearson-lenovo@squebb.ca, hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com, armin.wolf@outlook.de, linux-kernel@vger.kernel.org, Dave Carey Subject: Re: [PATCH v5] platform/x86/lenovo: Add Yoga Book 9 keyboard dock detection driver Date: Mon, 8 Jun 2026 08:52:11 -0400 Message-ID: <20260608125211.11957-1-carvsdriver@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <78833ba9-7ea0-4c7f-8d41-ac0fd64ba15c@oss.qualcomm.com> References: <20260521144034.282419-1-carvsdriver@gmail.com> <20260527122701.242907-1-carvsdriver@gmail.com> <78833ba9-7ea0-4c7f-8d41-ac0fd64ba15c@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 08-Jun-26 11:13, Hans de Goede wrote: > Dave, I see that your "[PATCH v5] platform/x86/lenovo: Add Yoga Book 9 keyboard > dock detection driver" patch also uses a DMI match, is that necessary ? > > If we need the DMI match because the GUID is not unique enough, then we might > just as well add this functionality here as this patch is doing ... Yes, the DMI match is necessary, specifically for the block GUID (E7F300FA, LENOVO_FEATURE_STATUS_DATA). This is a generic Lenovo feature query interface that may appear on other Lenovo machines for unrelated purposes. Both GUIDs live under a PNP0C14 device with _UID "GMZN" on this machine, which is firmware-specific, but the WMI core matches by GUID alone — not by parent device UID. Without the DMI guard the block driver could bind on unrelated hardware and misinterpret WQAF's return value as a BKBD field. The event GUID (806BD2A2, LENOVO_BTKBD_EVENT) is named specifically for Bluetooth keyboard events in the BMOF and is likely unique to BT keyboard dock hardware, but keeping the DMI guard on both drivers is the safe choice given we can't easily verify all Lenovo platforms. > I do wonder since this seems to emit TP_HKEY_EV_TABLET_CHANGED thinkpad_acpi > events if the existing thinkpad_acpi support does not already provide working > SW_TABLET_MODE input ? > > If it does then also having the WMI driver emit SW_TABLET_MODE events seems > to be undesirable duplicate functionality. Tested: no overlap. On the YB9 the existing SW_TABLET_MODE source is lenovo-ymc (not thinkpad_acpi). The YMC driver tracks hinge/orientation modes (clamshell=0, tent/tablet/stand=1) — it does not track BT keyboard attachment state. I ran evtest on both the lenovo-ymc and yb9-kbdock input devices while detaching and reattaching the keyboard: lenovo-ymc did not fire at all; only yb9-kbdock emitted SW_TABLET_MODE events. There is no duplicate functionality. Regards, Dave