All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Ninad Naik <ninadnaik07@gmail.com>
Cc: broonie@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, me@brighamcampbell.com,
	linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org
Subject: Re: [PATCH] spi: dt-bindings: octeon: Convert to DT schema
Date: Mon, 8 Jun 2026 09:32:59 -0500	[thread overview]
Message-ID: <20260608143259.GA2569066-robh@kernel.org> (raw)
In-Reply-To: <20260607142356.2844008-1-ninadnaik07@gmail.com>

On Sun, Jun 07, 2026 at 07:53:56PM +0530, Ninad Naik wrote:
> Convert octeon-3010 to DT schema
> 
> Signed-off-by: Ninad Naik <ninadnaik07@gmail.com>
> ---
>  .../bindings/spi/cavium,octeon-3010-spi.yaml  | 67 +++++++++++++++++++
>  .../devicetree/bindings/spi/spi-octeon.txt    | 33 ---------
>  2 files changed, 67 insertions(+), 33 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/spi/cavium,octeon-3010-spi.yaml
>  delete mode 100644 Documentation/devicetree/bindings/spi/spi-octeon.txt
> 
> diff --git a/Documentation/devicetree/bindings/spi/cavium,octeon-3010-spi.yaml b/Documentation/devicetree/bindings/spi/cavium,octeon-3010-spi.yaml
> new file mode 100644
> index 000000000000..3dbbb4f3c104
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/cavium,octeon-3010-spi.yaml
> @@ -0,0 +1,67 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/spi/cavium,octeon-3010-spi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Cavium, Inc. OCTEON SoC SPI master controller
> +
> +description:
> +  The Cavium OCTEON SPI controller is an SPI master controller found in
> +  OCTEON SoCs.
> +
> +maintainers:
> +  - Mark Brown <broonie@kernel.org>

This should be someone with this h/w. But there doesn't appear to be any 
OCTEON maintainer. There isn't any .dts using the compatible either. 
Perhaps this driver and binding can just be removed?

> +  compatible:
> +    const: cavium,octeon-3010-spi


> +examples:
> +  - |
> +    / {

Drop. You don't need the root node.

> +        #address-cells = <2>;
> +        #size-cells = <2>;
> +
> +        intc: interrupt-controller {
> +            interrupt-controller;
> +            #interrupt-cells = <2>;
> +        };

Drop. Examples don't need providers.

Rob

  parent reply	other threads:[~2026-06-08 14:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-07 14:23 [PATCH] spi: dt-bindings: octeon: Convert to DT schema Ninad Naik
2026-06-07 18:33 ` Rob Herring (Arm)
2026-06-08 14:32 ` Rob Herring [this message]
2026-06-08 15:00   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260608143259.GA2569066-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel-mentees@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=me@brighamcampbell.com \
    --cc=ninadnaik07@gmail.com \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.