Re: [PATCH] perf build: Respect V=1 for Python extension builds

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `setup_quiet` variable is not initialized before its conditional assignment, allowing it to inherit arbitrary values from the user's environment when `V=1` is used.
--

commit 8926935922228db2605e3a9cb12821c9b36a4337
Author: Jens Remus <jremus@linux.ibm.com>

perf build: Respect V=1 for Python extension builds

This commit modifies the perf build system to conditionally pass the --quiet
flag to setup.py. It aims to respect the V=1 verbose build flag to ease
debugging of Python extension compilation issues.

> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 76b35ac19acbf..5fd6044680df5 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -401,6 +401,10 @@ export PYTHON_EXTBUILD_LIB PYTHON_EXTBUILD_TMP
>  
>  python-clean := $(call QUIET_CLEAN, python) $(RM) -r $(PYTHON_EXTBUILD) $(OUTPUT)python/perf*.so
>  
> +ifneq ($(quiet),)
> +setup_quiet=--quiet
> +endif
> +

[Severity: Low]
Does this leave setup_quiet uninitialized when V=1 is used?

Because make imports environment variables automatically, if a user happens
to have an environment variable named setup_quiet, it could be unintentionally
passed directly to util/setup.py when the quiet variable evaluates to empty.

Would it be safer to explicitly initialize setup_quiet to an empty string
before the conditional block to prevent environment variable contamination?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260608151525.2358438-1-jremus@linux.ibm.com?part=1