From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C3EA4C81 for ; Mon, 8 Jun 2026 20:09:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780949361; cv=none; b=XJub8qtudl+m7ftSY5s20znnWvhI8fd4Knk8LPRd1qL0p6BxQyWI3nCfaaqhe1gWU1IutWFFoW/VP5JBRMjDxqd7HfRM2Cmwj+FfQAfwWPAOAyleU5AY69toszumFWHu09pg5xgDtdM7UBvppEUrfColyOzOdRflPH0euCQCL2k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780949361; c=relaxed/simple; bh=nBNTZYDQ7i2r50wpd+udxDoC63MCPeXQfjOTnLrx3/Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Jde0knWaUhhcxPgmTwnX+pDFZMHOgotUn9lYvjQX078JqGvCJdaDWW0Et1Znh6yfuNuql+7RIQ10Pf9Co5HZZRM3XyvxZa1RrlPfkjceg4szKQQw92EKW73Dh0/++g5F7lKDITedQHo+wyzdfgD5owDr6mv9Xfx6jGDchTuNXWQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=G3BA9niF; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=MkvlXBjw; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="G3BA9niF"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="MkvlXBjw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780949359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mPGBC2/luUrvTKZA7fe3ursAMvj41Fm7p7HFv7E1PtE=; b=G3BA9niFT3h2Ql040nIM/556ypXEG5E9N2oaNgPsNldbRltPGCdjsPK3elRGo6TGh3beHE ASnpIOXCBlk7k0Vpqv/zmPgfi3LrzrCGoWdzzfk3hCaWBZ4JQULqSxaC0ZS1NghRTMxVkM 2S1GmA+wvNjB4hWULP9rQxQS7mTxFPg= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-655-XJuTw4I6NxyE8BCw1kihBA-1; Mon, 08 Jun 2026 16:09:18 -0400 X-MC-Unique: XJuTw4I6NxyE8BCw1kihBA-1 X-Mimecast-MFC-AGG-ID: XJuTw4I6NxyE8BCw1kihBA_1780949357 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-45eec2badc4so2296095f8f.2 for ; Mon, 08 Jun 2026 13:09:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780949357; x=1781554157; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mPGBC2/luUrvTKZA7fe3ursAMvj41Fm7p7HFv7E1PtE=; b=MkvlXBjwVUIcGHKUjSF3rV6xIMpcPztsAHCX6c5JfGKpuLmLJL6ZhXXpftrgMBvEmb Uc4VgMZt2L4rx+21/HVBgHjJmqUbyAGg/iDEcUT6zz7dRmc4vh9lsTNSgzJzLvJApFqJ klZv/aXeFJXm0J9JO9QrQj5niS96vBTlvx/w0p9wn7pWuHqA51eNX4GdwouVqBK2sUS7 lLeM4FUGYGaFX5wwxdWH31ODSK47xILIpAr+qEWWAXtFjwlI7S1SsozwzfPPI8IsBb7B GmZ8OIramOtjk2ClBvOqC2S9eQSotOGy02bqfGTD3zohs+TAfD4ucNk0Uz+RxMSlRQRM AERw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780949357; x=1781554157; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mPGBC2/luUrvTKZA7fe3ursAMvj41Fm7p7HFv7E1PtE=; b=jYgQmD9LtNIH+ZyydCfZJtlD7XeHuTZbAvSJvWo4gCf+VsDS3FyymGHn3CiruAmm55 leVG55JclX/SjaJPZpEO/kA4BeUcujIRBX/Ql5dMZc7LEA3Q5lw70DtTVG7yJIh5+Qnv AvhWy70yZ8n4WM5lVsRg+SjvlyA8vYRkDBZwBsp9XnB1kd8IOE5LyPvrIQjci3aBiQEO xr/Zl5mBDLSgtZFCm8B4UWW3xMIVfJ6TO5NsjMgTGTOn3OM0c1uXoJ0BKcBNhYUzKh4i mXLKKWWG6+q0eng7eR6nrOMbVsm3+lO6ZuwjbT+D9dkbFqiHOu4xkgV9sGZmB6leVmfj qi3Q== X-Forwarded-Encrypted: i=1; AFNElJ9HsVcG87lL29Jlc6WfqKjW7gPb/O70Al4i73Wlf66mJ4XW70wctKigJQYar6iVLMMl3fAbDj1fmRQ4BC4=@vger.kernel.org X-Gm-Message-State: AOJu0Yza7WeepMWQzPcun2bqIsQhUaYgQRRZ8XYQEOF4cFaT1BH9sq7q aYzL2RvrzPCrZwLvCmWrsAmVgsY6a01rGE63nRFAJN7ICRcxYPk1fxbfU/WOE6DDZt7DNVKI3dy lg0w+PO1UUjFyig6IdnwVBOXnm1CbiRq9o0KiV2yfhQUuRJAzxGtAUptkDJ8g7IJbLw== X-Gm-Gg: Acq92OGJ8BGKGn8xBxw8KpQhOPaiuqxo9+S41sC7sBMbUv5+mQIVLJKDPONn1X66/of oR09T+4wECHhjKE54jRfu9TQqViRtIUfuJM2gYgZwblsASzyl2KFzTtzkbrGNymyN5S+2PwHZ0e UCQuv72cBUk6CqXqLUyECiXQBL8juo1OI6dTtMipvxR4szrK72cAabvCY30+Hi2yDpCqkyFTsbv 81sYqsZYYRWxVFmDB+9Av4P48R0d3kfrJNQzFlfsNSLPt3+Z/3udArLjZNqNSvouZoTq1k6Yv2L +0D2bsI+IUSZDX/+oUq6KVgAkMIF2OdfSf+OVa3iHL5wwPCcwoxbwqXrFf8UOwXuo18fECKmKVK Z/k/AjFrMTtBPNFJl1dO/M1IkEHL5Duw0Vlhr1oplzZRJv9PoLloPbw== X-Received: by 2002:a05:6000:468d:b0:45e:6518:3299 with SMTP id ffacd0b85a97d-460302dbd32mr18415848f8f.5.1780949356824; Mon, 08 Jun 2026 13:09:16 -0700 (PDT) X-Received: by 2002:a05:6000:468d:b0:45e:6518:3299 with SMTP id ffacd0b85a97d-460302dbd32mr18415802f8f.5.1780949356252; Mon, 08 Jun 2026 13:09:16 -0700 (PDT) Received: from redhat.com (IGLD-80-230-85-71.inter.net.il. [80.230.85.71]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f35fb24sm58638802f8f.34.2026.06.08.13.09.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 13:09:15 -0700 (PDT) Date: Mon, 8 Jun 2026 16:09:10 -0400 From: "Michael S. Tsirkin" To: Gregory Price Cc: Lorenzo Stoakes , linux-kernel@vger.kernel.org, "David Hildenbrand (Arm)" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Hugh Dickins , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Ying Huang , Alistair Popple , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , Axel Rasmussen , Yuanchu Xie , Wei Xu , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , virtualization@lists.linux.dev, linux-mm@kvack.org, Andrea Arcangeli Subject: Re: [PATCH v10 16/37] mm: alloc_swap_folio: pass raw fault address to vma_alloc_folio Message-ID: <20260608160659-mutt-send-email-mst@kernel.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jun 08, 2026 at 11:59:32AM -0400, Gregory Price wrote: > On Mon, Jun 08, 2026 at 12:37:20PM +0100, Lorenzo Stoakes wrote: > > On Mon, Jun 08, 2026 at 04:37:41AM -0400, Michael S. Tsirkin wrote: > > > Same change as the previous patch but for alloc_swap_folio: > > > > Please don't say 'same change as the previous patch' :) explain what you're > > doing here. It's a pain to have to go check otherwise. > > > > MST you need to slow down a bit. > > I gave you this same feedback 3 versions ago: > > https://lore.kernel.org/linux-mm/agXUHItfxSwtriRF@gourry-fedora-PF4VCD3F/ > > ~Gregory Ooof I do try but the patchset is just too big. Sorry. I need to find a way to split it. Or maybe Matthew will tell me how to make it much smaller, he says he sees a way that will make everyone happy. Let's wait. -- MST