Re: [PATCH 24/60] kvm: Move kvm_vcpu spinloop members to struct kvm_vcpu_common

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch silently moves `halt_poll_ns` to `struct kvm_vcpu_common` and fails to update related documentation.
--

commit 6e23e7e10c3367adfc51b745b6493243d998e85a
Author: Joerg Roedel <joerg.roedel@amd.com>

kvm: Move kvm_vcpu spinloop members to struct kvm_vcpu_common

This commit moves the spinloop state to struct kvm_vcpu_common so that
detection is independent of the active struct kvm_vcpu. It also shifts
the halt_poll_ns variable to the common structure.

> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> index 9220c452aa3a7..f6e8a0b653b37 100644
> --- a/include/linux/kvm_host.h
> +++ b/include/linux/kvm_host.h
> @@ -350,6 +350,20 @@ struct kvm_vcpu_common {
>  	rwlock_t pid_lock;
>  	int sigset_active;
>  	sigset_t sigset;
> +	unsigned int halt_poll_ns;

[Severity: Low]
This isn't a bug, but the commit message only mentions moving the spinloop
members. Should the relocation of halt_poll_ns be mentioned in the commit
message as well?

Also, does Documentation/virt/kvm/halt-polling.rst need to be updated,
since it explicitly references kvm_vcpu->halt_poll_ns?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260608144252.351443-1-joro@8bytes.org?part=24