From: sashiko-bot@kernel.org
To: "Tomer Maimon" <tmaimon77@gmail.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v2 2/2] spi: dt-bindings: nuvoton,npcm-fiu: Convert to DT schema
Date: Mon, 08 Jun 2026 18:01:32 +0000 [thread overview]
Message-ID: <20260608180132.863CF1F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260608175418.1936892-3-tmaimon77@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The alias mapping convention for NPCM8XX was corrupted during the conversion to YAML.
--
commit 04ac00da42e73e1f171a2c2d3fdb84bc4768096a
Author: Tomer Maimon <tmaimon77@gmail.com>
spi: dt-bindings: nuvoton,npcm-fiu: Convert to DT schema
This commit converts the Nuvoton NPCM FIU binding to the DT schema format.
> diff --git a/Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.yaml b/Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.yaml
> new file mode 100644
> index 0000000000000..0f95def019105
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.yaml
[ ... ]
> +description: |
> + NPCM FIU supports single, dual and quad communication interface.
> +
> + The NPCM7XX supports three FIU modules:
> + FIU0 and FIUx support two chip selects
> + FIU3 supports four chip selects.
> +
> + The NPCM8XX supports four FIU modules:
> + FIU0 and FIUx support two chip selects
> + FIU1 and FIU3 support four chip selects.
> +
> + Alias convention:
> + The '/aliases' node should define:
> + For NPCM7xx: fiu0=&fiu0; fiu1=&fiu3; fiu2=&fiux;
> + For NPCM8xx: fiu0=&fiu0; fiu1=&fiu3; fiu2=&fiux; fiu3=&fiu1;
[Severity: Low]
Does this new alias mapping for NPCM8xx correctly match the original text
binding?
The original text binding in nuvoton,npcm-fiu.txt mapped the aliases as:
In the NPCM8XX BMC:
fiu0 represent fiu 0 controller
fiu1 represent fiu 1 controller
fiu2 represent fiu 3 controller
fiu3 represent fiu x controller
The converted documentation maps fiu1 to fiu3, fiu2 to fiux, and fiu3 to
fiu1. Could you confirm if this change in the documentation was intentional?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260608175418.1936892-1-tmaimon77@gmail.com?part=2
next prev parent reply other threads:[~2026-06-08 18:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 17:54 [PATCH v2 0/2] Nuvoton NPCM FIU DTS fixes and binding conversion Tomer Maimon
2026-06-08 17:54 ` [PATCH v2 1/2] arm: dts: nuvoton: npcm7xx: Drop bogus FIU memory reg-names Tomer Maimon
2026-06-09 7:13 ` Krzysztof Kozlowski
2026-06-08 17:54 ` [PATCH v2 2/2] spi: dt-bindings: nuvoton,npcm-fiu: Convert to DT schema Tomer Maimon
2026-06-08 18:01 ` sashiko-bot [this message]
2026-06-08 18:07 ` Tomer Maimon
2026-06-09 7:16 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260608180132.863CF1F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tmaimon77@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.