From: Nathan Chancellor <nathan@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Rosen Penev <rosenp@gmail.com>,
Jisheng Zhang <jszhang@kernel.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: cadence-xspi: Revert COMPILE_TEST support
Date: Mon, 8 Jun 2026 11:09:27 -0700 [thread overview]
Message-ID: <20260608180927.GA2211222@ax162> (raw)
In-Reply-To: <a723320d-20e1-4e5d-8a11-d63f84bc8f69@sirena.org.uk>
On Mon, Jun 08, 2026 at 11:31:33AM +0100, Mark Brown wrote:
> On Sat, Jun 06, 2026 at 03:26:04PM -0700, Nathan Chancellor wrote:
> > Commit 0c5b5c40dc31 ("spi: cadence-xspi: Add COMPILE_TEST support")
> > allows this driver to be built for 32-bit platforms, which causes a
> > semantic conflict with commit 4954d4eca469 ("spi: cadence-xspi: Support
> > 32bit and 64bit slave dma interface"), as readsq() and writesq() are
> > only available when targeting 64-bit platforms:
>
> > config SPI_CADENCE_XSPI
> > tristate "Cadence XSPI controller"
> > - depends on HAS_IOMEM || COMPILE_TEST
> > - depends on OF
> > + depends on OF && HAS_IOMEM && 64BIT
> > depends on SPI_MEM
>
> Why combine all these, they're not obviously related and HAS_IOMEM can
> be turned off.
This is just a straight revert of 0c5b5c40dc31, so it is just restoring
how it was before that change.
--
Cheers,
Nathan
next prev parent reply other threads:[~2026-06-08 18:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-06 22:26 [PATCH] spi: cadence-xspi: Revert COMPILE_TEST support Nathan Chancellor
2026-06-08 7:50 ` Uwe Kleine-König
2026-06-08 10:31 ` Mark Brown
2026-06-08 18:09 ` Nathan Chancellor [this message]
2026-06-08 12:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260608180927.GA2211222@ax162 \
--to=nathan@kernel.org \
--cc=broonie@kernel.org \
--cc=jszhang@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.