From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B209233942 for ; Tue, 9 Jun 2026 02:32:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780972362; cv=none; b=iMT026lxhwdIDB43ip6otqslqf0Bzhj79WtvkOgnB23ohfwpogVq1Q53FJ/V0fZh7OW1tD96TdwhzeLd29I5jC3ROoxduJAaM+rOcQbIzNGAN7gQlcOILS/q2KUJAsEya63ptdPPN+1Q/DxCEvcwo5li37u4zZSTHxeQhi3leRA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780972362; c=relaxed/simple; bh=jS2F9Jgzt846e9JgiW+XQlPdCYZNvcDO2LATGN0DKSs=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SOE0qK0NyaBO5MOJ4FUjDUak9Jrv9js8AbFocE7IsmDBRuqtvxJjpoBsneQpPYaiy7Wj5zOo5aTKAhL6AJjiRHsUn6KHxOmbjZxp8FekzU+fluJa/hIBTxiHD/OIpLSydzBKjHUiDIe8JR5WSjSxqfS3ZrulYSZzDiUisegRJUM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nwnbYsC/; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nwnbYsC/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E9221F00893; Tue, 9 Jun 2026 02:32:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780972361; bh=rjTZYyEiFPG9lIFZHtHltObOA2EYCJttfoFzooVqXaE=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=nwnbYsC/rWG3dvWoAVqhz+BuOVBXmNpQQ/+OzNP7IfDXyS3T1x5yW3JznbeyVwXZS gh9XzMMnfhFRb/7ljIf1bwor5DEFkHYBS6haVvyVDWWE1OUjATc+7j5f9WscGEEo4B R67XkpL1W31v2Vpptup7c3e3tVpizlBsR+J+EbyZcPwL64NIf/PDdrLxsieYlm7iFo en86VeOW7jtJt9WLOzfgVVZZxTDstcoZVIhdUjhb0a7hOb41pnBPWNR7VeWww+6b1a ELMJFk6XGDzwP5KaY3bW6hzLAEOfC+Ee2Omv1vyDky+z94lssufFrRA1JLOAQuR+Rh MOkfclrqxbABw== Date: Mon, 8 Jun 2026 19:32:39 -0700 From: Jakub Kicinski To: Fernando Fernandez Mancera Cc: netdev@vger.kernel.org, horms@kernel.org, pabeni@redhat.com, edumazet@google.com, davem@davemloft.net, idosch@nvidia.com, dsahern@kernel.org, Nicolas Dichtel Subject: Re: [PATCH 1/3 net-next v5] ipv4: centralize devconf sysctl handling Message-ID: <20260608193239.5fe7c7d8@kernel.org> In-Reply-To: References: <20260607110123.5939-1-fmancera@suse.de> <20260608090333.21c94721@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 8 Jun 2026 19:41:54 +0200 Fernando Fernandez Mancera wrote: > On 6/8/26 6:03 PM, Jakub Kicinski wrote: > > On Sun, 7 Jun 2026 13:01:21 +0200 Fernando Fernandez Mancera wrote: > >> The logic for handling IPv4 devconf sysctls is scattered. Notification > >> and cache flushes are managed in devinet_conf_proc(), while a separate > >> ipv4_doint_and_flush() function and DEVINET_SYSCTL_FLUSHING_ENTRY macro > >> is used for properties that solely require a cache flush. > > > > Hi Fernando! > > > > Do you have the necessary iproute2 patches pushed out somewhere? > > I'll pull them in the CI to make sure the test works. > > > > Oh sorry, I thought this was using iproute2-next. > > Yes, feel free to find it either here [0] or pick it from [1]. > > [0] https://lore.kernel.org/netdev/20260601143242.6729-1-fmancera@suse.de/ > > [1] > https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=fdb064bf64e5df738f5f823a11f315340679d336 Tests pass, thanks! but ruff check fails with tools/testing/selftests/net/rtnetlink.py:45: [E722] Do not use bare `except` There's a specific error cmd()/ip() raises on non-zero return, you can catch that one. -- pw-bot: cr