From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 425022E62B4 for ; Mon, 8 Jun 2026 22:10:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780956619; cv=none; b=m+DrM1TLy/zeG/J/zl3sTk/QdKRuE7YnDMzaNQ74DNyNdBwVAwHC+PxuBCEd0z4GxtimFu9HLDNQRf/Xb9PXkBrFa/Ufc5BtcIVaNXyizfRrqvP9bskFA3HqNCI2heq2cFQjzBaJUCSDMgLNC35rAwiMi+0igqGK1UiK01zFKoY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780956619; c=relaxed/simple; bh=NL0oKvmVTa/zXr1uPnblTwBUwBRGTaAaPp1ZVcfBm34=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OGHdysxa1vU/TVVD3PLwwM5T+K4av1YqTUL8hF5u2K7m1ticG5Y5FxIisRtR1F8k+YJdxK7B8zQW59HstGh3ncjZHdxk6quJZcIVMI5T1NBxVO8fxHo0Pum+hIbIDfzommqRUxYcK4vFVb60OQch5crnXa+bd42ZyAyMV5QOH3I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QdHRVwFn; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QdHRVwFn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF2AF1F00893; Mon, 8 Jun 2026 22:10:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780956618; bh=sZJLdQEq2BTURSNb8D2kpsRkD/u496xTp2zxzBIScZs=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=QdHRVwFn89maeVD9MbMWpTVcct+TDQto0kYqVGtcseeMfCSHkwbDBpp/fTG+6sSk7 7RUpfq7H0U4tLiQy6piEGQpsuCAKN0ZS9KuGBS1PGxsEscgDcrb88YX9IbK/1rKt0Z 3awBSf02OqVachP5kkFmg5xjqSPmgH8lrxFYe+4mZLExEjrAp0IAWc8x0U5h4KF9vR CuXIc7pAuxxUwH9AK+9QcbB0afVpnZMK5QfASmprPfHEm8NkXj1O6/v6guFaOtTeMD 6fe1lprHf2VeJy7KrClsTuLoK4zd5lEfiuKl6ovDNOOH446EwE0WawIW4Spr2uAoeT k4eLTIParQRdA== Date: Mon, 8 Jun 2026 15:10:14 -0700 From: Nathan Chancellor To: Jeff Layton Cc: NeilBrown , Christian Brauner , Jan Kara , linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH] filelock: update break_lease() stub with correct arguments Message-ID: <20260608221014.GD2340474@ax162> References: <20260607-breakleasefix-v1-1-658dce536d15@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260607-breakleasefix-v1-1-658dce536d15@kernel.org> On Sun, Jun 07, 2026 at 06:46:11AM -0400, Jeff Layton wrote: > When CONFIG_FILE_LOCKING=n, break_lease() becomes a no-op. The arguments > for the function still need to change though. > > Fixes: 4be9f3cc582a ("filelock: rework the __break_lease API to use flags") > Reported-by: Nathan Chancellor > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202606071029.DKCs8WOs-lkp@intel.com/ > Signed-off-by: Jeff Layton Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor # build > --- > include/linux/filelock.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/filelock.h b/include/linux/filelock.h > index 7a7a6e8a9a08..ec11cc6b4c58 100644 > --- a/include/linux/filelock.h > +++ b/include/linux/filelock.h > @@ -584,7 +584,7 @@ static inline bool is_delegated(struct delegated_inode *di) > return false; > } > > -static inline int break_lease(struct inode *inode, bool wait) > +static inline int break_lease(struct inode *inode, unsigned int mode) > { > return 0; > } > > --- > base-commit: 4d14e43b656c6ddefa91114975470a6a992b30ee > change-id: 20260607-breakleasefix-3d5a9f1e1fd6 > > Best regards, > -- > Jeff Layton > -- Cheers, Nathan