Re: [PATCH v4 phy-next 14/16] dt-bindings: phy: lynx-10g: initial document

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Schema validation error due to conditionally required `big-endian` property not declared at the top-level
--

commit 2c5c4d6b6c1efda8718b0e291015499912a81e6e
Author: Vladimir Oltean <vladimir.oltean@nxp.com>

dt-bindings: phy: lynx-10g: initial document

This commit adds the YAML device tree binding schema for the 10G Lynx
SerDes, supporting various QorIQ and Layerscape SoCs. It defines a common
register map with SoC-specific configurations handled via conditional blocks.

> diff --git a/Documentation/devicetree/bindings/phy/fsl,lynx-10g.yaml b/Documentation/devicetree/bindings/phy/fsl,lynx-10g.yaml
> new file mode 100644
> index 0000000000000..eaef585338258
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/fsl,lynx-10g.yaml

[ ... ]

> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - fsl,ls1046a-serdes1
> +              - fsl,ls1046a-serdes2
> +    then:
> +      properties:
> +        big-endian: true
> +      required:
> +        - big-endian

[Severity: Low]
Will this cause a schema validation error when dtbs_check is run?

Because big-endian is omitted from the top-level properties block, it
appears the additionalProperties constraint below will reject it even
when the compatible string matches.

Could big-endian: type: boolean be added to the top-level properties
dictionary, or should additionalProperties: false be changed to
unevaluatedProperties: false?

> +
> +additionalProperties: false
> +
> +examples:

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260608221710.1572971-1-vladimir.oltean@nxp.com?part=14

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy