Re: [PATCH v1 3/3] ASoC: qcom: qdsp6: generalize GPR service domain

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch adds a new `dest_domain` parameter to allocation helpers but fails to update all caller sites, causing 'too few arguments to function' compilation errors.
--

commit 7837af8c42df151e433f6c30da08674cc4716b78
Author: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>

ASoC: qcom: qdsp6: generalize GPR service domain

This commit updates the AudioReach allocation helpers to accept an
explicit dest_domain parameter. It also updates various callers to pass
the appropriate destination domain ID.

> diff --git a/sound/soc/qcom/qdsp6/audioreach.h b/sound/soc/qcom/qdsp6/audioreach.h
> index 62a2fd79bbcb9..d07fcd3a8fa73 100644
> --- a/sound/soc/qcom/qdsp6/audioreach.h
> +++ b/sound/soc/qcom/qdsp6/audioreach.h
[ ... ]
> -void *audioreach_alloc_apm_cmd_pkt(int pkt_size, uint32_t opcode, uint32_t
> -				    token);
> +void *audioreach_alloc_apm_cmd_pkt(int pkt_size, u32 opcode, u32 token,
> +				   u16 dest_domain);
>  void audioreach_set_default_channel_mapping(u8 *ch_map, int num_channels);
> -void *audioreach_alloc_cmd_pkt(int payload_size, uint32_t opcode,
> -			       uint32_t token, uint32_t src_port,
> -			       uint32_t dest_port);
> -void *audioreach_alloc_apm_pkt(int pkt_size, uint32_t opcode, uint32_t token,
> -				uint32_t src_port);
> -void *audioreach_alloc_pkt(int payload_size, uint32_t opcode,
> -			   uint32_t token, uint32_t src_port,
> -			   uint32_t dest_port);
> +void *audioreach_alloc_cmd_pkt(int payload_size, u32 opcode, u32 token,
> +			       u32 src_port, u32 dest_port, u16 dest_domain);

[Severity: Low]
Were some callers missed when updating these function signatures?

The new dest_domain parameter is required, but it appears some existing
callers in sound/soc/qcom/qdsp6/audioreach.c were not updated and are
still using the old signatures.

For example, in audioreach_shmem_register_event():

    pkt = audioreach_alloc_cmd_pkt(payload_size,
                                   APM_CMD_REGISTER_MODULE_EVENTS, 0,
                                   graph->port->id, graph->shm_iid);

And in audioreach_setup_push_pull():

    pkt = audioreach_alloc_apm_cmd_pkt(payload_size, APM_CMD_SET_CFG, 0);

Does this cause compilation errors due to too few arguments being passed
to these helpers?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260609064038.492641-1-ajay.nandam@oss.qualcomm.com?part=3