From: sashiko-bot@kernel.org
To: lianfeng.ouyang <lianfeng.ouyang@starfivetech.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: rng: starfive,jh7110-trng: add jhb100, drop jh8100
Date: Tue, 09 Jun 2026 10:22:22 +0000 [thread overview]
Message-ID: <20260609102223.26AB81F00898@smtp.kernel.org> (raw)
In-Reply-To: <20260609095726.160559-2-lianfeng.ouyang@starfivetech.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Removal of 'starfive,jh8100-trng' compatible string breaks device tree ABI.
--
commit 55269300e907ca4d974f2fe40b38e11260ec7ecb
Author: Lianfeng Ouyang <lianfeng.ouyang@starfivetech.com>
dt-bindings: rng: starfive,jh7110-trng: add jhb100, drop jh8100
This commit updates the StarFive TRNG device tree bindings to reflect
current SoC support. It adds the starfive,jhb100-trng compatible string
and drops the obsolete starfive,jh8100-trng compatible string.
> diff --git a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> index 4639247e9e510..d21769b7d54e6 100644
> --- a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> +++ b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
[ ... ]
> properties:
> compatible:
> - oneOf:
> - - items:
> - - const: starfive,jh8100-trng
> - - const: starfive,jh7110-trng
> - - const: starfive,jh7110-trng
> + enum:
> + - starfive,jh7110-trng
> + - starfive,jhb100-trng
[Severity: Medium]
Does removing the starfive,jh8100-trng compatible string break device tree
ABI compatibility?
Device tree bindings are generally considered a stable ABI, so existing or
downstream device trees using this compatible string might fail schema
validation during dtbs_check.
Should this compatible string be retained and perhaps marked as deprecated
instead of being completely removed from the properties section?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260609095726.160559-1-lianfeng.ouyang@starfivetech.com?part=1
next prev parent reply other threads:[~2026-06-09 10:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 9:57 [PATCH v4 0/2] hwrng: starfive: updates for jh7110-trng DT binding and rework clk/reset teardown lianfeng.ouyang
2026-06-09 9:57 ` [PATCH v4 1/2] dt-bindings: rng: starfive,jh7110-trng: add jhb100, drop jh8100 lianfeng.ouyang
2026-06-09 10:22 ` sashiko-bot [this message]
2026-06-09 16:13 ` Conor Dooley
2026-06-09 9:57 ` [PATCH v4 2/2] hwrng: starfive: rework clk/reset teardown order for JHB100 lianfeng.ouyang
2026-06-09 10:26 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260609102223.26AB81F00898@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lianfeng.ouyang@starfivetech.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.