Re: [PATCH v2 04/12] dt-bindings: iio: dac: ad5686: rework on power supplies

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] Device Tree binding ABI breakage due to newly required properties without fallback.
--

commit b368aecb172cba4ed369348bc821f626012fd870
Author: Rodrigo Alencar <rodrigo.alencar@analog.com>

dt-bindings: iio: dac: ad5686: rework on power supplies

This commit adds supplies for VDD, VLOGIC and VREF input voltage pins,
deprecates vcc-supply in favor of vref-supply, and updates the required
properties.

> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> index 4680d4753dd4d..2abdbf325392d 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
[ ... ]
> @@ -53,9 +64,23 @@ properties:
>  required:
>    - compatible
>    - reg
> +  - vdd-supply
> +  - vlogic-supply

[Severity: Critical]
Does unconditionally adding vdd-supply and vlogic-supply to the global
required list break backward compatibility? Old device trees that did not
specify these supplies will now fail schema validation.

>  
>  allOf:
>    - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            anyOf:
> +              - const: adi,ad5676
> +              - const: adi,ad5683
> +              - const: adi,ad5684
> +              - const: adi,ad5686
> +    then:
> +      required:
> +        - vref-supply

[Severity: Critical]
Does strictly mandating vref-supply break validation for older device trees
that used the now-deprecated vcc-supply?

While the driver is updated later in the series to gracefully handle missing
supplies and check both vcc and vref, the binding schema itself incorrectly
rejects existing valid DTs.

Should the schema use an anyOf block to permit either vcc-supply or
vref-supply for backward compatibility, and avoid making new supply
properties strictly required if they weren't in the original schema?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260609-ad5686-new-features-v2-0-70b423f5c76d@analog.com?part=4