* [cifs:for-next-next 15/16] fs/smb/client/cifsfs.c:1204:22: error: use of undeclared identifier 'FS_XFLAG_CASEFOLD'
@ 2026-06-09 10:24 kernel test robot
2026-06-09 14:11 ` Chuck Lever
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2026-06-09 10:24 UTC (permalink / raw)
To: Chuck Lever
Cc: llvm, oe-kbuild-all, linux-cifs, samba-technical, Steve French,
Roland Mainz
tree: git://git.samba.org/sfrench/cifs-2.6.git for-next-next
head: 910f40bbf5dc81b5fcc5592fdd4caa29e80ffce0
commit: 4fb53948f97f5e89700fa933ba7d928ba1980f06 [15/16] cifs: Implement fileattr_get for case sensitivity
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20260609/202606091825.Fvo4zzYp-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project 7917772d7d61384696c61102c08c2ea158e610fa)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260609/202606091825.Fvo4zzYp-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202606091825.Fvo4zzYp-lkp@intel.com/
All errors (new ones prefixed by >>):
>> fs/smb/client/cifsfs.c:1204:22: error: use of undeclared identifier 'FS_XFLAG_CASEFOLD'
1204 | fa->fsx_xflags |= FS_XFLAG_CASEFOLD;
| ^~~~~~~~~~~~~~~~~
fs/smb/client/cifsfs.c:1211:21: error: use of undeclared identifier 'FS_XFLAG_CASEFOLD'
1211 | fa->fsx_xflags |= FS_XFLAG_CASEFOLD;
| ^~~~~~~~~~~~~~~~~
>> fs/smb/client/cifsfs.c:1215:21: error: use of undeclared identifier 'FS_XFLAG_CASENONPRESERVING'
1215 | fa->fsx_xflags |= FS_XFLAG_CASENONPRESERVING;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
3 errors generated.
vim +/FS_XFLAG_CASEFOLD +1204 fs/smb/client/cifsfs.c
1168
1169 int cifs_fileattr_get(struct dentry *dentry, struct file_kattr *fa)
1170 {
1171 struct cifs_sb_info *cifs_sb = CIFS_SB(dentry->d_sb);
1172 struct cifs_tcon *tcon = cifs_sb_master_tcon(cifs_sb);
1173 struct inode *inode = d_inode(dentry);
1174 u32 attrs;
1175
1176 /* Preserve FS_COMPR_FL previously reported by cifs_ioctl(). */
1177 if (CIFS_I(inode)->cifsAttrs & ATTR_COMPRESSED)
1178 fa->flags |= FS_COMPR_FL;
1179
1180 /*
1181 * FS_CASEFOLD_FL is defined by UAPI as a folder attribute,
1182 * and userspace tools (e.g., lsattr) display it only on
1183 * directories. Confine the case-handling bits to directories
1184 * to match that convention; for non-directories the share's
1185 * case semantics are still discoverable through the parent.
1186 */
1187 if (!S_ISDIR(inode->i_mode))
1188 return 0;
1189
1190 /*
1191 * The server's FS_ATTRIBUTE_INFORMATION response, cached on
1192 * the tcon at mount, reflects the share's case-handling
1193 * semantics after any POSIX extensions negotiation. Prefer
1194 * it over the client-local nocase mount option, which only
1195 * governs dentry comparison on this superblock.
1196 *
1197 * QueryFSInfo is best-effort at mount; when it did not
1198 * populate fsAttrInfo, MaxPathNameComponentLength remains
1199 * zero. In that case fall back to nocase so the reporting
1200 * matches the comparison behavior installed on the sb.
1201 */
1202 if (le32_to_cpu(tcon->fsAttrInfo.MaxPathNameComponentLength) == 0) {
1203 if (tcon->nocase) {
> 1204 fa->fsx_xflags |= FS_XFLAG_CASEFOLD;
1205 fa->flags |= FS_CASEFOLD_FL;
1206 }
1207 return 0;
1208 }
1209 attrs = le32_to_cpu(tcon->fsAttrInfo.Attributes);
1210 if (!(attrs & FILE_CASE_SENSITIVE_SEARCH)) {
1211 fa->fsx_xflags |= FS_XFLAG_CASEFOLD;
1212 fa->flags |= FS_CASEFOLD_FL;
1213 }
1214 if (!(attrs & FILE_CASE_PRESERVED_NAMES))
> 1215 fa->fsx_xflags |= FS_XFLAG_CASENONPRESERVING;
1216 return 0;
1217 }
1218
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [cifs:for-next-next 15/16] fs/smb/client/cifsfs.c:1204:22: error: use of undeclared identifier 'FS_XFLAG_CASEFOLD'
2026-06-09 10:24 [cifs:for-next-next 15/16] fs/smb/client/cifsfs.c:1204:22: error: use of undeclared identifier 'FS_XFLAG_CASEFOLD' kernel test robot
@ 2026-06-09 14:11 ` Chuck Lever
0 siblings, 0 replies; 3+ messages in thread
From: Chuck Lever @ 2026-06-09 14:11 UTC (permalink / raw)
To: kernel test robot
Cc: llvm, oe-kbuild-all, linux-cifs, samba-technical, Steve French,
Roland Mainz
On 6/9/26 6:24 AM, kernel test robot wrote:
> >> fs/smb/client/cifsfs.c:1204:22: error: use of undeclared identifier 'FS_XFLAG_CASEFOLD'
FS_XFLAG_CASEFOLD and FS_XFLAG_CASENONPRESERVING are defined by
"fs: Add case sensitivity flags to file_kattr", the foundational
patch of the case-sensitivity series. That patch adds the two
macros to include/uapi/linux/fs.h and folds them into
FS_XFLAG_RDONLY_MASK in include/linux/fileattr.h.
The cifs consumer ("cifs: Implement fileattr_get for case
sensitivity") landed in for-next-next without that prerequisite,
so the identifiers are undeclared. The failure reproduces under
both clang and gcc because the macros are simply absent, not
because of any arch- or compiler-specific construct.
Steve, the cifs patch should not be applied ahead of its
dependency. Either base for-next-next on the branch carrying
"fs: Add case sensitivity flags to file_kattr", or drop the cifs
patch until that patch lands. The full series is intended to be
merged together for this reason.
No fix is needed in the cifs patch itself.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [cifs:for-next-next 15/16] fs/smb/client/cifsfs.c:1204:22: error: use of undeclared identifier 'FS_XFLAG_CASEFOLD'
@ 2026-06-05 7:15 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2026-06-05 7:15 UTC (permalink / raw)
To: Chuck Lever
Cc: llvm, oe-kbuild-all, linux-cifs, samba-technical, Steve French,
Roland Mainz
tree: git://git.samba.org/sfrench/cifs-2.6.git for-next-next
head: 910f40bbf5dc81b5fcc5592fdd4caa29e80ffce0
commit: 4fb53948f97f5e89700fa933ba7d928ba1980f06 [15/16] cifs: Implement fileattr_get for case sensitivity
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20260605/202606050943.QQwHMsZH-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project f43d6834093b19baf79beda8c0337ab020ac5f17)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260605/202606050943.QQwHMsZH-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202606050943.QQwHMsZH-lkp@intel.com/
All errors (new ones prefixed by >>):
>> fs/smb/client/cifsfs.c:1204:22: error: use of undeclared identifier 'FS_XFLAG_CASEFOLD'
1204 | fa->fsx_xflags |= FS_XFLAG_CASEFOLD;
| ^~~~~~~~~~~~~~~~~
fs/smb/client/cifsfs.c:1211:21: error: use of undeclared identifier 'FS_XFLAG_CASEFOLD'
1211 | fa->fsx_xflags |= FS_XFLAG_CASEFOLD;
| ^~~~~~~~~~~~~~~~~
>> fs/smb/client/cifsfs.c:1215:21: error: use of undeclared identifier 'FS_XFLAG_CASENONPRESERVING'
1215 | fa->fsx_xflags |= FS_XFLAG_CASENONPRESERVING;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
3 errors generated.
vim +/FS_XFLAG_CASEFOLD +1204 fs/smb/client/cifsfs.c
1168
1169 int cifs_fileattr_get(struct dentry *dentry, struct file_kattr *fa)
1170 {
1171 struct cifs_sb_info *cifs_sb = CIFS_SB(dentry->d_sb);
1172 struct cifs_tcon *tcon = cifs_sb_master_tcon(cifs_sb);
1173 struct inode *inode = d_inode(dentry);
1174 u32 attrs;
1175
1176 /* Preserve FS_COMPR_FL previously reported by cifs_ioctl(). */
1177 if (CIFS_I(inode)->cifsAttrs & ATTR_COMPRESSED)
1178 fa->flags |= FS_COMPR_FL;
1179
1180 /*
1181 * FS_CASEFOLD_FL is defined by UAPI as a folder attribute,
1182 * and userspace tools (e.g., lsattr) display it only on
1183 * directories. Confine the case-handling bits to directories
1184 * to match that convention; for non-directories the share's
1185 * case semantics are still discoverable through the parent.
1186 */
1187 if (!S_ISDIR(inode->i_mode))
1188 return 0;
1189
1190 /*
1191 * The server's FS_ATTRIBUTE_INFORMATION response, cached on
1192 * the tcon at mount, reflects the share's case-handling
1193 * semantics after any POSIX extensions negotiation. Prefer
1194 * it over the client-local nocase mount option, which only
1195 * governs dentry comparison on this superblock.
1196 *
1197 * QueryFSInfo is best-effort at mount; when it did not
1198 * populate fsAttrInfo, MaxPathNameComponentLength remains
1199 * zero. In that case fall back to nocase so the reporting
1200 * matches the comparison behavior installed on the sb.
1201 */
1202 if (le32_to_cpu(tcon->fsAttrInfo.MaxPathNameComponentLength) == 0) {
1203 if (tcon->nocase) {
> 1204 fa->fsx_xflags |= FS_XFLAG_CASEFOLD;
1205 fa->flags |= FS_CASEFOLD_FL;
1206 }
1207 return 0;
1208 }
1209 attrs = le32_to_cpu(tcon->fsAttrInfo.Attributes);
1210 if (!(attrs & FILE_CASE_SENSITIVE_SEARCH)) {
1211 fa->fsx_xflags |= FS_XFLAG_CASEFOLD;
1212 fa->flags |= FS_CASEFOLD_FL;
1213 }
1214 if (!(attrs & FILE_CASE_PRESERVED_NAMES))
> 1215 fa->fsx_xflags |= FS_XFLAG_CASENONPRESERVING;
1216 return 0;
1217 }
1218
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-06-09 14:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-09 10:24 [cifs:for-next-next 15/16] fs/smb/client/cifsfs.c:1204:22: error: use of undeclared identifier 'FS_XFLAG_CASEFOLD' kernel test robot
2026-06-09 14:11 ` Chuck Lever
-- strict thread matches above, loose matches on Subject: below --
2026-06-05 7:15 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.