All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: Prabhakar <prabhakar.csengg@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org,
	wsa+renesas@sang-engineering.com
Subject: Re: [PATCH 4/5] arm64: dts: renesas: r9a09g087: Add DU node
Date: Tue, 09 Jun 2026 14:19:42 +0000	[thread overview]
Message-ID: <20260609141942.6C2581F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260609125353.401124-5-prabhakar.mahadev-lad.rj@bp.renesas.com>

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The macro `R9A09G087_LCDC_CLKD` is referenced in the `clocks` property but is undeclared, causing a Device Tree build failure.
- [Low] The compatible strings `renesas,r9a09g087-du` and `renesas,r9a09g077-du` are added without corresponding Device Tree binding schemas.
--

commit 3aa7f5ef71efe2b2f0c8c868ca73eebb03c02010
Author: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

arm64: dts: renesas: r9a09g087: Add DU node

This commit adds the Display Unit (DU) node to the RZ/N2H (r9a09g087) SoC
Device Tree.

> diff --git a/arch/arm64/boot/dts/renesas/r9a09g087.dtsi b/arch/arm64/boot/dts/renesas/r9a09g087.dtsi
> index cb2eabe3242e0..21250caf31493 100644
> --- a/arch/arm64/boot/dts/renesas/r9a09g087.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a09g087.dtsi
> @@ -1272,6 +1272,30 @@ sdhi1_vqmmc: vqmmc-regulator {
>  			};
>  		};
>  
> +		du: display@920c0000 {
> +			compatible = "renesas,r9a09g087-du", "renesas,r9a09g077-du";

[Severity: Low]
Are these compatible strings documented in the device tree bindings?

It appears they are introduced here without a corresponding update to the YAML
schemas in Documentation/devicetree/bindings/, which might cause
make dtbs_check validation errors.

> +			reg = <0 0x920c0000 0 0x10000>;
> +			interrupts = <GIC_SPI 781 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&cpg CPG_CORE R9A09G087_CLK_PCLKAH>,
> +				 <&cpg CPG_MOD 1204>,
> +				 <&cpg CPG_CORE R9A09G087_LCDC_CLKD>;

[Severity: Low]
Is the R9A09G087_LCDC_CLKD macro defined anywhere?

It seems its definition is missing from the clock bindings header, which will
cause a Device Tree Compiler (dtc) syntax error and break the build.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260609125353.401124-1-prabhakar.mahadev-lad.rj@bp.renesas.com?part=4

  reply	other threads:[~2026-06-09 14:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-09 12:53 [PATCH 0/5] Add DU, VSPD and FCPVD support for RZ/T2H and RZ/N2H SoCs Prabhakar
2026-06-09 12:53 ` [PATCH 1/5] arm64: dts: renesas: r9a09g077: Add VSPD and FCPVD nodes Prabhakar
2026-06-09 13:17   ` sashiko-bot
2026-06-09 12:53 ` [PATCH 2/5] arm64: dts: renesas: r9a09g077: Add DU node Prabhakar
2026-06-09 13:57   ` sashiko-bot
2026-06-09 12:53 ` [PATCH 3/5] arm64: dts: renesas: r9a09g087: Add VSPD and FCPVD nodes Prabhakar
2026-06-09 14:07   ` sashiko-bot
2026-06-09 12:53 ` [PATCH 4/5] arm64: dts: renesas: r9a09g087: Add DU node Prabhakar
2026-06-09 14:19   ` sashiko-bot [this message]
2026-06-09 12:53 ` [PATCH 5/5] arm64: dts: renesas: Add LCDC overlays for RZ/T2H and RZ/N2H EVKs with ADV7513 Prabhakar
2026-06-09 14:30   ` sashiko-bot
2026-06-09 16:28     ` Lad, Prabhakar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260609141942.6C2581F00893@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=prabhakar.csengg@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.