Re: [PATCH v4 02/19] perf test: Add workload-ctl option

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message claims to add a `--workload-ctl` option, but the implementation actually adds a `--record-ctl` option.
--

commit be5e10b3228f286fe50c54ca1ba231a4a933afc1
Author: James Clark <james.clark@linaro.org>

perf test: Add workload-ctl option

This commit adds an option to 'perf test' to open a named FIFO and send
enable and disable commands before and after invoking a builtin workload.
This allows syncing with a 'perf record' session to limit the recording
scope.

> perf test: Add workload-ctl option
> 
> Add a --workload-ctl=fifo:ctl-fifo[,ack-fifo] option for 'perf test
> -w'.

[Severity: Medium]
This isn't a bug in the code, but there is a mismatch between the commit
message and the implemented option. The commit title and message specify
'--workload-ctl', but the documentation and code implement '--record-ctl'.

Could the commit message be updated to match the implementation, or should
the option be renamed to '--workload-ctl' in the code?

> diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
> --- a/tools/perf/tests/builtin-test.c
> +++ b/tools/perf/tests/builtin-test.c
[ ... ]
> @@ -1486,6 +1664,8 @@ int cmd_test(int argc, const char **argv)
>  	OPT_UINTEGER('r', "runs-per-test", &runs_per_test,
>  		     "Run each test the given number of times, default 1"),
>  	OPT_STRING('w', "workload", &workload, "work", "workload to run for testing, use '--list-workloads' to list the available ones."),
> +	OPT_STRING(0, "record-ctl", &workload_control, "fifo:ctl-fifo[,ack-fifo]",
> +		   "Write enable to the fifo just before running the workload and disable after, with optional ack from ack-fifo"),

[Severity: Medium]
This is where the option is defined as "record-ctl" in cmd_test() instead
of the promised "workload-ctl". Does this option name need to be updated?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260609-james-cs-context-tracking-fix-v4-0-44f9fb9e5c42@linaro.org?part=2