Re: [PATCH v6 3/7] dt-bindings: clock: qcom: Add support for CAMCC for Eliza

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Unconditional requirement of `#power-domain-cells` and `#reset-cells` incorrectly forces the `qcom,eliza-cambistmclkcc` variant to advertise itself as a power domain and reset provider.
--

commit 1b86ec5394cef411456da0c6a6314eebda1d7c44
Author: Taniya Das <taniya.das@oss.qualcomm.com>

dt-bindings: clock: qcom: Add support for CAMCC for Eliza
    
This commit adds the Eliza camera and camera BIST clock controllers
to the Milos camcc binding. It also adds #power-domain-cells to the
required properties list and introduces the device tree binding headers.

> diff --git a/Documentation/devicetree/bindings/clock/qcom,milos-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,milos-camcc.yaml
> --- a/Documentation/devicetree/bindings/clock/qcom,milos-camcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,milos-camcc.yaml
[ ... ]
>  properties:
>    compatible:
> -    const: qcom,milos-camcc
> +    enum:
> +      - qcom,eliza-cambistmclkcc
> +      - qcom,eliza-camcc
> +      - qcom,milos-camcc
[ ... ]
>  required:
>    - compatible
>    - clocks
> +  - '#power-domain-cells'
>  
>  allOf:
>    - $ref: qcom,gcc.yaml#

[Severity: Medium]
Does the BIST MCLK controller actually provide power domains and resets?

Looking at the new qcom,eliza-cambistmclkcc.h header, it only defines
clocks, with no power domains or resets. However, adding #power-domain-cells
to the unconditional required list forces the BIST controller to advertise
capabilities it does not have. Additionally, the unconditional reference
to qcom,gcc.yaml# forces #reset-cells to be required for all compatibles.

Would it be better to restrict #power-domain-cells and #reset-cells to
only the main camera clock controllers using an if-then conditional block,
or move qcom,eliza-cambistmclkcc to a separate binding file?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260609-b4-eliza_mm_cc_v6-v6-0-17df09e5940c@oss.qualcomm.com?part=3