From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14D2832B102 for ; Tue, 9 Jun 2026 16:54:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781024062; cv=none; b=fIxDBPjwIaw4EGfK/3kCLrH8Qb7aW7HNTgXuCMpYEdXpuJ6CHbCJssI1tRrAWZb2QmDJtfkhegW3M5YW0LvYhNGi2Cwwp6URJ+reGevTl5Uyu73M2bF+0Bm5QsBeJhUqmV8/9Deg8nj/yBRfhYji3dsfaoVBVh4z/mNejdiOvWM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781024062; c=relaxed/simple; bh=mPlybDuQxoA/M8ZaOcxtsIu52C8vjD9xGSNduF2cetA=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=ZjLyaCT3Vrt8I9qhkgCjX8lsFf6pb9L1ntrmEIIS0a+tWd4dlz5tZpkVqREgnhXeQAfgP/gzQyhFjAEciaQWa1yjWyo39GjuA2scT7/tqH9SH2teoOsA25kJezNOOzC5cqx9QCBwUEU/mtc6AA5fD/ahKOUW+4Pns0M+DYqKvqA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WN1oWcPK; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WN1oWcPK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34CCB1F00893; Tue, 9 Jun 2026 16:54:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781024060; bh=kMoscc4gHt4/qoVPNBzm6zDulh0TR5SKsP6lRM+933k=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=WN1oWcPKZcnfuZ5niTIZ3fmSo+8FGi7DMNTkFlOkQ+zQG8+viNS8ddX/3CTOxm/fT AqeSE0YHxr5cCkjdfsgDlSa0KlnXFvwIVkCCgMtm87IX9m3u0mySjerQtdvPhYNw/Q sqgKcfg5+5cSv6FILwUs9RWQM5QJtrR1LLL7u2oCg5bp4vN0FiwRQ6hI2DSS41YNqc rV+KFDhlJW5553rfStE4WCNhjZT1YYHyPruz3TvCFVPKxhHg9Lnhokj6+LprdsqOdp UqnL60PfaBg7jNsV2aBZzu0oWu3poGctUqQECS3XrwkJZaV/Xv1eNjfYkItTVPcKjP zaKFXic7O1QuA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 RESEND 2/2] scsi: mpt3sas: add hwmon support Reply-To: sashiko-reviews@lists.linux.dev To: "Louis Sautier" Cc: linux-hwmon@vger.kernel.org In-Reply-To: <20260609164423.2829699-3-sautier.louis@gmail.com> References: <20260609164423.2829699-3-sautier.louis@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 09 Jun 2026 16:54:19 +0000 Message-Id: <20260609165420.34CCB1F00893@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: > Expose the IOC and board temperature sensors of LSI / Broadcom SAS > HBAs through hwmon. Readings come from MPI IO Unit Page 7 via the > accessor added in the preceding patch. >=20 > The same fields are exposed by Broadcom's userspace tooling > through the /dev/mpt[23]ctl ioctl path (typically root-only): > IOCTemperature and BoardTemperature in lsiutil; ROC and Controller > in storcli. With this driver, sensors(1) shows them unprivileged: >=20 > $ sensors mpt3sas-pci-0200 > mpt3sas-pci-0200 > Adapter: PCI adapter > IOC: +42.0=C2=B0C >=20 > Each channel is gated independently by its *TemperatureUnits field > through is_visible(); cards that populate only one sensor expose > only one input file, and cards that populate neither do not register > an hwmon device. >=20 > Built into mpt3sas.ko under a new CONFIG_SCSI_MPT3SAS_HWMON Kconfig > option. >=20 > Assisted-by: Claude:claude-opus-4-7 > Signed-off-by: Louis Sautier Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260609164423.2829= 699-1-sautier.louis@gmail.com?part=3D2