Re: [PATCH 1/6] tracefs: use d_splice_alias() in ->lookup() instances

[Steven Rostedt <rostedt@goodmis.org>]

On Sat,  6 Jun 2026 07:49:51 +0100
Al Viro <viro@zeniv.linux.org.uk> wrote:

> d_add() is not wrong there (inodes are freshly allocated), but
> d_splice_alias() is more idiomatic.
> 
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

This looks fine to me, but I haven't tested it. But anyway:

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

> ---
>  fs/tracefs/event_inode.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c
> index 26b6453de30e..39c7a34531e8 100644
> --- a/fs/tracefs/event_inode.c
> +++ b/fs/tracefs/event_inode.c
> @@ -389,8 +389,7 @@ static struct dentry *lookup_file(struct eventfs_inode *parent_ei,
>  	// Files have their parent's ei as their fsdata
>  	dentry->d_fsdata = get_ei(parent_ei);
>  
> -	d_add(dentry, inode);
> -	return NULL;
> +	return d_splice_alias(inode, dentry);
>  };
>  
>  /**
> @@ -420,8 +419,7 @@ static struct dentry *lookup_dir_entry(struct dentry *dentry,
>  
>  	dentry->d_fsdata = get_ei(ei);
>  
> -	d_add(dentry, inode);
> -	return NULL;
> +	return d_splice_alias(inode, dentry);
>  }
>  
>  static inline struct eventfs_inode *init_ei(struct eventfs_inode *ei, const char *name)