Re: [PATCH] IB/mlx4: Fill in the access_flags if IB_MR_REREG_ACCESS is not specified

[Jason Gunthorpe <jgg@nvidia.com>]

On Fri, Jun 05, 2026 at 08:53:35AM -0300, Jason Gunthorpe wrote:
> Sashiko noticed mlx4 was using whatever random access flags were provided
> when IB_MR_REREG_ACCESS is not used. Since IB_MR_REREG_TRANS needs
> access_flags it used the random ones which means it doesn't work sensibly
> if userspace provides only IB_MR_REREG_TRANS.
> 
> Keep track of the current access_flag of the MR and use it if the user
> does not specify one.
> 
> Also fixup a little confusion around mmr.access, it is the HW access flags
> so the convert_access() was missing. But nothing reads this by the time
> rereg_mr can happen.
> 
> Fixes: 9376932d0c26 ("IB/mlx4_ib: Add support for user MR re-registration")
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
>  drivers/infiniband/hw/mlx4/mlx4_ib.h | 1 +
>  drivers/infiniband/hw/mlx4/mr.c      | 9 +++++++--
>  2 files changed, 8 insertions(+), 2 deletions(-)
> 
> Sashiko also noticed the error unwinds are broken too, but properly fixing
> that that requires switching to use the new mr replacement rereg flow which is
> not worth doing for this ancient driver.

Applied to for-next

Jason