From: sashiko-bot@kernel.org
To: "Chun-Tse Shao" <ctshao@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v1 4/6] perf vendor events intel: Update lunarlake events from 1.22 to 1.25
Date: Tue, 09 Jun 2026 22:02:42 +0000 [thread overview]
Message-ID: <20260609220242.A7B301F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260609215046.2391903-5-ctshao@google.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Accidental deletion of the UMask field for the BR_INST_RETIRED.COND_TAKEN_FWD PMU event, making it an alias of ALL_BRANCHES.
--
commit 5c9c0d0a9a04ac6fce773f8ccf00f8df75a3f68d
Author: Chun-Tse Shao <ctshao@google.com>
perf vendor events intel: Update lunarlake events from 1.22 to 1.25
This commit updates the Lunar Lake PMU events from version 1.22 to 1.25
based on the upstream intel/perfmon repository.
> diff --git a/tools/perf/pmu-events/arch/x86/lunarlake/pipeline.json b/tools/perf/pmu-events/arch/x86/lunarlake/pipeline.json
> index d66eafccebbb6..a7467b2f291de 100644
> --- a/tools/perf/pmu-events/arch/x86/lunarlake/pipeline.json
> +++ b/tools/perf/pmu-events/arch/x86/lunarlake/pipeline.json
> @@ -190,7 +190,6 @@
> "EventName": "BR_INST_RETIRED.COND_TAKEN_FWD",
> "PublicDescription": "Counts taken forward conditional branch instructions retired. Available PDIST counters: 0,1",
> "SampleAfterValue": "400009",
> - "UMask": "0x102",
[Severity: Medium]
Was the UMask field intentionally removed here?
When UMask is missing, it is omitted from the generated event string.
The kernel PMU driver interprets omitted mask bits as zero, which makes
EventCode 0xc4 with UMask 0x00 an exact match for the ALL_BRANCHES event.
Does this cause BR_INST_RETIRED.COND_TAKEN_FWD to incorrectly count all
branches instead of only forward-taken conditional branches, potentially
corrupting Topdown metrics that rely on this branching ratio?
(This same UMask removal also appears to happen in the parallel Arrow Lake
update patch within this series).
> "Unit": "cpu_core"
> },
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260609215046.2391903-1-ctshao@google.com?part=4
next prev parent reply other threads:[~2026-06-09 22:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 21:50 [PATCH v1 0/6] perf vendor events intel: update Chun-Tse Shao
2026-06-09 21:50 ` [PATCH v1 1/6] perf vendor events intel: Update arrowlake events from 1.17 to 1.19 Chun-Tse Shao
2026-06-09 22:01 ` sashiko-bot
2026-06-09 21:50 ` [PATCH v1 2/6] perf vendor events intel: Update emeraldrapids events from 1.23 to 1.24 Chun-Tse Shao
2026-06-09 21:50 ` [PATCH v1 3/6] perf vendor events intel: Update graniterapids events from 1.18 to 1.19 Chun-Tse Shao
2026-06-09 21:50 ` [PATCH v1 4/6] perf vendor events intel: Update lunarlake events from 1.22 to 1.25 Chun-Tse Shao
2026-06-09 22:02 ` sashiko-bot [this message]
2026-06-09 22:58 ` Chun-Tse Shao
2026-06-09 21:50 ` [PATCH v1 5/6] perf vendor events intel: Update pantherlake events from 1.05 to 1.06 Chun-Tse Shao
2026-06-09 21:50 ` [PATCH v1 6/6] perf vendor events intel: Update tigerlake events from 1.18 to 1.19 Chun-Tse Shao
2026-06-09 21:56 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260609220242.A7B301F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=ctshao@google.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.