Re: [PATCH v4 1/2] dt-bindings: pinctrl: Add UltraRISC DP1000 pinctrl controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The use of `unevaluatedProperties: false` defeats the intended explicit restriction of standard pin configuration properties.
--

commit fcd21f9963cf534da789bb36bb2012a9e157e4d1
Author: Jia Wang <wangjia@ultrarisc.com>

dt-bindings: pinctrl: Add UltraRISC DP1000 pinctrl controller

This commit adds the device tree binding documentation for the pin controller
found on the UltraRISC DP1000 RISC-V SoC.

> diff --git a/Documentation/devicetree/bindings/pinctrl/ultrarisc,dp1000-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/ultrarisc,dp1000-pinctrl.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/ultrarisc,dp1000-pinctrl.yaml

[ ... ]

> +patternProperties:
> +  '.*-pins$':
> +    type: object
> +    unevaluatedProperties: false
> +    allOf:
> +      - $ref: /schemas/pinctrl/pincfg-node.yaml#
> +      - $ref: /schemas/pinctrl/pinmux-node.yaml#

[Severity: Low]
Since this node uses unevaluatedProperties: false alongside a reference to
pincfg-node.yaml#, all standard pin configuration properties will be
inherently evaluated and allowed by the schema.

Does this defeat the intended explicit restriction of standard pin
configuration properties defined below?

[ ... ]

> +      function:
> +        description: |
> +          Mux function to select for the listed pins. Supported functions
> +          depend on the selected pins and match the DP1000 hardware mux
> +          table.
> +        enum:
> +          - gpio
> +          - i2c
> +          - pwm
> +          - spi
> +          - uart
> +          - lpc
> +          - espi
> +
> +      bias-disable: true
> +      bias-high-impedance: true
> +      bias-pull-up: true
> +      bias-pull-down: true
> +
> +      drive-strength:
> +        description: Output drive strength in mA.
> +        enum: [20, 27, 33, 40]

If the goal is to restrict the node to only these explicitly listed
properties, should additionalProperties: false be used in the
patternProperties block instead?

With unevaluatedProperties: false, unsupported properties like slew-rate or
input-debounce will silently pass schema validation, rendering these explicit
boolean property declarations redundant.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260610-ultrarisc-pinctrl-v4-0-b7e9b2a8ed84@ultrarisc.com?part=1