From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Pisati <p.pisati@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests: net: fcnal-test.sh: rmmod br_netfilter at function exit
Date: Wed, 10 Jun 2026 07:56:01 -0700 [thread overview]
Message-ID: <20260610075601.1e89c1ab@kernel.org> (raw)
In-Reply-To: <20260610144618.35252-1-p.pisati@gmail.com>
On Wed, 10 Jun 2026 16:46:18 +0200 Paolo Pisati wrote:
> fcnal-test.sh loads br_netfilter to test bridge-into-VRF scenarios but
> does not remove it at function exit (the second modprobe around line 4158
> has no matching rmmod). Since tests run sequentially, any test running
> after fcnal-test.sh inherits it.
And why is that a problem? As a general rule tests shouldn't unload the
modules they loaded cause something else may have started using them.
Also you did not CC netdev@ on this.
prev parent reply other threads:[~2026-06-10 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 14:46 [PATCH] selftests: net: fcnal-test.sh: rmmod br_netfilter at function exit Paolo Pisati
2026-06-10 14:56 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260610075601.1e89c1ab@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=p.pisati@gmail.com \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.