From: Jakub Kicinski <kuba@kernel.org>
To: Marco Baffo <marco@mandelbit.com>
Cc: Antonio Quartulli <antonio@openvpn.net>,
netdev@vger.kernel.org, Sabrina Dubroca <sd@queasysnail.net>,
Ralf Lici <ralf@mandelbit.com>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net 6/6] ovpn: use monotonic clock for peer keepalive timeouts
Date: Wed, 10 Jun 2026 08:27:47 -0700 [thread overview]
Message-ID: <20260610082747.462dbf62@kernel.org> (raw)
In-Reply-To: <1932179615.53655.1781104032870@app.mailbox.org>
On Wed, 10 Jun 2026 17:07:12 +0200 (CEST) Marco Baffo wrote:
> > On Wed, 10 Jun 2026 10:44:15 +0200 (CEST) Marco Baffo wrote:
> > > ktime_get_boottime() is like ktime_get() but it does not stop when suspended.
> >
> > Worrying about keepalive timeout when system is suspended seems
> > quite silly, did some AI tool suggest this? Anyway, if you want
> > to keep this code please improve the commit message.
>
> Yes, it was suggested by Sashiko but it does not seems like a bad
> idea to me anyway, but please tell me if i'm missing something.
> Regarding the commit message i would be happy to improve it but it
> looks good to me, do you have any suggestion?
You can do it, I believe in you.
next prev parent reply other threads:[~2026-06-10 15:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 15:07 [PATCH net 0/6] pull request: fixes for ovpn 2026-06-08 Antonio Quartulli
2026-06-08 15:07 ` [PATCH net 1/6] ovpn: avoid putting unrelated P2P peer on socket release Antonio Quartulli
2026-06-08 15:07 ` [PATCH net 2/6] ovpn: fix peer refcount leak in TCP error paths Antonio Quartulli
2026-06-08 15:07 ` [PATCH net 3/6] ovpn: hold peer before scheduling keepalive work Antonio Quartulli
2026-06-08 15:07 ` [PATCH net 4/6] selftests/net: ovpn: fix getaddrinfo memory leak in ovpn_parse_remote() Antonio Quartulli
2026-06-08 15:07 ` [PATCH net 5/6] ovpn: fix use after free in unlock_ovpn() Antonio Quartulli
2026-06-08 15:07 ` [PATCH net 6/6] ovpn: use monotonic clock for peer keepalive timeouts Antonio Quartulli
2026-06-10 2:42 ` Jakub Kicinski
2026-06-10 8:44 ` Marco Baffo
2026-06-10 14:31 ` Jakub Kicinski
2026-06-10 15:07 ` Marco Baffo
2026-06-10 15:27 ` Jakub Kicinski [this message]
2026-06-10 14:33 ` [PATCH net 0/6] pull request: fixes for ovpn 2026-06-08 Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260610082747.462dbf62@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=antonio@openvpn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=marco@mandelbit.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ralf@mandelbit.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.