From: sashiko-bot@kernel.org
To: "Loic Poulain" <loic.poulain@oss.qualcomm.com>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: qcom: monaco-arduino-monza: add ina232 power sensor
Date: Wed, 10 Jun 2026 08:37:42 +0000 [thread overview]
Message-ID: <20260610083743.426C61F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260610-monza-ina232-v1-3-925b0d12771b@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message incorrectly states the shunt resistor is '2Mohm' (2 Mega-ohms) instead of '2mOhm' (2 milli-ohms). The device tree property `shunt-resistor = <2000>;` correctly sets the value to 2000 micro-ohms (2 milli-ohms), meaning this is a commit message typo.
--
commit e207629f293c0c8e295115a6f01dea08156bf3e5
Author: Loic Poulain <loic.poulain@oss.qualcomm.com>
arm64: dts: qcom: monaco-arduino-monza: add ina232 power sensor
This commit adds a TI INA232 power sensor to the Arduino Monza board's
device tree. It configures the sensor on I2C12 to measure the board supply
current using a shunt resistor.
> The Arduino Monza board has a TI INA232 current/power monitor connected
> on I2C12 at address 0x40. It is used to measure the board supply current
> through a 2Mohm shunt resistor.
[Severity: Low]
This isn't a bug, but there is a typo in the commit message. The text states
2Mohm (Mega-ohm), but the device tree property shunt-resistor = <2000>
configures the hardware for 2000 micro-ohms, which is 2mOhm (milli-ohm).
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260610-monza-ina232-v1-0-925b0d12771b@oss.qualcomm.com?part=3
next prev parent reply other threads:[~2026-06-10 8:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 8:32 [PATCH 0/3] Add INA232 power monitor support for Arduino VENTUNO Q Loic Poulain
2026-06-10 8:32 ` [PATCH 1/3] dt-bindings: hwmon: ina2xx: add ina232 compatible Loic Poulain
2026-06-10 8:41 ` sashiko-bot
2026-06-10 9:01 ` Loic Poulain
2026-06-10 8:32 ` [PATCH 2/3] hwmon: ina2xx: support ina232 Loic Poulain
2026-06-10 8:43 ` sashiko-bot
2026-06-10 9:26 ` Loic Poulain
2026-06-10 13:22 ` Guenter Roeck
2026-06-10 8:32 ` [PATCH 3/3] arm64: dts: qcom: monaco-arduino-monza: add ina232 power sensor Loic Poulain
2026-06-10 8:37 ` sashiko-bot [this message]
2026-06-10 8:52 ` Loic Poulain
2026-06-10 8:54 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260610083743.426C61F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.