From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF7FBCD8CB2 for ; Wed, 10 Jun 2026 16:22:02 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wXLem-0007Ff-Jz; Wed, 10 Jun 2026 12:19:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXLek-0007B6-PV for qemu-arm@nongnu.org; Wed, 10 Jun 2026 12:19:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXLei-0002on-IG for qemu-arm@nongnu.org; Wed, 10 Jun 2026 12:19:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781108391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oaDeH4LIoTfLU2nOk6YmmIXEAiIzcNkTHiQsFpqDOG8=; b=M0u5VQbdF4FOy0S7LtirjIqNn4+7j0zqr+cCc+aQioGR/PPyFebO+fQ8O1bimpAebt5RKl /6aNMRsHg/P1CAXoWUgpMb0LZ3x2JzFy6yh+kQgnWRJ9NRbbYc3HwLv8stgfZ1BC+RSjMS +bUAnFZfMAg5g6yU7ByUs6YP3/oFFNw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-353-U4Lw_573MNaMwg3gBuIGUg-1; Wed, 10 Jun 2026 12:19:47 -0400 X-MC-Unique: U4Lw_573MNaMwg3gBuIGUg-1 X-Mimecast-MFC-AGG-ID: U4Lw_573MNaMwg3gBuIGUg_1781108386 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-490b9318944so49859915e9.1 for ; Wed, 10 Jun 2026 09:19:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781108386; x=1781713186; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oaDeH4LIoTfLU2nOk6YmmIXEAiIzcNkTHiQsFpqDOG8=; b=CVvtuuHqWvKH14m4dLC4zz5+SgTlwRcWkPFsTipy3vW9hiQb/j0skzi0W3/rNtuZJ0 vJ8BAUk2SiMFLk1VmVR46p9MZWb7Y1xUNh75XvW0u38n0K+bJo/YUY2N3WBtWb6r4B14 guW5UJAS4eOay366i9Bi9yN+m891cjHkR9Uu5E655TiU7fv22fg8AmRLaPU+Ik2B2F8M OSLKUDjpDXEqutFVPM75GlWdCgDeqNmF4JDOw6SlHWNigAwbD6ffeuAGmplcGHtuMPoQ LFvNOpaSXicyLcmSv8WxOv0gb+XSMU7juAILYyc8A4ve/ULCZwkWVddhE9HICEs4Q9dE yLoQ== X-Forwarded-Encrypted: i=1; AFNElJ+dUV1wMJrt6vzfVl0e/BxaeO/7jD7PIF6PrdiHzbLl6TuaWSN3WDCwgUCyx/IUg2RoNaeEZR919w==@nongnu.org X-Gm-Message-State: AOJu0Yy4Smat5EPIFJICQMDucCocSx9K9iinjmsS0GqJx5m54AXmMKu3 JuVazPIuu0wfauuApxGG2IdG93Fp4Jzdxj1J7MZ53LW9ULRI4IGIILTAmXb4ncEhPxNeEr5+0Ad pLJvnwSn/T9LdyP34HyXnEazg+RGGTwEEaUKKKEuN9VVqNR7FoQLqVw== X-Gm-Gg: Acq92OG/8zWatqpE8nQN4zObUEm001OQEUjhO/SQsJ0i4HiAx2gY/6l/0AMGjTag/7e J1zo0OxsyyAhCyfIQPtPgFXo9HX6tAFdL80dw5/uA/+eWk+r+hpNGD7PZabhS9Pk+J7USb2J5NX pdqdmcJDNYXBhAolYpIq9qpK9nKsG52oCDz2xhsdJ8F+H/H2lzpU7r4If5R4u7oKR3CsleBHP4T Jnke/2+riHNTvKS5Q6YuyXZCE8/AkL2GnxIXuyOgfoG01nU2kXJLeVe5f3uPU2XXm9a6dn6z1aF N0ON4PeBY3A5Klag+mY+EAUQCgOsXaEV26SO4/w7uonTjGFuVP5SuGJooqmigYY+xtT3vRKjFTo qdZYpHEtv7CMI7ac4ymeVNAUx/O1mkZawwP6sp8BRTQvTmM9F+X6ayg== X-Received: by 2002:a05:600c:5292:b0:490:688b:f9f8 with SMTP id 5b1f17b1804b1-490d722e5ffmr110073485e9.27.1781108385844; Wed, 10 Jun 2026 09:19:45 -0700 (PDT) X-Received: by 2002:a05:600c:5292:b0:490:688b:f9f8 with SMTP id 5b1f17b1804b1-490d722e5ffmr110073045e9.27.1781108385294; Wed, 10 Jun 2026 09:19:45 -0700 (PDT) Received: from redhat.com (IGLD-80-230-85-71.inter.net.il. [80.230.85.71]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490e284bb55sm140685e9.4.2026.06.10.09.19.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 09:19:44 -0700 (PDT) Date: Wed, 10 Jun 2026 12:19:39 -0400 From: "Michael S. Tsirkin" To: Peter Maydell Cc: Peter Xu , Gavin Shan , Pavel Hrdina , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , qemu-devel@nongnu.org, qemu-arm@nongnu.org, jugraham@redhat.com, shan.gavin@gmail.com, Alex Williamson , David Hildenbrand Subject: Re: [PATCH RFCv1] virtio: Inherit max bounce buffer size from bus parent if possible Message-ID: <20260610121846-mutt-send-email-mst@kernel.org> References: <674d5e21-88fa-4a10-a83c-eb6f7ce7032f@redhat.com> <20260610080947-mutt-send-email-mst@kernel.org> <20260610082637-mutt-send-email-mst@kernel.org> <5d8cbd4b-3725-437e-88a3-e0af32164815@redhat.com> <20260610095712-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: PEJd9p96dhmCb8Hjucn62C8ouhk4R4D0zr932sR8Y1Y_1781108386 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.129.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org On Wed, Jun 10, 2026 at 05:11:40PM +0100, Peter Maydell wrote: > On Wed, 10 Jun 2026 at 16:37, Peter Xu wrote: > > > > On Wed, Jun 10, 2026 at 10:06:24AM -0400, Michael S. Tsirkin wrote: > > > This is the change that broke it I think? > > > > > > > > > commit 4a2e242bbb306ef5c16ce9e7bb2da3bd8a4eb098 > > > Author: Alex Williamson > > > Date: Mon Oct 31 09:53:03 2016 -0600 > > > > > > memory: Don't use memcpy for ram_device regions > > > > > > > > > Maybe Alex has an opinion on what to do. > > > > I can offer one idea here.. > > > > IIUC the major issue was vector ops but the mr ops might be too heavy, then > > another way to fix it is in memory API instead of using memcpy()/memmove(), > > we always use a helper (say, memmove_no_vector()) to do the split and > > properly aligned IOs as what ram_device_mem_ops does right now, this should > > only applies to ram_device. > > If the underlying memory needs to be accessed only with specific > alignment/size, as the 4a2e242bbb30 commit message suggests, then > we cannot expose it via address_space_map(), so we must have > a bounce-buffer. Right. And virtio currently isn't friendly to the bounce buffer. We can fix that but I worry about the perf impact. > The address_space_map() function says > "here's a host pointer to memory, do what you like to it", and > the caller is entitled to memcpy to/from it or otherwise > access it with any C operations, which are not guaranteed to > respect any kind of alignment or similar restrictions. > > My guess from commit 4a2e242bbb30 is that that applied an > overly broad "don't do direct access" hammer to all > vfio assigned devices, and that there needs to be some > concept of "this vfio assigned device's region is OK for > direct access" vs "this other one is not", such that if > this GH100 card's BAR guarantees it can be treated entirely > as RAM then we can have memory_region_supports_direct_access() > return true for it. > > thanks > -- PMM