From: sashiko-bot@kernel.org
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH v3 RESEND 09/10] KVM: PPC: selftests: Use u8 instead of uint8_t
Date: Wed, 10 Jun 2026 12:54:11 +0000 [thread overview]
Message-ID: <20260610125411.988A41F00898@smtp.kernel.org> (raw)
In-Reply-To: <9bbb88d55320ca04608787e05222a865c141d713.1781093720.git.ritesh.list@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Commit message contains a copy-paste typo, incorrectly stating the conversion was from uint32_t to u32.
--
commit be805dd1657bb3d5b73a2937cc30e09c502a04eb
Author: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
KVM: PPC: selftests: Use u8 instead of uint8_t
This commit updates the powerpc KVM selftests to use u8 instead of uint8_t, bringing it in line with the rest of the KVM selftests.
> commit 6ec982b5a2c7c ("KVM: selftests: Use u8 instead of uint8_t")
> made this change from uint32_t -> u32 for all other kvm selftests.
[Severity: Low]
This isn't a bug, but there appears to be a copy-paste typo in the commit message. It mentions converting from uint32_t to u32, whereas the patch title, the sed command below it, and the actual code changes are converting uint8_t to u8.
Could this part of the commit message be updated to say uint8_t to u8 so that it accurately reflects the diff?
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1781093720.git.ritesh.list@gmail.com?part=9
next prev parent reply other threads:[~2026-06-10 12:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 12:47 [PATCH v3 RESEND 00/10] KVM: selftests: add powerpc support Ritesh Harjani (IBM)
2026-06-10 12:47 ` [PATCH v3 RESEND 01/10] KVM: selftests: Move pgd_created check into virt_pgd_alloc Ritesh Harjani (IBM)
2026-06-10 12:47 ` [PATCH v3 RESEND 02/10] KVM: selftests: Add aligned guest physical page allocator Ritesh Harjani (IBM)
2026-06-10 16:18 ` Sean Christopherson
2026-06-10 12:47 ` [PATCH v3 RESEND 03/10] KVM: PPC: selftests: add support for powerpc Ritesh Harjani (IBM)
2026-06-10 12:47 ` [PATCH v3 RESEND 04/10] KVM: PPC: selftests: powerpc enable kvm_create_max_vcpus test Ritesh Harjani (IBM)
2026-06-10 17:59 ` Sean Christopherson
2026-06-10 12:47 ` [PATCH v3 RESEND 05/10] KVM: selftests: Print the vcpu_id when KVM_CREATE_VCPU ioctl fails Ritesh Harjani (IBM)
2026-06-10 12:59 ` Sean Christopherson
2026-06-10 12:47 ` [PATCH v3 RESEND 06/10] KVM: PPC: selftests: Use u64 instead of uint64_t Ritesh Harjani (IBM)
2026-06-10 12:47 ` [PATCH v3 RESEND 07/10] KVM: PPC: selftests: Use s64 instead of int64_t Ritesh Harjani (IBM)
2026-06-10 12:47 ` [PATCH v3 RESEND 08/10] KVM: PPC: selftests: Use u32 instead of uint32_t Ritesh Harjani (IBM)
2026-06-10 12:47 ` [PATCH v3 RESEND 09/10] KVM: PPC: selftests: Use u8 instead of uint8_t Ritesh Harjani (IBM)
2026-06-10 12:54 ` sashiko-bot [this message]
2026-06-10 12:47 ` [PATCH v3 RESEND 10/10] KVM: PPC: selftests: Replace u64 gpa, u64 gva|vaddr with gpa_t and gva_t Ritesh Harjani (IBM)
2026-06-10 12:51 ` [PATCH v3 RESEND 00/10] KVM: selftests: add powerpc support Sean Christopherson
2026-06-10 12:53 ` Ritesh Harjani
2026-06-10 16:19 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260610125411.988A41F00898@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.