From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69F1F4071CA for ; Wed, 10 Jun 2026 13:57:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781099840; cv=none; b=muKXleNWWweiLJLgOw+0T7KNP9b+swVaNoX2f9WhUftLz+AgVjq769X/Z6Spq4EIc5SaBIiXu/0RwhiCJbmNSkr0a559um+lfdZRvCKNUnSfaP6azMaDRddNtPxK1bqHTTPAimvw8j0r9f1RSYmq/1aBQxdsvKPwYQ6i+jDH7qw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781099840; c=relaxed/simple; bh=fzWB4kxadpLfTCMoiRfgSxMiKNXKfXfcECHeLrOiEPw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rsISTHUMWSgiz2cjBnuUWdngPGsS+yoHwYxBCShSPGGIihtyXiK527hPsDvD1yx6Gj+pfrAi3IrReGosSqvLh4s4tmCgH6RzetmbugMZJ3aAEhJalxkBG6p7i/h2hRlFILnWxeC/Nkk8zwr/CGN3RJb1biz5g4aLhteGzJi+JcY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=muv6aSst; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="muv6aSst" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99D361F00893; Wed, 10 Jun 2026 13:57:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781099839; bh=L5C3ussGByA9i7+3Y4M9b5bsaS5ARFq9X8h53aSoPEU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=muv6aSstXmClq7TOtm27CPmIBazyJZTdkK02DTfhLUNNvL1po573EcRUqLW5cdJde +7Em78k9lvzqGTfIjmnG42RoS4u+ZyES7+Npz7BeCm8fLyz69F7O8u7GQcrpIIb3wj GukK5mt7HhZ2roOaWEyNQwRp7DVAvQWgf7z4V7vUFBb8CoJBIgorrFFKQfzeVZDNVO goRU0GaCiE3Aqvq6WqrL/l0rQXVOKuUAwlvZkBZdW6jqsvP5qNosxOXSk+tnnpRd+G zjbhyGZm9SV5lylYDRr8zhLjVpodOippCKdBIPuyvIeZBmysfirxu+2u3l6qsSRLr1 mG7Zrqcaw6x6w== Date: Wed, 10 Jun 2026 14:57:15 +0100 From: Simon Horman To: Przemyslaw Korba Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, konstantin.ilichev@intel.com, aleksander.lobakin@intel.com Subject: Re: [PATCH iwl-net v3] ice: fall back to SBQ when LL PHY timer interface times out Message-ID: <20260610135715.GL3920875@horms.kernel.org> References: <20260605120734.1462847-1-przemyslaw.korba@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260605120734.1462847-1-przemyslaw.korba@intel.com> On Fri, Jun 05, 2026 at 02:06:26PM +0200, Przemyslaw Korba wrote: > The low-latency (LL) PHY timer interface relies on a tight, atomic poll > of the PF_SB_ATQBAL register with a 2ms timeout. After an NVM update / > EMPR, FW may need significantly longer than 2ms to start responding to > ATQBAL commands. The first PHY adjust or incval write issued by > ice_ptp_rebuild_owner() fails with -ETIMEDOUT. > > Fix this by falling back to the existing SBQ-based PHY register write > path when LL times out. This makes sure PTP is initialized when FW takes > longer than expected to come back online. > > Steps to reproduce: > ./nvmupdate64e -if devlink -f > Update E810 card with nvmupdate64e, and observe dmesg errors: > Failed to write PHC increment value, status -110 > PTP reset failed, error: -110 (-ETIMEDOUT) > > Fixes: ef9a64c07294 ("ice: implement low latency PHY timer updates") > Signed-off-by: Przemyslaw Korba > --- > v3: > * actually add TIMEDOUT check in ice_prep_phy_adj_e810 (did do it) > v2: > * add TIMEDOUT check in ice_prep_phy_adj_e810 (did not do it) > https://lore.kernel.org/intel-wired-lan/20260603114904.1297713-1-przemyslaw.korba@intel.com/ > v1: > https://lore.kernel.org/intel-wired-lan/20260511095830.1095984-1-przemyslaw.korba@intel.com/ > --- > drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 38 +++++++++++---------- > 1 file changed, 20 insertions(+), 18 deletions(-) Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21AD6CD98C6 for ; Wed, 10 Jun 2026 13:57:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id C1680813CE; Wed, 10 Jun 2026 13:57:24 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id veUT9Rd0Tj50; Wed, 10 Jun 2026 13:57:23 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org E191C813BD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1781099842; bh=L5C3ussGByA9i7+3Y4M9b5bsaS5ARFq9X8h53aSoPEU=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=xq/vhjFHI/JE/3Ipcra5E1C+xQZxcPXvtHRrd69ErwlvcpWB/yX9oImhGNB5CTRC8 ZVPfeK9DNZAjkBoETL0svexOZszxcH5E4vQTeqjRJhRRNlIvijPMVfZkQp6ppm7IQY 6LFKRC+0x6ucxuYQAoTrMhR0+Ep5IMiPDmm6t7M4tWLTEP8FIiN9TCGbhl7Q2Vlfx0 DpmQVfGx37bCLorh9NJLA0aByRqQjM1OaoB86nDCr/22OarURgn22lmScmJxD9xEex hFRGZYghhuaa1jaY1D947KUCXISqu04xIsi/veDEw9N/59UUkLKbEt8hlaUvzS69CV r2vzQhbc03wPw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id E191C813BD; Wed, 10 Jun 2026 13:57:22 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id 55B3F196 for ; Wed, 10 Jun 2026 13:57:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 3B69A40A47 for ; Wed, 10 Jun 2026 13:57:22 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 8wNtJOkVkdVS for ; Wed, 10 Jun 2026 13:57:21 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 705A240A3A DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 705A240A3A Received: from tor.source.kernel.org (tor.source.kernel.org [IPv6:2600:3c04:e001:324:0:1991:8:25]) by smtp4.osuosl.org (Postfix) with ESMTPS id 705A240A3A for ; Wed, 10 Jun 2026 13:57:21 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 57EF0600AB; Wed, 10 Jun 2026 13:57:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99D361F00893; Wed, 10 Jun 2026 13:57:17 +0000 (UTC) Date: Wed, 10 Jun 2026 14:57:15 +0100 From: Simon Horman To: Przemyslaw Korba Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, konstantin.ilichev@intel.com, aleksander.lobakin@intel.com Message-ID: <20260610135715.GL3920875@horms.kernel.org> References: <20260605120734.1462847-1-przemyslaw.korba@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260605120734.1462847-1-przemyslaw.korba@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781099839; bh=L5C3ussGByA9i7+3Y4M9b5bsaS5ARFq9X8h53aSoPEU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=muv6aSstXmClq7TOtm27CPmIBazyJZTdkK02DTfhLUNNvL1po573EcRUqLW5cdJde +7Em78k9lvzqGTfIjmnG42RoS4u+ZyES7+Npz7BeCm8fLyz69F7O8u7GQcrpIIb3wj GukK5mt7HhZ2roOaWEyNQwRp7DVAvQWgf7z4V7vUFBb8CoJBIgorrFFKQfzeVZDNVO goRU0GaCiE3Aqvq6WqrL/l0rQXVOKuUAwlvZkBZdW6jqsvP5qNosxOXSk+tnnpRd+G zjbhyGZm9SV5lylYDRr8zhLjVpodOippCKdBIPuyvIeZBmysfirxu+2u3l6qsSRLr1 mG7Zrqcaw6x6w== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=muv6aSst Subject: Re: [Intel-wired-lan] [PATCH iwl-net v3] ice: fall back to SBQ when LL PHY timer interface times out X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, Jun 05, 2026 at 02:06:26PM +0200, Przemyslaw Korba wrote: > The low-latency (LL) PHY timer interface relies on a tight, atomic poll > of the PF_SB_ATQBAL register with a 2ms timeout. After an NVM update / > EMPR, FW may need significantly longer than 2ms to start responding to > ATQBAL commands. The first PHY adjust or incval write issued by > ice_ptp_rebuild_owner() fails with -ETIMEDOUT. > > Fix this by falling back to the existing SBQ-based PHY register write > path when LL times out. This makes sure PTP is initialized when FW takes > longer than expected to come back online. > > Steps to reproduce: > ./nvmupdate64e -if devlink -f > Update E810 card with nvmupdate64e, and observe dmesg errors: > Failed to write PHC increment value, status -110 > PTP reset failed, error: -110 (-ETIMEDOUT) > > Fixes: ef9a64c07294 ("ice: implement low latency PHY timer updates") > Signed-off-by: Przemyslaw Korba > --- > v3: > * actually add TIMEDOUT check in ice_prep_phy_adj_e810 (did do it) > v2: > * add TIMEDOUT check in ice_prep_phy_adj_e810 (did not do it) > https://lore.kernel.org/intel-wired-lan/20260603114904.1297713-1-przemyslaw.korba@intel.com/ > v1: > https://lore.kernel.org/intel-wired-lan/20260511095830.1095984-1-przemyslaw.korba@intel.com/ > --- > drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 38 +++++++++++---------- > 1 file changed, 20 insertions(+), 18 deletions(-) Reviewed-by: Simon Horman