Re: [PATCH net-next 1/2] tls: remove tls_toe and the related driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete removal of the `tls_toe` feature leaves behind dangling feature flags (`NETIF_F_HW_TLS_RECORD`) and upper layer driver references (`CXGB4_ULD_TLS`), leading to dead code and false feature advertisement to userspace.
--

commit 9a055c5cc4ab72cb186cfa373957ed0d0080f2d2
Author: Sabrina Dubroca <sd@queasysnail.net>

tls: remove tls_toe and the related driver

This patch removes the unmaintained tls_toe feature and its single user,
the chelsio chtls driver. It removes the related documentation, Kconfig
options, and source files.

> diff --git a/net/tls/Kconfig b/net/tls/Kconfig
> index a25bf57f26738..4f4d5973a28f4 100644
> --- a/net/tls/Kconfig
> +++ b/net/tls/Kconfig
> @@ -27,13 +27,3 @@ config TLS_DEVICE
>  	Enable kernel support for HW offload of the TLS protocol.
>  
>  	If unsure, say N.
> -
> -config TLS_TOE
> -	bool "Transport Layer Security TCP stack bypass"
> -	depends on TLS
> -	default n
> -	help
> -	Enable kernel support for legacy HW offload of the TLS protocol,
> -	which is incompatible with the Linux networking stack semantics.
> -
> -	If unsure, say N.

[Severity: Low]
Since this removes the tls_toe feature and the chtls driver, should we also
clean up the remaining references to the hardware TLS record offload?

For example, the feature bit NETIF_F_HW_TLS_RECORD_BIT is still present in
include/linux/netdev_features.h, and its corresponding ethtool string 
"tls-hw-record" remains in net/ethtool/common.c.

Also, the cxgb4 driver still unconditionally adds NETIF_F_HW_TLS_RECORD to
netdev->hw_features in cxgb4_main.c:init_one(), which could lead to devices
falsely advertising this removed capability to userspace.

Additionally, CXGB4_ULD_TLS is left behind in enum cxgb4_uld
(drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h), and there is dead code
processing it in drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
inside sge_qinfo_show() and in drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.h
inside cudbg_uld_rxq_to_qtype().

Could these leftovers be removed as well to complete the cleanup?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1781013810.git.sd@queasysnail.net?part=1