Re: [PATCH v2] drm/tests: Move test EDID data to separate .c file

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added drm_kunit_edid.c file is built as a loadable module but lacks a MODULE_LICENSE() declaration.
--

commit 6969a389dfc7ebf286991ec9afae031d0abd753f
Author: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>

drm/tests: Move test EDID data to separate .c file

This commit moves the test EDID array definitions from a header file into a newly created drm_kunit_edid.c file. The arrays are exported so they can be shared among different KUnit tests without duplicating data across multiple users.

Link: https://lore.kernel.org/r/04ff70850213ae0f75486b1a27a7edb6fb4e71c3@intel.com/

> diff --git a/drivers/gpu/drm/tests/Makefile b/drivers/gpu/drm/tests/Makefile
> index 3b83e6616fb25..e7193b49cf91f 100644
> --- a/drivers/gpu/drm/tests/Makefile
> +++ b/drivers/gpu/drm/tests/Makefile
> @@ -24,6 +24,7 @@ obj-$(CONFIG_DRM_KUNIT_TEST) += \
>  	drm_probe_helper_test.o \
>  	drm_rect_test.o \
>  	drm_sysfb_modeset_test.o \
> -	drm_fixp_test.o
> +	drm_fixp_test.o \
> +	drm_kunit_edid.o

[ ... ]

> diff --git a/drivers/gpu/drm/tests/drm_kunit_edid.c b/drivers/gpu/drm/tests/drm_kunit_edid.c
> new file mode 100644
> index 0000000000000..0976372860627
> --- /dev/null
> +++ b/drivers/gpu/drm/tests/drm_kunit_edid.c
> @@ -0,0 +1,991 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +#include <linux/export.h>
> +
> +#include "drm_kunit_edid.h"

[Severity: Low]
Because drm_kunit_edid.o is added directly to obj-$(CONFIG_DRM_KUNIT_TEST) in
the Makefile, it will be built as a standalone module when that config is set
to 'm'. Does this new file need to include <linux/module.h> and provide a
MODULE_LICENSE() declaration to prevent modpost warnings and a tainted kernel
when loaded?

> +
> +/*
> + * edid-decode (hex):
> + *
> + * 00 ff ff ff ff ff ff 00 31 d8 2a 00 00 00 00 00

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260610-test-edid-array-definition-fix-v2-1-9de4605c4869@collabora.com?part=1