Re: [LTP] fw_load: Modernize ltp_fw_load kernel module

[linuxtestproject.agent@gmail.com]

Hi Andrea,

On Wed Jun 10 15:50:44 2026 +0200, Andrea Cervesato wrote:
> fw_load: Modernize ltp_fw_load kernel module

--- [PATCH 2/3] ---

> -MAKE_TARGETS	:= ltp_fw_load.ko
> +MAKE_TARGETS	:= fw_load01 fw_load02 ltp_fw_load.ko

fw_load02.c is not created until PATCH 3/3, so building the tree at
this commit will fail with a missing-source error. Each patch must
compile on its own without intermediate breakage.

Move fw_load02 out of MAKE_TARGETS here and add it in PATCH 3/3
together with the source file.

> +/*\
> + * [Algorithm]
> + *
> + * - Create firmware files in the standard firmware search
> + *   directories:
> ...
> + * - Load the helper module with ``fw_size`` matching the blob size

The algorithm lists "Create firmware files" before "Load the helper
module", but the code in setup() loads the module first (line 111)
and creates the firmware files after (lines 114-125). Since
request_firmware() is only triggered later via sysfs the order does
not matter for correctness, but the algorithm block should match the
actual code order.

Verdict: Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp