From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9ABF5CD8CB9 for ; Wed, 10 Jun 2026 18:24:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 40E1610EB2E; Wed, 10 Jun 2026 18:24:02 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="PivTynVQ"; dkim-atps=neutral Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012059.outbound.protection.outlook.com [40.107.209.59]) by gabe.freedesktop.org (Postfix) with ESMTPS id E2E1F10EB2E for ; Wed, 10 Jun 2026 18:24:00 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=r3UkV0s5kCNHbQxkPYfYo2UHUGy2KSVkcVdGt6JkADB9gkgn5vTIGQPEZXsag7RXpwenwwIlSe3fMcqrqQGS+LJNgk1Krexx29/LeUUReyBa5BK8dXmoyqSPQjLHfhz7gVFa08clHz8pRN8l6GYoHTCfk1S4h2tBRox7wjTKt6yI7PWctL1pKwAgw1l73DPZhvbTz/YaIMvWRDXLFoLq2Lq+KZox6gSwSc9bgLSI/Bkbpfg0ROA6ldQcl3SPg+IUudADXaTWnhr+KMZXOpAK4PfdBqL6mSkSnUfvHLyrxyIWwxCZRDdMWXUTkbAbiP2WMxiFk/UwWYZvAnKftmzSwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CYxM0wI/w0ymGCOp1naNJ/hrXFlHnmZovEb5UdCL6XA=; b=CLr9n2zLMhLoEO9tVh3LSPJ5A8nBnlZAi46r7TiBlsFv0BRk7cJK0nNTOb8BhbrtwHcfDK7gEho43zUlR9ixM9+TmZrQboNSeWpJ1sV0cUdO+aqyvagsGkhCpGw02q3jS2ienWHDy8kpULIR+ciIsn0YXQaubEpJSeZyRpkOWYVK1EHSwIHiMW9KIf4Jvg7icfsPupyApmbmhCKHBME5sMXRnyLL20/D3Ub0MgVtEWtIDUfBcNvf6uyHd87HDWdOwUnZfffJUuNCOJvSfVM4K0Hmgn2V1H7BCJYosXwlBDH7oHusEEJNdr1EZsBdiZ0cZP1X81LHY5r5FVMszWuDYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.freedesktop.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CYxM0wI/w0ymGCOp1naNJ/hrXFlHnmZovEb5UdCL6XA=; b=PivTynVQMzxFjS+zpB09MnQDEEgCiXfmITs5bI/BFOIzSc7Lfin3zruQcA1f/Rwez0+BBjVARPHVYM2UPj/Z/U/KpuVOoIDbzUurC7Oryk73/conZO66OnyQjEsAk7aLk8trkmfNXgC1miTJ4ruuDEqj8Z6T6vCEOSiCjCNJYBM= Received: from CH3P221CA0013.NAMP221.PROD.OUTLOOK.COM (2603:10b6:610:1e7::21) by DM4PR12MB7672.namprd12.prod.outlook.com (2603:10b6:8:103::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.13; Wed, 10 Jun 2026 18:23:49 +0000 Received: from CH1PEPF0000A348.namprd04.prod.outlook.com (2603:10b6:610:1e7:cafe::1f) by CH3P221CA0013.outlook.office365.com (2603:10b6:610:1e7::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.113.13 via Frontend Transport; Wed, 10 Jun 2026 18:23:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH1PEPF0000A348.mail.protection.outlook.com (10.167.244.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.113.7 via Frontend Transport; Wed, 10 Jun 2026 18:23:49 +0000 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Wed, 10 Jun 2026 13:23:45 -0500 Received: from rtg-MAPLE.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Wed, 10 Jun 2026 13:23:43 -0500 From: Priya Hosur To: , , , , , CC: , , Subject: [PATCH v2 3/4] drm/amd/pm: smu_v14_0_0: add SMU_DCEFCLK support in DPM frequency queries Date: Wed, 10 Jun 2026 23:53:32 +0530 Message-ID: <20260610182333.3922-4-Priya.Hosur@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260610182333.3922-1-Priya.Hosur@amd.com> References: <20260610182333.3922-1-Priya.Hosur@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A348:EE_|DM4PR12MB7672:EE_ X-MS-Office365-Filtering-Correlation-Id: 2053269f-fb78-4711-f1b8-08dec71d6b0e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700016|376014|23010399003|82310400026|1800799024|56012099006|11063799006|6133799003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: ncfXG+hd/UV7sAR3H8+L/UiJr6ovyQbz7+FGByrkQ3TDYJJ6Ltk8jF0yG6m7cE9YBq0do3mhCid3u3t9mjQTppVGio5jEfGeJUBPDpSw5XFroQEg0aEhT84VEQkuiCvxxzr0YQ7XPRwHtMJ0sd2Em8Ai3a6B0EJblxtMphRUrjP7lecKY/oJzIzTyr93R8KPdi8EPQ9rMIMqfcr+0JQ8G5TniZPLchncUkKHDKBJBeAEIfLEXmDP9Ov3QBRtlFxGK/hskIm1wW/TZYe8yws5nNQJwHfyxMhtSUEtvf01R317CBS+ESUjYS6aBy8cXYhA0WBRVauUr7VRK0yRg1mfQtGahXO4/nKhN9Fn0SaxLVDXLiISX9Sg4MCV53Lwad1faerqb4x5MKddwNJraiCylfH9pTh0IZvjc27fQxwdLWiv7nqy4DHnxpthq83LGNTtiRGs6c1WbJ1+2OG63xKGOgCLZ0B/YXX38IA0pHCU0QN3Mmzi/2JgAXRonk9PftlemB/3ZRdiJ2MlGTfV/uCnlotFHGg8p+gZT7QznzAd74P5H55RYIHJBw6R1a6v9OGSqdB5jYVwn/M0xcmXk+V/YiUVe7bhxRYwqUzztM+/zWiWUYa5ty4FKszngBoMkW4f2rutlGcZ2gttT5DZUuAKM6gDWfdeDEQ3ZPLpnupPxTldSJ7jD1DdNnFZcmJLXFeVjKuexi8P770Wkb+czwT/7usP9rvc0OMs2gqtVBNBIaI= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(36860700016)(376014)(23010399003)(82310400026)(1800799024)(56012099006)(11063799006)(6133799003)(18002099003)(22082099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: wfUZUXHYe5KmoYa8+1sbSWC4fGXQIGF5dZIlyimKrG1SQdXXJFfvdc4rOIHau+B5Kcq3iTB/f8gtlbpndAoIkdQcthp9Tz9Qb+U4nARRKEmnOhpSORpwgAFIzpGHP1Cwd1TtxYof14lJOSivLwiStlFbrNSI8rC6Wuqwr0iDM53nmeff3uVHaRTopMB1lwsfTmdBzJlXvijMhldNE0sP/Xbcwpp9Wr1fBj3dFAHhwWnL7BoBpd5V1lNEtlAjG5V9LGckGOUtnCqcr6AJ5U/rqTuuzHoXQqEfs/s9FPTXL+kR090RjzN1wJ8jHMTMp+EPXt4V3+HvY2a6jo6rWf4b1PHHMIETIag48W51RmRXQF0A9plfd5H3i0Fw8xjCc4Scrl589w/HCN0fz9WIO31ykihIdj6cVVWe6ZqfxRgU12MKRkMYZ+jPDsNnzBReAVyI X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2026 18:23:49.7053 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2053269f-fb78-4711-f1b8-08dec71d6b0e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A348.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7672 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Add SMU_DCEFCLK case to smu_v14_0_1_get_dpm_freq_by_index and smu_v14_0_0_get_dpm_freq_by_index using DcfClocks[] with NumDcfClkLevelsEnabled bounds check. Add matching case in both get_dpm_level_count functions. Add SMU_DCEFCLK case in emit_clk_levels to list DCEF DPM levels. No * marker is emitted since SmuMetrics_t has no DcfclkFrequency field (same firmware limitation as Phoenix). Without this, pp_dpm_dcefclk reports N/A on Strix Halo. Signed-off-by: Priya Hosur --- .../drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c | 28 +++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c index 79e0e2fca602..1be8d1a8da19 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c @@ -682,6 +682,11 @@ static int smu_v14_0_1_get_dpm_freq_by_index(struct smu_context *smu, return -EINVAL; *freq = clk_table->FclkClocks_Freq[dpm_level]; break; + case SMU_DCEFCLK: + if (dpm_level >= clk_table->NumDcfClkLevelsEnabled) + return -EINVAL; + *freq = clk_table->DcfClocks[dpm_level]; + break; default: return -EINVAL; } @@ -726,6 +731,11 @@ static int smu_v14_0_0_get_dpm_freq_by_index(struct smu_context *smu, return -EINVAL; *freq = clk_table->FclkClocks_Freq[dpm_level]; break; + case SMU_DCEFCLK: + if (dpm_level >= clk_table->NumDcfClkLevelsEnabled) + return -EINVAL; + *freq = clk_table->DcfClocks[dpm_level]; + break; default: return -EINVAL; } @@ -1089,6 +1099,9 @@ static int smu_v14_0_1_get_dpm_level_count(struct smu_context *smu, case SMU_FCLK: *count = clk_table->NumFclkLevelsEnabled; break; + case SMU_DCEFCLK: + *count = clk_table->NumDcfClkLevelsEnabled; + break; default: break; } @@ -1118,6 +1131,9 @@ static int smu_v14_0_0_get_dpm_level_count(struct smu_context *smu, case SMU_FCLK: *count = clk_table->NumFclkLevelsEnabled; break; + case SMU_DCEFCLK: + *count = clk_table->NumDcfClkLevelsEnabled; + break; default: break; } @@ -1184,6 +1200,18 @@ static int smu_v14_0_0_emit_clk_levels(struct smu_context *smu, cur_value == value ? "*" : ""); } break; + case SMU_DCEFCLK: + ret = smu_v14_0_common_get_dpm_level_count(smu, clk_type, &count); + if (ret) + return ret; + + for (i = 0; i < count; i++) { + ret = smu_v14_0_common_get_dpm_freq_by_index(smu, clk_type, i, &value); + if (ret) + return ret; + size += sysfs_emit_at(buf, size, "%d: %uMhz\n", i, value); + } + break; case SMU_GFXCLK: case SMU_SCLK: ret = smu_v14_0_0_get_current_clk_freq(smu, clk_type, &cur_value); -- 2.43.0