All of lore.kernel.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: SeongJae Park <sj@kernel.org>
Cc: "# 6 . 14 . x" <stable@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	damon@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [RFC PATCH v4 0/6] samples/damon: handle damon_{start,stop}() failures
Date: Wed, 10 Jun 2026 17:06:45 -0700	[thread overview]
Message-ID: <20260611000646.68793-1-sj@kernel.org> (raw)
In-Reply-To: <20260610135546.64943-1-sj@kernel.org>

On Wed, 10 Jun 2026 06:55:38 -0700 SeongJae Park <sj@kernel.org> wrote:

> All DAMON sample modules are not correctly handling failures from
> damon_start().  Among those, mtier also has an additional problem for
> handling of damon_stop() failures.  wsse and prcl also have a problem in
> their damon_call() failure handling.  As a result, memory leaks, next
> DAMON operation disruptions, and use-after-free can happen.  Fix those.
> 
> Note that only the damon_start() failure caused issues can reliably be
> reproduced.  Reproducing those issues require the admin permission,
> though.

Finally this series passed the Sashiko review [1].  I initially aimed to drop
RFC of this patch series as soon as passing Sashiko review.  But, the size of
this series has been 3x compared to the initial one, because Sashiko was
finding more pre-existing issues for every review round, and I added fixes for
those in this series.

Due to the size and short remaining time until the next merge window, I'm now
hesitatng.i  The last three fixes might not deserve to rush, because they are
relatively difficult to intentionally be reproduced.  The first three fixes
might be better to be merged as soon as possible, since the issues can reliably
and repetitively triggered.  But, still those are sample modules, and the bug
was introduced with 6.14, which was released in Mar 2025.

So I think it is better to give Andrew and Linus more time for the merge
window.  I will hold dropping RFC tag of this series until it seems Andrew
finished the next merge window works.  Let me know if any of you have different
opinions, though!

[1] https://sashiko.dev/#/patchset/20260610135546.64943-1-sj%40kernel.org


Thanks,
SJ

[...]

      parent reply	other threads:[~2026-06-11  0:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-10 13:55 [RFC PATCH v4 0/6] samples/damon: handle damon_{start,stop}() failures SeongJae Park
2026-06-10 13:55 ` [RFC PATCH v4 1/6] samples/damon/wsse: handle damon_start() failure SeongJae Park
2026-06-10 13:55 ` [RFC PATCH v4 2/6] samples/damon/prcl: " SeongJae Park
2026-06-10 13:55 ` [RFC PATCH v4 3/6] samples/damon/mtier: " SeongJae Park
2026-06-10 13:55 ` [RFC PATCH v4 4/6] samples/damon/mtier: handle damon_stop() failure SeongJae Park
2026-06-10 13:55 ` [RFC PATCH v4 5/6] samples/damon/wsse: stop and free damon ctx when damon_call() fails SeongJae Park
2026-06-10 13:55 ` [RFC PATCH v4 6/6] samples/damon/prcl: " SeongJae Park
2026-06-11  0:06 ` SeongJae Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260611000646.68793-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.