Re: [PATCH v7 2/7] powerpc/bpf: Move out dummy_tramp_addr after Long branch stub

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Build failure in 32-bit PowerPC BPF JIT due to missing argument in `bpf_jit_emit_exit_insn` call.
--

commit c1ec67bf99079bbd4869481f8942e54d5968cdb6
Author: Abhishek Dubey <adubey@linux.ibm.com>
Subject: powerpc/bpf: Move out dummy_tramp_addr after Long branch stub

This commit moves the dummy_tramp_addr field to the bottom of the long
branch stub to improve uninterrupted disassembly. It updates the offset
calculations and aligns the field to an 8-byte boundary.

> diff --git a/arch/powerpc/net/bpf_jit.h b/arch/powerpc/net/bpf_jit.h
> index 71e6e7d010573..6632de9871dd3 100644
> --- a/arch/powerpc/net/bpf_jit.h
> +++ b/arch/powerpc/net/bpf_jit.h
[ ... ]
> @@ -217,7 +217,8 @@ void bpf_jit_build_prologue(u32 *image, struct codegen_context *ctx);
>  void bpf_jit_build_epilogue(u32 *image, u32 *fimage, struct codegen_context *ctx);
>  void bpf_jit_build_fentry_stubs(u32 *image, u32 *fimage, struct codegen_context *ctx);
>  void bpf_jit_realloc_regs(struct codegen_context *ctx);
> -int bpf_jit_emit_exit_insn(u32 *image, struct codegen_context *ctx, int tmp_reg, long exit_addr);
> +int bpf_jit_emit_exit_insn(u32 *image, u32 *fimage, struct codegen_context *ctx, int tmp_reg,
> +										long exit_addr);

[Severity: Low]
Does this prototype change break the build for 32-bit configurations?

It looks like the caller in arch/powerpc/net/bpf_jit_comp32.c was not updated
to pass the new fimage argument, which will result in a compilation failure
with 'too few arguments to function' when CONFIG_PPC32 is enabled:

arch/powerpc/net/bpf_jit_comp32.c:bpf_jit_build_body() {
    ...
                ret = bpf_jit_emit_exit_insn(image, ctx, _R0, exit_addr);
    ...
}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260611153826.31187-1-adubey@linux.ibm.com?part=2