All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: cros-kernel-buildreports@googlegroups.com
Cc: oe-kbuild-all@lists.linux.dev
Subject: [android-common:android16-6.12 2/2] drivers/virt/halla/hvm_vm.c:435: warning: Function parameter or struct member 'hvm' not described in 'hvm_destroy_vm'
Date: Thu, 11 Jun 2026 16:32:49 +0800	[thread overview]
Message-ID: <202606111634.GKJbKAtr-lkp@intel.com> (raw)

tree:   https://android.googlesource.com/kernel/common android16-6.12
head:   17584f778119ed93d9ae85feb43561e05f5254b0
commit: e17566975f96abbb6d6b84aa4784161e51264095 [2/2] ANDROID: virt: halla: Tie struct hvm lifetime to vcpu fds with a kref
config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20260611/202606111634.GKJbKAtr-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project f99ad325b987c3f2fb2d298f1569377c989b06d3)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260611/202606111634.GKJbKAtr-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202606111634.GKJbKAtr-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/virt/halla/hvm_vm.c:435: warning: Function parameter or struct member 'hvm' not described in 'hvm_destroy_vm'

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for INTEL_MEI_ME
   Depends on [n]: X86 && PCI [=y]
   Selected by [m]:
   - INTEL_MEI_HDCP [=m] && (DRM_I915 [=n] || DRM_XE [=m])
   - INTEL_MEI_PXP [=m] && (DRM_I915 [=n] || DRM_XE [=m])


vim +435 drivers/virt/halla/hvm_vm.c

e17566975f96ab Junho Choi  2026-06-10  423  
e17566975f96ab Junho Choi  2026-06-10  424  /**
e17566975f96ab Junho Choi  2026-06-10  425   * hvm_destroy_vm() - VM fd release path.
e17566975f96ab Junho Choi  2026-06-10  426   *
e17566975f96ab Junho Choi  2026-06-10  427   * Tears down everything that owns guest memory or hypervisor S2
e17566975f96ab Junho Choi  2026-06-10  428   * resources, detaches the live vcpus from the hypervisor, removes
e17566975f96ab Junho Choi  2026-06-10  429   * the VM from hvm_list, then drops the VM fd's kref.  The struct
e17566975f96ab Junho Choi  2026-06-10  430   * hvm itself stays alive as long as any vcpu fd still holds a
e17566975f96ab Junho Choi  2026-06-10  431   * reference, so a vcpu ioctl racing with VM fd close stays on
e17566975f96ab Junho Choi  2026-06-10  432   * valid memory until the vcpu fd is also closed.
e17566975f96ab Junho Choi  2026-06-10  433   */
9007a992df6c7f Kim Mankyum 2025-08-27  434  static void hvm_destroy_vm(struct hvm *hvm)
9007a992df6c7f Kim Mankyum 2025-08-27 @435  {
e17566975f96ab Junho Choi  2026-06-10  436  	unsigned long ret;
9007a992df6c7f Kim Mankyum 2025-08-27  437  
9007a992df6c7f Kim Mankyum 2025-08-27  438  	mutex_lock(&hvm->lock);
9007a992df6c7f Kim Mankyum 2025-08-27  439  
f2801c7c470f11 Kim Mankyum 2026-04-14  440  	hvm_pre_destroy_vm(hvm);
9007a992df6c7f Kim Mankyum 2025-08-27  441  
9007a992df6c7f Kim Mankyum 2025-08-27  442  	hvm_vm_irqfd_release(hvm);
9007a992df6c7f Kim Mankyum 2025-08-27  443  
9007a992df6c7f Kim Mankyum 2025-08-27  444  	ret = hvm_reclaim_guest_memory(hvm);
9007a992df6c7f Kim Mankyum 2025-08-27  445  	hvm_reclaim_guest_stage2_pgtable(hvm);
9007a992df6c7f Kim Mankyum 2025-08-27  446  
9007a992df6c7f Kim Mankyum 2025-08-27  447  	hvm_destroy_vcpus(hvm);
9007a992df6c7f Kim Mankyum 2025-08-27  448  
9007a992df6c7f Kim Mankyum 2025-08-27  449  	mutex_lock(&hvm_list_lock);
9007a992df6c7f Kim Mankyum 2025-08-27  450  	list_del(&hvm->vm_list);
9007a992df6c7f Kim Mankyum 2025-08-27  451  	mutex_unlock(&hvm_list_lock);
9007a992df6c7f Kim Mankyum 2025-08-27  452  
9007a992df6c7f Kim Mankyum 2025-08-27  453  	mutex_unlock(&hvm->lock);
9007a992df6c7f Kim Mankyum 2025-08-27  454  
9007a992df6c7f Kim Mankyum 2025-08-27  455  	/**
9007a992df6c7f Kim Mankyum 2025-08-27  456  	 * Have to leave the page pinned as we don't know whether its
9007a992df6c7f Kim Mankyum 2025-08-27  457  	 * save to access
9007a992df6c7f Kim Mankyum 2025-08-27  458  	 */
9007a992df6c7f Kim Mankyum 2025-08-27  459  	if (!ret) {
9007a992df6c7f Kim Mankyum 2025-08-27  460  		/**
9007a992df6c7f Kim Mankyum 2025-08-27  461  		 * No need to lock here becauese it's single-threaded
9007a992df6c7f Kim Mankyum 2025-08-27  462  		 * execution
9007a992df6c7f Kim Mankyum 2025-08-27  463  		 */
9007a992df6c7f Kim Mankyum 2025-08-27  464  		hvm_destroy_all_ppage(hvm);
9007a992df6c7f Kim Mankyum 2025-08-27  465  	}
9007a992df6c7f Kim Mankyum 2025-08-27  466  
e17566975f96ab Junho Choi  2026-06-10  467  	hvm_vm_put(hvm);
9007a992df6c7f Kim Mankyum 2025-08-27  468  }
9007a992df6c7f Kim Mankyum 2025-08-27  469  

:::::: The code at line 435 was first introduced by commit
:::::: 9007a992df6c7fbc50cbcc21613b3a5c3c019ab6 ANDROID: drivers: virt: Initialization halla module

:::::: TO: Kim Mankyum <mankyum.kim@samsung.com>
:::::: CC: Greg Kroah-Hartman <gregkh@google.com>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-06-11  8:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202606111634.GKJbKAtr-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=cros-kernel-buildreports@googlegroups.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.