From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6E38CD98C7 for ; Thu, 11 Jun 2026 16:41:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2zKWf+Qg/EjR7kCvIf7tfATIgsY3M5Q03mAbvlDh99Y=; b=4MDiFvkf1+rVmA 3qodXLNRWEtydILhX+M+JEVgp5nDpcBAp24MQB/vK4x7sgFdqYajEz6Zvs+vKxlJwOjZkbW0DhKFO UKfse0pGxEhBOznZvmO2gaL9mT/HwMH74uWASC4rFnMkq5srNRPjnerlzhFA3+NGONnWrzGKzBS7d aNrIVgVL/BLmHURopEoY7B2aoObQPwKDsjeDmANC956X2/OmFv6mPHeOvJnEfFY0D6k19KD7bsk7+ sPNewfZwz8OfXSDJJPUDI1zR/+wQosyQ73lOjtItG+yhS74OX/lb6KyyupASshHYvO/FQnXpbEFtX YoWpDoKrDS2/if6Ey9ng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wXiSj-00000009mEO-3RVO; Thu, 11 Jun 2026 16:41:01 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wXiSi-00000009mEF-3nOM; Thu, 11 Jun 2026 16:41:00 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 9401E41A2A; Thu, 11 Jun 2026 16:41:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E1751F00893; Thu, 11 Jun 2026 16:40:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781196060; bh=ROq1lVBMd1TqONzV7EX6xzWPckJNHZDfKK4kRsAGgBI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=LTddcBoqhv69JIcjLqCLxBIqk0Kqk1N+R8peoTL4iTpk/w++Ql8NnYhm5sWe/j13Q 81rQdd6CPmTs44Zhx8QH3YVsUceuLG+dH1k2hWldbVedYVvkx6l9rWnR8EAUztozss CBj8YNebMmqJ2CTUZ1H7mhCo0OXFvo7vJrPAmZ/MlMqJQy0rEvWRhq4TZSONp9MJFG EkSY2qWF8hp4TtzwFRqg01fhUfuD1L/SjdOJBXnLBq2lrbMbeoEPOHJ9Gy5nS1Ms// 2t3zI1d/ovKnKXdnaKcmcvVXhsSNVNaJ9zZ/XY6Fh5Gp3Lui0h0L8QhRT9a4g5PYIc 2hCObYE2CVUBA== Date: Thu, 11 Jun 2026 17:40:53 +0100 From: Lee Jones To: linux-kernel-dev@aliel.fr Cc: Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andi Shyti , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Beniamino Galvani , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Liam Girdwood , Mark Brown , linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v7 4/8] mfd: khadas-mcu: Add support for VIM4 MCU variant Message-ID: <20260611164053.GC1212816@google.com> References: <20260603-add-mcu-fan-khadas-vim4-v7-0-594ba8a965d8@aliel.fr> <20260603-add-mcu-fan-khadas-vim4-v7-4-594ba8a965d8@aliel.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260603-add-mcu-fan-khadas-vim4-v7-4-594ba8a965d8@aliel.fr> X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org LyogU2FzaGlrbyBBdXRvbWF0aW9uOiBSZXZpZXdlZCAoMCBGaW5kaW5ncykgKi8KCk9uIFdlZCwg MDMgSnVuIDIwMjYsIFJvbmFsZCBDbGF2ZWF1IHZpYSBCNCBSZWxheSB3cm90ZToKCj4gRnJvbTog Um9uYWxkIENsYXZlYXUgPGxpbnV4LWtlcm5lbC1kZXZAYWxpZWwuZnI+Cj4gCj4gUmVmYWN0b3Ig cHJvYmUoKSB0byB1c2UgcGVyLXZhcmlhbnQgdmFsdWVzCj4gaW5zdGVhZCBvZiBoYXJkY29kZWQg Z2xvYmFscy4KPiAKPiBBZGQgZGVkaWNhdGVkIHJlZ21hcCBjb25maWd1cmF0aW9uIGZvciB0aGUg VklNNCBNQ1UsCj4gd2l0aCBpdHMgb3duIHZvbGF0aWxlL3dyaXRlYWJsZSByZWdpc3RlcnMuCj4g Cj4gQWRkIHRoZSBmYW4gY29udHJvbCByZWdpc3Rlcgo+ICgw4oCTMTAwIGxldmVscyB2cyAw4oCT MyBmb3IgcHJldmlvdXMgc3VwcG9ydGVkIGJvYXJkcykuCj4gCj4gQWRkIGEgbmV3IGNvbXBhdGli bGUgc3RyaW5nICJraGFkYXMsdmltNC1tY3UiLgo+IAo+IFJldmlld2VkLWJ5OiBOZWlsIEFybXN0 cm9uZyA8bmVpbC5hcm1zdHJvbmdAbGluYXJvLm9yZz4KPiBTaWduZWQtb2ZmLWJ5OiBSb25hbGQg Q2xhdmVhdSA8bGludXgta2VybmVsLWRldkBhbGllbC5mcj4KPiAtLS0KPiAgZHJpdmVycy9tZmQv a2hhZGFzLW1jdS5jIHwgMTE1ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KystLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA5OSBpbnNlcnRpb25zKCspLCAxNiBkZWxldGlv bnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZmQva2hhZGFzLW1jdS5jIGIvZHJpdmVy cy9tZmQva2hhZGFzLW1jdS5jCj4gaW5kZXggYmE5ODFhNzg4NjkyMS4uMWJmMjYwNzI5ZDczYiAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL21mZC9raGFkYXMtbWN1LmMKPiArKysgYi9kcml2ZXJzL21m ZC9raGFkYXMtbWN1LmMKPiBAQCAtNzUsNDcgKzc1LDEyOSBAQCBzdGF0aWMgY29uc3Qgc3RydWN0 IHJlZ21hcF9jb25maWcga2hhZGFzX21jdV9yZWdtYXBfY29uZmlnID0gewo+ICAJLmNhY2hlX3R5 cGUJPSBSRUdDQUNIRV9NQVBMRSwKPiAgfTsKPiAgCj4gLXN0YXRpYyBzdHJ1Y3QgbWZkX2NlbGwg a2hhZGFzX21jdV9mYW5fY2VsbHNbXSA9IHsKPiArc3RhdGljIGNvbnN0IHN0cnVjdCBraGFkYXNf bWN1X2Zhbl9wZGF0YSBraGFkYXNfbWN1X2Zhbl9wZGF0YSA9IHsKPiArCS5mYW5fcmVnCT0gS0hB REFTX01DVV9DTURfRkFOX1NUQVRVU19DVFJMX1JFRywKPiArCS5tYXhfbGV2ZWwJPSAzLCAvKiBG YW4gc3BlZWQ6IDAgPSBvZmYsIDEgPSBsb3csIDIgPSBtZWRpdW0sIDMgPSBoaWdoICovCgpJbnN0 ZWFkIG9mIHRoaXMgY29tbWVudCwgeW91IGNvdWxkIGFsd2F5cyBqdXN0IGRlZmluZSB0aGUgdmFs dWUocyk/Cgo+ICt9Owo+ICsKPiArc3RhdGljIGNvbnN0IHN0cnVjdCBtZmRfY2VsbCBraGFkYXNf bWN1X2Zhbl9jZWxsc1tdID0gewo+ICAJLyogVklNMS8yIFJldjEzKyBhbmQgVklNMyBvbmx5ICov Cj4gLQl7IC5uYW1lID0gImtoYWRhcy1tY3UtZmFuLWN0cmwiLCB9LAo+ICsJewo+ICsJCS5uYW1l ID0gImtoYWRhcy1tY3UtZmFuLWN0cmwiLAo+ICsJCS5wbGF0Zm9ybV9kYXRhID0gJmtoYWRhc19t Y3VfZmFuX3BkYXRhLAo+ICsJCS5wZGF0YV9zaXplICAgID0gc2l6ZW9mKGtoYWRhc19tY3VfZmFu X3BkYXRhKSwKCk5vIG5lZWQgdG8gYXR0ZW1wdCB0byBhbGlnbiB0aGUgJz0nIGxpa2UgdGhpcywg cGxlYXNlLgoKPiArCX0sCj4gIH07Cj4gIAo+IC1zdGF0aWMgc3RydWN0IG1mZF9jZWxsIGtoYWRh c19tY3VfY2VsbHNbXSA9IHsKPiArc3RhdGljIGNvbnN0IHN0cnVjdCBtZmRfY2VsbCBraGFkYXNf bWN1X2NlbGxzW10gPSB7Cj4gIAl7IC5uYW1lID0gImtoYWRhcy1tY3UtdXNlci1tZW0iLCB9LAo+ ICB9Owo+ICAKPiArc3RhdGljIGJvb2wga2hhZGFzX21jdV92aW00X3JlZ192b2xhdGlsZShzdHJ1 Y3QgZGV2aWNlICpkZXYsIHVuc2lnbmVkIGludCByZWcpCj4gK3sKPiArCXN3aXRjaCAocmVnKSB7 Cj4gKwljYXNlIEtIQURBU19NQ1VfUFdSX09GRl9DTURfUkVHOgo+ICsJY2FzZSBLSEFEQVNfTUNV X1ZJTTRfUkVTVF9DT05GX1JFRzoKPiArCWNhc2UgS0hBREFTX01DVV9XT0xfSU5JVF9TVEFSVF9S RUc6Cj4gKwljYXNlIEtIQURBU19NQ1VfVklNNF9MRURfT05fUkFNX1JFRzoKPiArCWNhc2UgS0hB REFTX01DVV9WSU00X0ZBTl9DVFJMX1JFRzoKPiArCWNhc2UgS0hBREFTX01DVV9WSU00X1dEVF9F Tl9SRUc6Cj4gKwljYXNlIEtIQURBU19NQ1VfVklNNF9TWVNfUlNUX1JFRzoKPiArCQlyZXR1cm4g dHJ1ZTsKPiArCWRlZmF1bHQ6Cj4gKwkJcmV0dXJuIGZhbHNlOwo+ICsJfQo+ICt9Cj4gKwo+ICtz dGF0aWMgYm9vbCBraGFkYXNfbWN1X3ZpbTRfcmVnX3dyaXRlYWJsZShzdHJ1Y3QgZGV2aWNlICpk ZXYsIHVuc2lnbmVkIGludCByZWcpCj4gK3sKPiArCXN3aXRjaCAocmVnKSB7Cj4gKwljYXNlIEtI QURBU19NQ1VfVkVSU0lPTl8wX1JFRzoKPiArCWNhc2UgS0hBREFTX01DVV9WRVJTSU9OXzFfUkVH Ogo+ICsJY2FzZSBLSEFEQVNfTUNVX1NIVVRET1dOX05PUk1BTF9TVEFUVVNfUkVHOgo+ICsJCXJl dHVybiBmYWxzZTsKPiArCWRlZmF1bHQ6Cj4gKwkJcmV0dXJuIHRydWU7Cj4gKwl9Cj4gK30KPiAr Cj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgcmVnbWFwX2NvbmZpZyBraGFkYXNfbWN1X3ZpbTRfcmVn bWFwX2NvbmZpZyA9IHsKPiArCS5yZWdfYml0cwk9IDgsCj4gKwkucmVnX3N0cmlkZQk9IDEsCj4g KwkudmFsX2JpdHMJPSA4LAo+ICsJLm1heF9yZWdpc3Rlcgk9IEtIQURBU19NQ1VfVklNNF9TWVNf UlNUX1JFRywKPiArCS52b2xhdGlsZV9yZWcJPSBraGFkYXNfbWN1X3ZpbTRfcmVnX3ZvbGF0aWxl LAo+ICsJLndyaXRlYWJsZV9yZWcJPSBraGFkYXNfbWN1X3ZpbTRfcmVnX3dyaXRlYWJsZSwKPiAr CS5jYWNoZV90eXBlCT0gUkVHQ0FDSEVfTUFQTEUsCj4gK307Cj4gKwo+ICtzdGF0aWMgY29uc3Qg c3RydWN0IGtoYWRhc19tY3VfZmFuX3BkYXRhIGtoYWRhc192aW00X2Zhbl9wZGF0YSA9IHsKPiAr CS5mYW5fcmVnCT0gS0hBREFTX01DVV9WSU00X0ZBTl9DVFJMX1JFRywKPiArCS5tYXhfbGV2ZWwJ PSAweDY0LAo+ICt9Owo+ICsKPiArc3RhdGljIGNvbnN0IHN0cnVjdCBtZmRfY2VsbCBraGFkYXNf bWN1X3ZpbTRfY2VsbHNbXSA9IHsKPiArCXsKPiArCQkubmFtZQkJPSAia2hhZGFzLW1jdS1mYW4t Y3RybCIsCj4gKwkJLnBsYXRmb3JtX2RhdGEJPSAma2hhZGFzX3ZpbTRfZmFuX3BkYXRhLAo+ICsJ CS5wZGF0YV9zaXplCT0gc2l6ZW9mKGtoYWRhc192aW00X2Zhbl9wZGF0YSksCj4gKwl9LAo+ICt9 Owo+ICsKPiAgc3RhdGljIGludCBraGFkYXNfbWN1X3Byb2JlKHN0cnVjdCBpMmNfY2xpZW50ICpj bGllbnQpCj4gIHsKPiArCWNvbnN0IHN0cnVjdCBtZmRfY2VsbCAqY2VsbHMsICpmYW5fY2VsbHM7 Cj4gKwljb25zdCBzdHJ1Y3QgcmVnbWFwX2NvbmZpZyAqcmVnbWFwX2NmZzsKPiAgCXN0cnVjdCBk ZXZpY2UgKmRldiA9ICZjbGllbnQtPmRldjsKPiArCWludCBuY2VsbHMsIG5mYW5fY2VsbHMsIHJl dDsKPiAgCXN0cnVjdCBraGFkYXNfbWN1ICpkZGF0YTsKPiAtCWludCByZXQ7Cj4gIAo+ICAJZGRh dGEgPSBkZXZtX2t6YWxsb2MoZGV2LCBzaXplb2YoKmRkYXRhKSwgR0ZQX0tFUk5FTCk7Cj4gIAlp ZiAoIWRkYXRhKQo+ICAJCXJldHVybiAtRU5PTUVNOwo+ICAKPiArCXN3aXRjaCAoKHVpbnRwdHJf dClpMmNfZ2V0X21hdGNoX2RhdGEoY2xpZW50KSkgewo+ICsJY2FzZSBLSEFEQVNfTUNVX0dFTkVS SUM6Cj4gKwkJcmVnbWFwX2NmZwk9ICZraGFkYXNfbWN1X3JlZ21hcF9jb25maWc7Cj4gKwkJY2Vs bHMJCT0ga2hhZGFzX21jdV9jZWxsczsKPiArCQluY2VsbHMJCT0gQVJSQVlfU0laRShraGFkYXNf bWN1X2NlbGxzKTsKPiArCQlmYW5fY2VsbHMJPSBraGFkYXNfbWN1X2Zhbl9jZWxsczsKPiArCQlu ZmFuX2NlbGxzCT0gQVJSQVlfU0laRShraGFkYXNfbWN1X2Zhbl9jZWxscyk7Cj4gKwkJYnJlYWs7 Cj4gKwljYXNlIEtIQURBU19NQ1VfVklNNDoKPiArCQlyZWdtYXBfY2ZnCT0gJmtoYWRhc19tY3Vf dmltNF9yZWdtYXBfY29uZmlnOwo+ICsJCWNlbGxzCQk9IE5VTEw7Cj4gKwkJbmNlbGxzCQk9IDA7 Cj4gKwkJZmFuX2NlbGxzCT0ga2hhZGFzX21jdV92aW00X2NlbGxzOwo+ICsJCW5mYW5fY2VsbHMJ PSBBUlJBWV9TSVpFKGtoYWRhc19tY3VfdmltNF9jZWxscyk7CgpJJ20gbm90IGFzIG9mZmVuZGVk IGJ5IHRoaXMgYXMgSSB0aG91Z2h0IEkgd291bGQgYmUhCgo+ICsJCWJyZWFrOwo+ICsJZGVmYXVs dDoKPiArCQlyZXR1cm4gLUVOT0RFVjsKPiArCX0KPiArCj4gIAlpMmNfc2V0X2NsaWVudGRhdGEo Y2xpZW50LCBkZGF0YSk7Cj4gIAo+ICAJZGRhdGEtPmRldiA9IGRldjsKPiAgCj4gLQlkZGF0YS0+ cmVnbWFwID0gZGV2bV9yZWdtYXBfaW5pdF9pMmMoY2xpZW50LCAma2hhZGFzX21jdV9yZWdtYXBf Y29uZmlnKTsKPiArCWRkYXRhLT5yZWdtYXAgPSBkZXZtX3JlZ21hcF9pbml0X2kyYyhjbGllbnQs IHJlZ21hcF9jZmcpOwo+ICAJaWYgKElTX0VSUihkZGF0YS0+cmVnbWFwKSkgewo+ICAJCXJldCA9 IFBUUl9FUlIoZGRhdGEtPnJlZ21hcCk7Cj4gLQkJZGV2X2VycihkZXYsICJGYWlsZWQgdG8gYWxs b2NhdGUgcmVnaXN0ZXIgbWFwOiAlZFxuIiwgcmV0KTsKPiAtCQlyZXR1cm4gcmV0Owo+ICsJCXJl dHVybiBkZXZfZXJyX3Byb2JlKGRldiwgcmV0LCAiRmFpbGVkIHRvIGFsbG9jYXRlIHJlZ2lzdGVy IG1hcFxuIik7Cj4gIAl9Cj4gIAo+IC0JcmV0ID0gZGV2bV9tZmRfYWRkX2RldmljZXMoZGV2LCBQ TEFURk9STV9ERVZJRF9OT05FLAo+IC0JCQkJICAga2hhZGFzX21jdV9jZWxscywKPiAtCQkJCSAg IEFSUkFZX1NJWkUoa2hhZGFzX21jdV9jZWxscyksCj4gLQkJCQkgICBOVUxMLCAwLCBOVUxMKTsK PiAtCWlmIChyZXQpCj4gLQkJcmV0dXJuIHJldDsKPiArCWlmIChjZWxscyAmJiBuY2VsbHMpIHsK PiArCQlyZXQgPSBkZXZtX21mZF9hZGRfZGV2aWNlcyhkZXYsIFBMQVRGT1JNX0RFVklEX05PTkUs Cj4gKwkJCQkJICAgY2VsbHMsCj4gKwkJCQkJICAgbmNlbGxzLAo+ICsJCQkJCSAgIE5VTEwsIDAs IE5VTEwpOwo+ICsJCWlmIChyZXQpCj4gKwkJCXJldHVybiByZXQ7Cj4gKwl9Cj4gIAo+ICAJaWYg KG9mX3Byb3BlcnR5X3ByZXNlbnQoZGV2LT5vZl9ub2RlLCAiI2Nvb2xpbmctY2VsbHMiKSkKPiAg CQlyZXR1cm4gZGV2bV9tZmRfYWRkX2RldmljZXMoZGV2LCBQTEFURk9STV9ERVZJRF9OT05FLAo+ IC0JCQkJCSAgICBraGFkYXNfbWN1X2Zhbl9jZWxscywKPiAtCQkJCQkgICAgQVJSQVlfU0laRShr aGFkYXNfbWN1X2Zhbl9jZWxscyksCj4gKwkJCQkJICAgIGZhbl9jZWxscywKPiArCQkJCQkgICAg bmZhbl9jZWxscywKPiAgCQkJCQkgICAgTlVMTCwgMCwgTlVMTCk7Cj4gIAo+ICAJcmV0dXJuIDA7 Cj4gQEAgLTEyMyw3ICsyMDUsOCBAQCBzdGF0aWMgaW50IGtoYWRhc19tY3VfcHJvYmUoc3RydWN0 IGkyY19jbGllbnQgKmNsaWVudCkKPiAgCj4gICNpZmRlZiBDT05GSUdfT0YKPiAgc3RhdGljIGNv bnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQga2hhZGFzX21jdV9vZl9tYXRjaFtdID0gewo+IC0JeyAu Y29tcGF0aWJsZSA9ICJraGFkYXMsbWN1IiwgfSwKPiArCXsgLmNvbXBhdGlibGUgPSAia2hhZGFz LG1jdSIsIC5kYXRhID0gKHZvaWQgKilLSEFEQVNfTUNVX0dFTkVSSUMgfSwKPiArCXsgLmNvbXBh dGlibGUgPSAia2hhZGFzLHZpbTQtbWN1IiwgLmRhdGEgPSAodm9pZCAqKUtIQURBU19NQ1VfVklN NCB9LAo+ICAJe30sCj4gIH07Cj4gIE1PRFVMRV9ERVZJQ0VfVEFCTEUob2YsIGtoYWRhc19tY3Vf b2ZfbWF0Y2gpOwo+IAo+IC0tIAo+IDIuNDkuMAo+IAo+IAoKLS0gCkxlZSBKb25lcwoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYW1sb2dpYyBt YWlsaW5nIGxpc3QKbGludXgtYW1sb2dpY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYW1sb2dpYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB31DCD98CF for ; Thu, 11 Jun 2026 16:41:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ROq1lVBMd1TqONzV7EX6xzWPckJNHZDfKK4kRsAGgBI=; b=eoGuwPzXOiDuU7pVA70HhtfGwz WsGpDCb9WtIki7H18oJxnokSNHDvrEPDsOs19UBs/WJm4rFbid4q+52qy60A0KDGVZWPwymcoLh4d IEgwS4N7WZSmgXbVlshkVbLaOBsA+W9x+vpd47Y/17DVioCPrIJQ+6wwDyKSNYTb6SJIOUDMFQyEa UXwsGM/06PO6HIk2zttpCZhjSKUHXMp3UDZ42BTV6RQpeogO98N3ExlQi5zoJlzVt+K0RcBwfXzVm uvhyFMvoViLCaQeEWYakMeVNuEtktcKpuFTGpyy7/TzE8B6ls/eDIzaf4R+z32kwHN9SAQFAgYkRu /mh6X9Yg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wXiSj-00000009mES-3jZw; Thu, 11 Jun 2026 16:41:01 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wXiSi-00000009mEF-3nOM; Thu, 11 Jun 2026 16:41:00 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 9401E41A2A; Thu, 11 Jun 2026 16:41:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E1751F00893; Thu, 11 Jun 2026 16:40:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781196060; bh=ROq1lVBMd1TqONzV7EX6xzWPckJNHZDfKK4kRsAGgBI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=LTddcBoqhv69JIcjLqCLxBIqk0Kqk1N+R8peoTL4iTpk/w++Ql8NnYhm5sWe/j13Q 81rQdd6CPmTs44Zhx8QH3YVsUceuLG+dH1k2hWldbVedYVvkx6l9rWnR8EAUztozss CBj8YNebMmqJ2CTUZ1H7mhCo0OXFvo7vJrPAmZ/MlMqJQy0rEvWRhq4TZSONp9MJFG EkSY2qWF8hp4TtzwFRqg01fhUfuD1L/SjdOJBXnLBq2lrbMbeoEPOHJ9Gy5nS1Ms// 2t3zI1d/ovKnKXdnaKcmcvVXhsSNVNaJ9zZ/XY6Fh5Gp3Lui0h0L8QhRT9a4g5PYIc 2hCObYE2CVUBA== Date: Thu, 11 Jun 2026 17:40:53 +0100 From: Lee Jones To: linux-kernel-dev@aliel.fr Cc: Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andi Shyti , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Beniamino Galvani , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Liam Girdwood , Mark Brown , linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v7 4/8] mfd: khadas-mcu: Add support for VIM4 MCU variant Message-ID: <20260611164053.GC1212816@google.com> References: <20260603-add-mcu-fan-khadas-vim4-v7-0-594ba8a965d8@aliel.fr> <20260603-add-mcu-fan-khadas-vim4-v7-4-594ba8a965d8@aliel.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260603-add-mcu-fan-khadas-vim4-v7-4-594ba8a965d8@aliel.fr> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org /* Sashiko Automation: Reviewed (0 Findings) */ On Wed, 03 Jun 2026, Ronald Claveau via B4 Relay wrote: > From: Ronald Claveau > > Refactor probe() to use per-variant values > instead of hardcoded globals. > > Add dedicated regmap configuration for the VIM4 MCU, > with its own volatile/writeable registers. > > Add the fan control register > (0–100 levels vs 0–3 for previous supported boards). > > Add a new compatible string "khadas,vim4-mcu". > > Reviewed-by: Neil Armstrong > Signed-off-by: Ronald Claveau > --- > drivers/mfd/khadas-mcu.c | 115 ++++++++++++++++++++++++++++++++++++++++------- > 1 file changed, 99 insertions(+), 16 deletions(-) > > diff --git a/drivers/mfd/khadas-mcu.c b/drivers/mfd/khadas-mcu.c > index ba981a7886921..1bf260729d73b 100644 > --- a/drivers/mfd/khadas-mcu.c > +++ b/drivers/mfd/khadas-mcu.c > @@ -75,47 +75,129 @@ static const struct regmap_config khadas_mcu_regmap_config = { > .cache_type = REGCACHE_MAPLE, > }; > > -static struct mfd_cell khadas_mcu_fan_cells[] = { > +static const struct khadas_mcu_fan_pdata khadas_mcu_fan_pdata = { > + .fan_reg = KHADAS_MCU_CMD_FAN_STATUS_CTRL_REG, > + .max_level = 3, /* Fan speed: 0 = off, 1 = low, 2 = medium, 3 = high */ Instead of this comment, you could always just define the value(s)? > +}; > + > +static const struct mfd_cell khadas_mcu_fan_cells[] = { > /* VIM1/2 Rev13+ and VIM3 only */ > - { .name = "khadas-mcu-fan-ctrl", }, > + { > + .name = "khadas-mcu-fan-ctrl", > + .platform_data = &khadas_mcu_fan_pdata, > + .pdata_size = sizeof(khadas_mcu_fan_pdata), No need to attempt to align the '=' like this, please. > + }, > }; > > -static struct mfd_cell khadas_mcu_cells[] = { > +static const struct mfd_cell khadas_mcu_cells[] = { > { .name = "khadas-mcu-user-mem", }, > }; > > +static bool khadas_mcu_vim4_reg_volatile(struct device *dev, unsigned int reg) > +{ > + switch (reg) { > + case KHADAS_MCU_PWR_OFF_CMD_REG: > + case KHADAS_MCU_VIM4_REST_CONF_REG: > + case KHADAS_MCU_WOL_INIT_START_REG: > + case KHADAS_MCU_VIM4_LED_ON_RAM_REG: > + case KHADAS_MCU_VIM4_FAN_CTRL_REG: > + case KHADAS_MCU_VIM4_WDT_EN_REG: > + case KHADAS_MCU_VIM4_SYS_RST_REG: > + return true; > + default: > + return false; > + } > +} > + > +static bool khadas_mcu_vim4_reg_writeable(struct device *dev, unsigned int reg) > +{ > + switch (reg) { > + case KHADAS_MCU_VERSION_0_REG: > + case KHADAS_MCU_VERSION_1_REG: > + case KHADAS_MCU_SHUTDOWN_NORMAL_STATUS_REG: > + return false; > + default: > + return true; > + } > +} > + > +static const struct regmap_config khadas_mcu_vim4_regmap_config = { > + .reg_bits = 8, > + .reg_stride = 1, > + .val_bits = 8, > + .max_register = KHADAS_MCU_VIM4_SYS_RST_REG, > + .volatile_reg = khadas_mcu_vim4_reg_volatile, > + .writeable_reg = khadas_mcu_vim4_reg_writeable, > + .cache_type = REGCACHE_MAPLE, > +}; > + > +static const struct khadas_mcu_fan_pdata khadas_vim4_fan_pdata = { > + .fan_reg = KHADAS_MCU_VIM4_FAN_CTRL_REG, > + .max_level = 0x64, > +}; > + > +static const struct mfd_cell khadas_mcu_vim4_cells[] = { > + { > + .name = "khadas-mcu-fan-ctrl", > + .platform_data = &khadas_vim4_fan_pdata, > + .pdata_size = sizeof(khadas_vim4_fan_pdata), > + }, > +}; > + > static int khadas_mcu_probe(struct i2c_client *client) > { > + const struct mfd_cell *cells, *fan_cells; > + const struct regmap_config *regmap_cfg; > struct device *dev = &client->dev; > + int ncells, nfan_cells, ret; > struct khadas_mcu *ddata; > - int ret; > > ddata = devm_kzalloc(dev, sizeof(*ddata), GFP_KERNEL); > if (!ddata) > return -ENOMEM; > > + switch ((uintptr_t)i2c_get_match_data(client)) { > + case KHADAS_MCU_GENERIC: > + regmap_cfg = &khadas_mcu_regmap_config; > + cells = khadas_mcu_cells; > + ncells = ARRAY_SIZE(khadas_mcu_cells); > + fan_cells = khadas_mcu_fan_cells; > + nfan_cells = ARRAY_SIZE(khadas_mcu_fan_cells); > + break; > + case KHADAS_MCU_VIM4: > + regmap_cfg = &khadas_mcu_vim4_regmap_config; > + cells = NULL; > + ncells = 0; > + fan_cells = khadas_mcu_vim4_cells; > + nfan_cells = ARRAY_SIZE(khadas_mcu_vim4_cells); I'm not as offended by this as I thought I would be! > + break; > + default: > + return -ENODEV; > + } > + > i2c_set_clientdata(client, ddata); > > ddata->dev = dev; > > - ddata->regmap = devm_regmap_init_i2c(client, &khadas_mcu_regmap_config); > + ddata->regmap = devm_regmap_init_i2c(client, regmap_cfg); > if (IS_ERR(ddata->regmap)) { > ret = PTR_ERR(ddata->regmap); > - dev_err(dev, "Failed to allocate register map: %d\n", ret); > - return ret; > + return dev_err_probe(dev, ret, "Failed to allocate register map\n"); > } > > - ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, > - khadas_mcu_cells, > - ARRAY_SIZE(khadas_mcu_cells), > - NULL, 0, NULL); > - if (ret) > - return ret; > + if (cells && ncells) { > + ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, > + cells, > + ncells, > + NULL, 0, NULL); > + if (ret) > + return ret; > + } > > if (of_property_present(dev->of_node, "#cooling-cells")) > return devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, > - khadas_mcu_fan_cells, > - ARRAY_SIZE(khadas_mcu_fan_cells), > + fan_cells, > + nfan_cells, > NULL, 0, NULL); > > return 0; > @@ -123,7 +205,8 @@ static int khadas_mcu_probe(struct i2c_client *client) > > #ifdef CONFIG_OF > static const struct of_device_id khadas_mcu_of_match[] = { > - { .compatible = "khadas,mcu", }, > + { .compatible = "khadas,mcu", .data = (void *)KHADAS_MCU_GENERIC }, > + { .compatible = "khadas,vim4-mcu", .data = (void *)KHADAS_MCU_VIM4 }, > {}, > }; > MODULE_DEVICE_TABLE(of, khadas_mcu_of_match); > > -- > 2.49.0 > > -- Lee Jones