All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: a-christidis@ti.com
Cc: reatmon@ti.com, denys@konsulko.com, meta-ti@lists.yoctoproject.org
Subject: Re: [meta-ti][wrynose/master][PATCH V2] mesa-pvr: Migration from v24.0.1 -> v25.2.8
Date: Thu, 11 Jun 2026 12:50:57 -0400	[thread overview]
Message-ID: <20260611165057.GR23325@denix.org> (raw)
In-Reply-To: <664e282c-f132-497b-9763-4d0df91bdd52@ti.com>

On Thu, Jun 11, 2026 at 11:30:42AM -0500, Antonios Christidis via lists.yoctoproject.org wrote:
> 
> On 6/11/26 8:23 AM, Denys Dmytriyenko wrote:
> >On Wed, Jun 10, 2026 at 09:17:37PM -0500, Ryan Eatmon via lists.yoctoproject.org wrote:
> >>
> >>On 6/10/2026 5:58 PM, Antonios Christidis wrote:
> >>>Dear Ryan Denys,
> >>>
> >>>
> >>>Let me know your thoughts on the overall patch. I am particularly
> >>>interested on your opinions on the following change:
> >>>
> >>>On 6/10/26 5:51 PM, Antonios Christidis via lists.yoctoproject.org wrote:
> >>>>BSP_MESA_PVR_VERSION:bsp-ti-6_18: = "2%"
> >>So... I think what this does is establish the pattern for which
> >>version it will match to.  And then from that pattern it will pick
> >>the highest version.
> >>
> >>So for ALL 6_18 builds it will probably choose 25 and never 24.
> >>Which is not what you want.
> >>
> >>... I think ...
> >>
> >>We have never tried to mix versions like this in the past, so I'm
> >>not 100% sure what the best course is.
> >>
> >>Likely a mixture of the override based on machine needs to be in
> >>there. And for that I'm thinking you might need an extra variable.
> >>
> >>BSP_MESA_PVR_VERSION_6_18 ?= "25%"
> >>BSP_MESA_PVR_VERSION_6_18:am57 = "24%"
> >>BSP_MESA_PVR_VERSION_6_18:ti33 = "24%"
> >>etc...
> >>
> >>BSP_MESA_PVR_VERSION:bsp-ti-6_18 = "${BSP_MESA_PVR_VERSION_6_18}"
> >>
> >>
> >>Something along those lines?  That would be the most clear for
> >>people to follow as well.
> >It was done differently in this patch:
> >
> >mesa-pvr 24 was maked compatible only with SGX platforms, while mesa-pvr 25
> >was marked compatible with the rest of the platforms. Also not ideal though.
> >
> I think Ryan's idea is easier to follow, compared to the flow I have
> included in this series.
> 
> Another way of going about this (I'm not saying this is easier
> and/or a better method) would be to create 2 MACHINEOVERIDES. On a
> per platform level (ex: am62pxx.inc) to add ```MACHINEOVERRIDES =.
> "rogue-core:"```, then within ti-bsp
> ```BSP_MESA_PVR_VERSION:bsp-ti-6_18:rogue-core = "25%"``` picking
> the right version when paired against a sgx-core override.
> 
> An added benefit to this, the new overrides would cut down on the
> need for duplicate variables tracking Rogue vs SGX (examples:
> BSP_SGX_DRIVER_VERSION, BSP_ROGUE_DRIVER_VERSION).
> 
> A downside to this flow, tracking what is currently included
> within MACHINEOVERRIDES , describing what architecture of GPU core
> doesn't really fit well with pre-existing overrides.
> 
> 
> Let me know what you think?

FWIW, we used to have separate "sgx" and "rogue" flags in MACHINE_FEATURES 
years ago. Not exactly MACHINEOVERRIDES, but still easy to do conditionals.

But complaints were that all this needs to be unified and, first, both of 
those flags were merged into "gpu" MACHINE_FEATURES and eventually completely 
removed.

So, I'd argue if you do want to bump mesa-pvr version, it has to be done for 
all the platforms regardless of the graphics core, SGX or Rogue. We've already 
went through a lengthy period in kirkstone (2022 era) where SGX was completely 
broken and customers were sent back to use dunfell (2020 era) just to get SGX 
working at all...


> >>>I wish there was a way to use syntax like
> >>>"BSP_MESA_PVR_VERSION:bsp-ti-6_18 = "24%|25%" or even
> >>>"24.0.1|25.2.8". Is there a better way of enabling this logic ?
> >>>
> >>>Also already aware of the extra ":" post-pended to the variable, I
> >>>can send a v3 if that's all the feedback.
> >>>
> >>>
> >>>Kind Regards,
> >>>
> >>>Antonios
> >>>


  reply	other threads:[~2026-06-11 16:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <18B7DA0BBD971E15.267903@lists.yoctoproject.org>
2026-06-10 22:58 ` [meta-ti][wrynose/master][PATCH V2] mesa-pvr: Migration from v24.0.1 -> v25.2.8 Antonios Christidis
2026-06-10 23:05   ` Denys Dmytriyenko
2026-06-10 23:10     ` Antonios Christidis
2026-06-11 13:35       ` Denys Dmytriyenko
2026-06-11  2:17   ` Ryan Eatmon
2026-06-11 13:23     ` Denys Dmytriyenko
2026-06-11 16:30       ` Antonios Christidis
2026-06-11 16:50         ` Denys Dmytriyenko [this message]
2026-06-11 18:29           ` Antonios Christidis
2026-06-15 19:33             ` Andrew Davis
2026-06-17 14:07               ` Antonios Christidis
2026-06-17 14:30                 ` Ryan Eatmon
2026-06-10 22:51 a-christidis
2026-06-10 22:55 ` PRC Automation
2026-06-10 23:28   ` Ryan Eatmon
2026-06-10 23:32     ` Antonios Christidis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260611165057.GR23325@denix.org \
    --to=denis@denix.org \
    --cc=a-christidis@ti.com \
    --cc=denys@konsulko.com \
    --cc=meta-ti@lists.yoctoproject.org \
    --cc=reatmon@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.