From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 349ABCD98C7 for ; Thu, 11 Jun 2026 17:37:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8A6DF10E1ED; Thu, 11 Jun 2026 17:37:54 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="gm0UEsAK"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id ABBE510E1ED for ; Thu, 11 Jun 2026 17:37:52 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id EF3DA60129; Thu, 11 Jun 2026 17:37:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62DD21F00893; Thu, 11 Jun 2026 17:37:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781199471; bh=2loNpQ+nvyQD04275Wmd+3D3pNZ42j5gmIGYocEWf4c=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=gm0UEsAKL80MOzG/VlQLwRjtK/3DyA51Z5vUkd6yZHT0aBF6PZT6Q1Q+FembV/NzN po6E+kXQtje2NoMgewwIrTsapC6CYecw+bB6fpkT8kq552sSgCFIKBReFB7CgnLayU 4isucdfQYGkDT3S4mwv603Mo8TvSjgIgVp4YMXz9JpBdaid6zh+1MTF0Ghkp42OL5x bUnFSsoSjWs+DPfbOXcjBKO8w8ecXJz13fvpOLheSL0zwV0b2Xe3Kqvb4Z7wutezs3 oH8N8c7hsWWbQljPiTeMuByepRbBJ5G6eWT2dQLCdiJG9zHZ60xCZ+hSuFs8tqx1IJ yazm/lNhlJmLw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 08/20] rust: pci: io: make `ConfigSpace` a view To: "Gary Guo" Cc: linux-pci@vger.kernel.org, ojeda@kernel.org, "Danilo Krummrich" , dri-devel@lists.freedesktop.org, "Alexandre Courbot" In-Reply-To: <20260611-io_projection-v4-8-1f7224b02dcb@garyguo.net> References: <20260611-io_projection-v4-8-1f7224b02dcb@garyguo.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 11 Jun 2026 17:37:50 +0000 Message-Id: <20260611173751.62DD21F00893@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > In order to support I/O projection, we are splitting I/O types into two > categories: owned objects and views. Owned objects have a specific type > that is related to setting up and tearing down, while views can have their > type changed with I/O projection. >=20 > Things like `IoMem` or `Bar` are owned objects, which requires setting up > mapping and cleaning up on drop. On the other side, `ConfigSpace` is real= ly > just a view, as the resource is associated with the `pci::Device`. >=20 > Remove the `ConfigSpaceKind` bound on `ConfigSpace` and make it a generic > view. This means that `ConfigSpace` object now represents a subregion and > therefore encodes offset (as address of pointers) and size (as metadata of > pointers) itself. The full region case is still supported with offset 0 a= nd > size of `cfg_size`. >=20 > Signed-off-by: Gary Guo Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260611-io_project= ion-v4-0-1f7224b02dcb@garyguo.net?part=3D8