From: Raf Dickson <rafdog35@gmail.com>
To: netdev@vger.kernel.org, virtualization@lists.linux.dev
Cc: pabeni@redhat.com, sgarzare@redhat.com, stefanha@redhat.com,
bryan-bt.tan@broadcom.com, vishnu.dasa@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, bobbyeshleman@gmail.com,
leonardi@redhat.com, horms@kernel.org, edumazet@google.com,
kuba@kernel.org, Raf Dickson <rafdog35@gmail.com>
Subject: [PATCH net-next v3 3/4] vsock: fold sk_acceptq_added() into vsock_enqueue_accept()
Date: Fri, 12 Jun 2026 04:52:15 +0000 [thread overview]
Message-ID: <20260612045216.105796-4-rafdog35@gmail.com> (raw)
In-Reply-To: <20260612045216.105796-1-rafdog35@gmail.com>
virtio and hyperv call sk_acceptq_added() immediately before
vsock_enqueue_accept(). Move the call into vsock_enqueue_accept()
itself so callers cannot forget it and the accounting is consistent.
Suggested-by: Paolo Abeni <pabeni@redhat.com>
Suggested-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Raf Dickson <rafdog35@gmail.com>
---
net/vmw_vsock/af_vsock.c | 1 +
net/vmw_vsock/hyperv_transport.c | 1 -
net/vmw_vsock/virtio_transport_common.c | 1 -
3 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
index 6cfa89b6f3..24916dd4e9 100644
--- a/net/vmw_vsock/af_vsock.c
+++ b/net/vmw_vsock/af_vsock.c
@@ -518,6 +518,7 @@ void vsock_enqueue_accept(struct sock *listener, struct sock *connected)
sock_hold(connected);
sock_hold(listener);
list_add_tail(&vconnected->accept_queue, &vlistener->accept_queue);
+ sk_acceptq_added(listener);
}
EXPORT_SYMBOL_GPL(vsock_enqueue_accept);
diff --git a/net/vmw_vsock/hyperv_transport.c b/net/vmw_vsock/hyperv_transport.c
index b3394946b2..0de8148877 100644
--- a/net/vmw_vsock/hyperv_transport.c
+++ b/net/vmw_vsock/hyperv_transport.c
@@ -410,7 +410,6 @@ static void hvs_open_connection(struct vmbus_channel *chan)
if (conn_from_host) {
new->sk_state = TCP_ESTABLISHED;
- sk_acceptq_added(sk);
hvs_new->vm_srv_id = *if_type;
hvs_new->host_srv_id = *if_instance;
diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c
index b10666937c..4a39d48db9 100644
--- a/net/vmw_vsock/virtio_transport_common.c
+++ b/net/vmw_vsock/virtio_transport_common.c
@@ -1582,7 +1582,6 @@ virtio_transport_recv_listen(struct sock *sk, struct sk_buff *skb,
return ret;
}
- sk_acceptq_added(sk);
if (virtio_transport_space_update(child, skb))
child->sk_write_space(child);
--
2.54.0
next prev parent reply other threads:[~2026-06-12 4:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 4:52 [PATCH net-next v3 0/4] vsock: consolidate acceptq accounting into core helpers Raf Dickson
2026-06-12 4:52 ` [PATCH net-next v3 1/4] vsock: introduce vsock_pending_to_accept() helper Raf Dickson
2026-06-12 10:41 ` Stefano Garzarella
2026-06-12 13:30 ` Luigi Leonardi
2026-06-12 14:50 ` Bobby Eshleman
2026-06-12 4:52 ` [PATCH net-next v3 2/4] vsock: fold sk_acceptq_added() into vsock_add_pending() Raf Dickson
2026-06-12 10:42 ` Stefano Garzarella
2026-06-12 13:39 ` Luigi Leonardi
2026-06-12 14:51 ` Bobby Eshleman
2026-06-12 4:52 ` Raf Dickson [this message]
2026-06-12 10:46 ` [PATCH net-next v3 3/4] vsock: fold sk_acceptq_added() into vsock_enqueue_accept() Stefano Garzarella
2026-06-12 13:46 ` Luigi Leonardi
2026-06-12 14:51 ` Bobby Eshleman
2026-06-12 4:52 ` [PATCH net-next v3 4/4] vsock: fold sk_acceptq_removed() into vsock_remove_pending() Raf Dickson
2026-06-12 10:48 ` Stefano Garzarella
2026-06-12 13:47 ` Luigi Leonardi
2026-06-12 14:51 ` Bobby Eshleman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260612045216.105796-4-rafdog35@gmail.com \
--to=rafdog35@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bobbyeshleman@gmail.com \
--cc=bryan-bt.tan@broadcom.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=leonardi@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=vishnu.dasa@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.