From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F095CD8CA8 for ; Fri, 12 Jun 2026 04:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=bgz24M4/4uPCHLuKgkst2TVJAEVFgEWpHS6FcgRLguE=; b=PIffZYpe3KlbIW bmCKbonJxQzkE8nC7VjIFXS+bWyNjRFtxL+OYWgIzk7HgjWuTeHUU+6NgTvHlmWHPwZVEz1EscQpK 35W/d9vtMgcxZWPIP3x9VQ289XQXBTT7rHUciX30qWzyPakBrm4m1kHJtX63YIYPWHrXcHzzFo3T+ oqKhmwhymZqPJBSEmwojjD1oFQooZdLhNHw2JDz/FTZ3iS1DvBId1TFfb7eHNHsIvQlZo8KFuQwN4 EIsLonXRuORETGZzJyWzgmgZZXkfS/WVs8327/wabkWUA5vaTDG4ucp0HaWrOGk9FoCx0Tzy+HiDi xYe+vh/ifvU/oWEfeqDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wXtx6-0000000AMqS-3Shq; Fri, 12 Jun 2026 04:57:08 +0000 Received: from mail-dy1-x1336.google.com ([2607:f8b0:4864:20::1336]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wXtx4-0000000AMqA-2QLE for linux-riscv@lists.infradead.org; Fri, 12 Jun 2026 04:57:07 +0000 Received: by mail-dy1-x1336.google.com with SMTP id 5a478bee46e88-30749947917so1868549eec.1 for ; Thu, 11 Jun 2026 21:57:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781240225; x=1781845025; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=Z070pyGbhpULNtHjr9EHM3bFZbxAO9sEmJk4Z3XYRuA=; b=qiC6eE839R8jChezLRqWj8oupX/2F9IIyuRYp7cHgxeW1vFiiSh1O732hQCsfiNE6y o9lDTy+J7yRZUrCoaAn5XF6ZQ+f1zQ7V8Wjc3VhVERYigy5QNhBGZ8kqek4nvRGDqzZP PcSpWkj0EP+PTTaXAcPCzg/jQJDilBTPhQdqXyCy4fa1Lg17zd1dRKdqc/5UBoIJINz9 Qn2M0DOUmPTGp/g6WT89t+fkMwfq8yo+ye9RBuT7VHluSG37ROKgAqfMnlYvDcay4YS4 cPUvYn5rfyIdr8BjLqiSBjv43eNQBns+D3SXc8OxFpKEjUwiYtEBbhAzDJhnaTq4KGzJ sEjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781240225; x=1781845025; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Z070pyGbhpULNtHjr9EHM3bFZbxAO9sEmJk4Z3XYRuA=; b=kjcR6YMpHjcObW6fivUXZPgPInd+DCbA4LghD4uxGh+7BYCSPedow9Pu8gssPKgAZC K4UaoSVJI7hgKFPe5COkkjk4VQF4Y9UCPZvuzFWd7ZJG1Bcr5tp2ymdxFky8pItLOJx3 Rmibn/fVHaI8idv0ZhTUBTsEcEZpvv62+EKaIbkg2Gp4T/bb/4/rD1SPGSSyfnUOehWQ TcVXzcoZDfu2huz4Ljx3BGnvppygxR8O+W91ByEzxpDgZu9OiR1kzZLAAtmTUXLqcelw BABQz0mOx8LHYs3/M3Rp6AxWJSDChdsq17OpvhWPmIvqT7rtJp2DqhuYXY+5Gb5CyTm0 FI1Q== X-Forwarded-Encrypted: i=1; AFNElJ8eq/kJ1FuFWHQR8wCfyIhT8rhaOAfsxbYBbF0RG29FYtezoee+Hqf+k3ukqGykWOaDRetAf4sUS6+2pw==@lists.infradead.org X-Gm-Message-State: AOJu0YyamnCmkkqHHfqvnI5rPyUrwJPR8FygsUrJZEBFC62zDcr0HEz1 89RRsEtiGEb2QgQZ9W107tTcM88i4GhbxiAR1If1+2JKPf2hGyxJVBAZ X-Gm-Gg: Acq92OF5ESHFFZx7Jwmkwrj+VYgd8/tOR2TkMMr8s/B1oNWMhbhAvssjhwWCShc7eC/ SFF3hN1ZEZBSk4nOVhjS5YNS/yORWvGHMbnYR/MgPV0Y3GGiORE8o1FwYL5MKjZdgjyEzbaMx+s f6lBU/W+LpaQ4IJJRwJUpULFs28nE4yNj3izm0nnQ8ZovBrdKRI56Fk3L5BVh5y1c8S9/5GvPu3 NdNALJ3rUBhGm7cMk7hiR383DJqPCOihlvCxzGyTC9V78kZNe1ryixw3AQ8M3bQeK0drlaiT3EM kw6xbtW0zL9WYACEs0A2j7MdbWb9qsJy+zWftDmV9qtuKWAMl2+HCRa9KHroSjyjNSJFAsjYMhP khVHULTt7aF3/CAe2AtQ9GyaNI/tKAcR/lSG4qSGPgnjBunJCHzcV+FpN+AiJzQSdibtgLeSkye dwPZQfLMI8TpuAo+2e7k5tsxKKDcnDVSK62+zu/a1U X-Received: by 2002:a05:7301:1f05:b0:2f0:c8b5:3dc7 with SMTP id 5a478bee46e88-3082009acafmr774924eec.22.1781240225257; Thu, 11 Jun 2026 21:57:05 -0700 (PDT) Received: from kira.gmail.com ([2601:646:9e01:94:3ce3:853:6bcc:613a]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081eb95450sm2332110eec.28.2026.06.11.21.57.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 21:57:04 -0700 (PDT) From: Mark Harris To: Paul Walmsley , Palmer Dabbelt , Albert Ou Cc: Alexandre Ghiti , Mark Harris , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] riscv: hwprobe: Avoid uninitialized read in hwprobe_get_cpus() Date: Thu, 11 Jun 2026 21:55:02 -0700 Message-ID: <20260612045502.70850-1-mark.hsj@gmail.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260611_215706_618434_F5CA2135 X-CRM114-Status: UNSURE ( 8.08 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org When cpusetsize < cpumask_size(), hwprobe_get_cpus() did not fully initialize its copy of the cpu mask, which could cause non-deterministic results from the riscv_hwprobe syscall on a system with more than 8 CPUs when the supplied cpu mask is empty. Address this by fully initializing the cpu mask. Signed-off-by: Mark Harris --- arch/riscv/kernel/sys_hwprobe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/riscv/kernel/sys_hwprobe.c b/arch/riscv/kernel/sys_hwprobe.c index 1659d31fd288..caf6762427c8 100644 --- a/arch/riscv/kernel/sys_hwprobe.c +++ b/arch/riscv/kernel/sys_hwprobe.c @@ -450,6 +450,7 @@ static int hwprobe_get_cpus(struct riscv_hwprobe __user *pairs, if (cpusetsize > cpumask_size()) cpusetsize = cpumask_size(); + cpumask_clear(&cpus); ret = copy_from_user(&cpus, cpus_user, cpusetsize); if (ret) return -EFAULT; -- 2.54.0 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f182.google.com (mail-dy1-f182.google.com [74.125.82.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DF6425A2BB for ; Fri, 12 Jun 2026 04:57:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781240227; cv=none; b=kBdt1DAyyYUet1KiK+F8CUlIXxzOLbUzvIOiqlJuJdx97pcm4jllVFrlmOgATE2an5ruO1inWL/S4yYoPnRWt5drlGaVPNUMJKbSVQKwebbq5cjfvIZNCxKozjXvtMXrxX2K3ji5nmJWBoWnddNi98LNPgmc2TbCuWnT9sL3P84= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781240227; c=relaxed/simple; bh=o8pfxjKAVt27klCBHl4HZ4Y+0sZzPVfpIdKsrRXlLK4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MWzY/dOuMBTOj+e5xRpLvL6vJznxUS+Y3TPgpFuCIMhKisQtFJbF/ooi7zjmrI8zA5ZZIGPXBEpK9r8cRV7EHMcdggj1RPnuuyPII3HUNjg0d2ytvOdej7e38TMsqw8OlbE1+tbtsv+ogMMz0sps/C/hA2dwlI+TdVKlGvBA3rw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bqpJbcUg; arc=none smtp.client-ip=74.125.82.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bqpJbcUg" Received: by mail-dy1-f182.google.com with SMTP id 5a478bee46e88-30749947917so1868548eec.1 for ; Thu, 11 Jun 2026 21:57:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781240225; x=1781845025; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=Z070pyGbhpULNtHjr9EHM3bFZbxAO9sEmJk4Z3XYRuA=; b=bqpJbcUgNtDDxLGrIJPum8IWf0++rl61fwnjfL7ddA1QISYp1VPs44Lcj+Ekm/LN0x Fb6UoGRl1G6dXKDKK/OV2s7uoWlVDCV2VNmgqPHoC8VJsNc1/4Ov/bLEKn5C6QjKFrA1 BIvbRzKHps1Gv3S3ul/34zh9D6HCnazzDhuqeP6PjCdkWfZK8wWtBw/h+IwgRUh0spTd 5bkVwLmhKG1d8Po0A/TKpBGGkimXKc2K+byx1C/JfuSTskJQ7I9DrML5wt9MCxMc2pch atchEXv+qn3GB6ODYi7SWSOpxaSiqi0AZQKuxdoOPzqCUBgiLcX4vsc16yObEchjmocP GV4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781240225; x=1781845025; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Z070pyGbhpULNtHjr9EHM3bFZbxAO9sEmJk4Z3XYRuA=; b=i3JNN0uQSqcodOeS3CtHOoJbqvdx3iaGPWaKaWIuYq8p1inJQ8giA5TN21aP5idV5O UM9N10vwqSFSdQ4Mtg+jIH6fUCWz4VWB6lMCsg1DHz2c3avZxWpz0qZbvdHmFijE32Tp sG8kSUaCkLAsXBiSiF3OSBaMm75+UDW1NQxYFBdCt93xMCfr3mny8T6EhAILgnSgyuyA PSrtPrtWZkoiAx3TvuQ6sxrQnm7Tsq6YYZ16qUju3S3rqn/MX3y2MTczZwHu+ZihZlFq MiqJEpATDf8IEIho3+Nrcaghyt9lTT0et4SV8b9UH5kGutzOagQXlkxGXAMy9gNDLjkj 0XLQ== X-Forwarded-Encrypted: i=1; AFNElJ9iy9UPkfkYnwylShkXjIbtU4LCHhh04HDppYviC5shPubQ/PKOkhksvywTDt2fruWRKD83NYZ9tRiv9is=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7WV1Cnky7/dkYLk0hZTGxkrwCM24t4lbSXfFZkxvmoPbDqm8E eEAVwRWeV3ULcxhJ+IY7q5okocOhDhgMjYziFt8xrp/rhqxBHSbDK+cy X-Gm-Gg: Acq92OH/H0KeJscsb9P6uMZtGGD5GcfoGLav4iAgl9g4D0igbAieOjsvJppkfVMZTvp BfKECszR/7A8PPs9rjYaCi0IGhiS4SJ/jXqm0oBhRMEWsB4Z7iqbbtW7MQwf9VpbK4WGBd8a0bE nAFRc0D7PR+V4jsNH3O3glRM9ATQf4PbqG1zGJzBkCNiglnunFXTzCPuo5haRivo9X8BLmtG8Ha vBoaj/eUJISfHDlQ/5F6xwokh9afA+GXz7JsJtivgq9okhWQq5KaQtaEfHL7hULXTpuRNxMTB9r /0zVs8vjy5k1zwtmrHGheWM8F1Lz0jt2CyFUuScc1wbxJvwQHUPPMYkC9lMoY2s7uURrudjSO5I QNg0J60gyesIdhBokkmGadpJnPjbHbgmSKvVwleYnRRYR8+iT6Bag+CzW42fdmLYjdMt0CrBuIH B7iRhzO48+G0CkU1C72oi09bXxYBjVZbrAlwMBMPqZ X-Received: by 2002:a05:7301:1f05:b0:2f0:c8b5:3dc7 with SMTP id 5a478bee46e88-3082009acafmr774924eec.22.1781240225257; Thu, 11 Jun 2026 21:57:05 -0700 (PDT) Received: from kira.gmail.com ([2601:646:9e01:94:3ce3:853:6bcc:613a]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081eb95450sm2332110eec.28.2026.06.11.21.57.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 21:57:04 -0700 (PDT) Sender: Mark Harris From: Mark Harris To: Paul Walmsley , Palmer Dabbelt , Albert Ou Cc: Alexandre Ghiti , Mark Harris , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] riscv: hwprobe: Avoid uninitialized read in hwprobe_get_cpus() Date: Thu, 11 Jun 2026 21:55:02 -0700 Message-ID: <20260612045502.70850-1-mark.hsj@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When cpusetsize < cpumask_size(), hwprobe_get_cpus() did not fully initialize its copy of the cpu mask, which could cause non-deterministic results from the riscv_hwprobe syscall on a system with more than 8 CPUs when the supplied cpu mask is empty. Address this by fully initializing the cpu mask. Signed-off-by: Mark Harris --- arch/riscv/kernel/sys_hwprobe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/riscv/kernel/sys_hwprobe.c b/arch/riscv/kernel/sys_hwprobe.c index 1659d31fd288..caf6762427c8 100644 --- a/arch/riscv/kernel/sys_hwprobe.c +++ b/arch/riscv/kernel/sys_hwprobe.c @@ -450,6 +450,7 @@ static int hwprobe_get_cpus(struct riscv_hwprobe __user *pairs, if (cpusetsize > cpumask_size()) cpusetsize = cpumask_size(); + cpumask_clear(&cpus); ret = copy_from_user(&cpus, cpus_user, cpusetsize); if (ret) return -EFAULT; -- 2.54.0