From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97F77CD98CE for ; Fri, 12 Jun 2026 16:05:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0211510EA87; Fri, 12 Jun 2026 16:05:22 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="l777kD8V"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id A360910EA7A for ; Fri, 12 Jun 2026 16:05:20 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 09DD640D6F; Fri, 12 Jun 2026 16:05:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B24351F00A3D; Fri, 12 Jun 2026 16:05:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781280319; bh=xD8fHD0dBqI+BHWfEGmw4yez/dwz1dD2SEmToWisjAQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=l777kD8VtCnF+vbkmTpbqVw2e3E1/M679W4VlXzwQeqa4kTJ/wLIFUC3feaj0o1VL WjsGN+zFA1bff5XeGcbbYx+h52tYZIErrevvGi/wzafNwNuW6kXJsX2aYx6pJ6/e1x Hm6bIYi8h8W5XlEnGnVODxXeNVRj43cJrK/WpatG0Tkx7mbrRCprxQSxz0ES2MjriZ qKidJqMVeeFO/d9+jQZOQ7GyX/tVYsJHAD6d7AYaPEvAZ4aDEjTqBw1PFeEuNBGFek TNg+rgshXRBpHq0p9RaaaZcsIUhd91sqEzXsJ1UWwP9H9Fwwn6GU/VSSnmMnSdkOIs ZIyfyJpST+yZw== Date: Fri, 12 Jun 2026 11:05:19 -0500 From: Rob Herring To: Krzysztof Kozlowski Cc: Abel Vesa , Konrad Dybcio , rob.clark@oss.qualcomm.com, Neil Armstrong , Jessica Zhang , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , Bjorn Andersson , Konrad Dybcio , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 2/4] dt-bindings: arm: qcom: Add Lenovo Yoga Slim 7x Gen11 Message-ID: <20260612160519.GA1118842-robh@kernel.org> References: <20260604-topic-yoga_submission-v1-0-57c70c23d0d6@oss.qualcomm.com> <20260604-topic-yoga_submission-v1-2-57c70c23d0d6@oss.qualcomm.com> <7a330941-8715-4523-9f39-10b57586c69d@kernel.org> <799fea04-e7d0-4184-b9ae-4cebfdac38d5@kernel.org> <841a54ff-6287-48d2-a513-a7442d624ab6@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jun 11, 2026 at 03:48:15PM +0200, Krzysztof Kozlowski wrote: > On 10/06/2026 15:31, Abel Vesa wrote: > >>>>>> @@ -68,6 +68,7 @@ properties: > >>>>>> > >>>>>> - items: > >>>>>> - enum: > >>>>>> + - lenovo,yoga-slim7x-gen11 > >>>>> > >>>>> I imagine you might want different panel variants, just like T14s has > >>>>> LCD and OLED? > >>>> > >>>> I expect this will be the case. > >>> > >>> Then better to prepare for this now, otherwise later you need to change > >>> bindings. If unsure what other variants are, then at least make this > >>> compatible panel-specific, e.g. lenovo,yoga-slim7x-gen11-oled-foo-bar. > >> > >> I took another look at psref [1] and there's only OLED SKUs (today?). > >> There are however, two different resolutions available and both can be > >> touch/notouch. > > > > If the other SKU doesn't have touch, then you might as well mark now this > > one with touch suffix or something like that. > > > If you decide not to have any changes (new compatibles), then at least > please document the above reasoning in commit msg. If the difference is just the panel or touch, then isn't that captured by the panel and/or touch nodes? OTOH, if it's different firmware builds and generally treated as 2 different devices, then different top-level compatible is probably fine. Rob