From: linuxtestproject.agent@gmail.com
To: Avinesh Kumar <avinesh.kumar@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] tst_security.sh: Use enforce toggle to trigger SELinux measurement
Date: Fri, 12 Jun 2026 19:07:50 +0000 [thread overview]
Message-ID: <20260612190750.3946-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260612163808.293181-1-avinesh.kumar@suse.com>
Hi Avinesh,
On Fri, 12 Jun 2026 18:38:04 +0200, Avinesh Kumar wrote:
> tst_security.sh: Use enforce toggle to trigger SELinux measurement
> + orig_val=$(cat $dir/enforce)
> + val=$((1 - orig_val))
> + echo $val > $dir/enforce
> + echo $orig_val > $dir/enforce
`orig_val` is not declared `local`, unlike `val` and `dir` in the
same function. This leaks `orig_val` into the caller's scope.
Should the declaration on line 145 be:
local val orig_val
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-06-12 19:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 16:38 [LTP] [PATCH] tst_security.sh: Use enforce toggle to trigger SELinux measurement Avinesh Kumar via ltp
2026-06-12 19:07 ` linuxtestproject.agent [this message]
2026-06-15 11:13 ` [LTP] [PATCH v2] " Avinesh Kumar via ltp
2026-06-15 13:17 ` [LTP] " linuxtestproject.agent
2026-06-16 8:34 ` [LTP] [PATCH v2] " Andrea Cervesato via ltp
2026-06-16 9:25 ` Avinesh Kumar via ltp
2026-06-16 10:58 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260612190750.3946-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=avinesh.kumar@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.