From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A3733D3D1C; Fri, 12 Jun 2026 22:25:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781303107; cv=none; b=cJp/8al8l6Hh0RledD+Jq7KTbUU1r4FnC++NqfIe+AHiwQt0v2391JSPyM6LUS1rUtUwryhrDpO5xiAYlxfeiXTggeUR10IssMbFmFrryjuUaTdtwj/pN8gAK+VlMeVHny1ESTCUdKUBToc7fO17c+kjO6gN9uxOAZrKGdRjPOE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781303107; c=relaxed/simple; bh=+6JaWrJ4iYQzg7eXzGi6/vMHqUpYgAZPzmfdfjpBfVU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JGU2OUbrqxOaD0M+XRDA28Ggxngki+YjRwgDzN9ghhT5AYg22KAUOuHFlJHIx+DPFRI3HNrzf9FOR0+4BCfzrxqHaWQxJc0fatoYF1+84JFcYmj3kFymhEFAGSprrEkhJ+KesAmJ2GxEgmu87rk87ogZDoGxrhcOmN0JkbdB3jY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Cw/8Mobm; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Cw/8Mobm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB8FB1F000E9; Fri, 12 Jun 2026 22:25:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781303106; bh=qzTzsD/ccVOr8cDLM4jg2BBitA/CpaStF8lfTIgjIOc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Cw/8Mobm5L9/BU7Kpppzd3YNUAAxfXp9wePX+sqqVxS/JmTHMxaIWO6y42e9Ykbdg 2eKztTcA73/AqOJRym4oYn+CGMMmOjle6omOXWBIFrdQR5DCWyElSERBxr914KLEXI vq+pL8uRF/UTlg4YXPj8eRWS1O4PqcR61YH1VMobVjiRM2sXCGTFBHYBqpLj0zPTCO PWSxDvI/OZPj2cb8UJ5XAXUsPRDb500E2EtQOmCidqOUac3VM5XAOT8WoDN913WJyY //WIKEfHUTbdw8Ui/1oX3cWjHNwQgP/H4fy9XdrgR9mtoIidVd9vJG1YwsmFXRTQTE ygZPqG9ynpVYQ== From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Thomas Gleixner , James Clark , Jiri Olsa , Ian Rogers , Adrian Hunter , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , sashiko-bot , "Claude Opus 4.6" Subject: [PATCH 12/13] perf c2c: Free format list entries when releasing c2c hist entries Date: Fri, 12 Jun 2026 19:24:11 -0300 Message-ID: <20260612222413.40791-13-acme@kernel.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260612222413.40791-1-acme@kernel.org> References: <20260612222413.40791-1-acme@kernel.org> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Arnaldo Carvalho de Melo c2c_hists__init() calls hpp_list__parse() which allocates and registers format entries on hists->list. When c2c_he_free() destroys a c2c hist entry, it deletes the histogram entries and frees the hists container but never unregisters the format list entries, leaking them. Call perf_hpp__reset_output_field() before freeing the hists to properly unregister and free all format entries. Fixes: f485e33c4543ac31 ("perf c2c report: Add cacheline hists processing") Reported-by: sashiko-bot Closes: https://sashiko.dev/finding/41 Cc: Jiri Olsa Assisted-by: Claude Opus 4.6 Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-c2c.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c index e205f58b2f3d3786..07c7e8fb315e6cf3 100644 --- a/tools/perf/builtin-c2c.c +++ b/tools/perf/builtin-c2c.c @@ -185,6 +185,7 @@ static void c2c_he_free(void *he) c2c_he = container_of(he, struct c2c_hist_entry, he); if (c2c_he->hists) { hists__delete_entries(&c2c_he->hists->hists); + perf_hpp__reset_output_field(&c2c_he->hists->list); zfree(&c2c_he->hists); } -- 2.54.0