From: kernel test robot <lkp@intel.com>
To: Jipa Alexandru-Ionut <jipaionut@gmail.com>,
valentina.manea.m@gmail.com, shuah@kernel.org, i@zenithal.me,
gregkh@linuxfoundation.org
Cc: oe-kbuild-all@lists.linux.dev, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Jipa Alexandru-Ionut <jipaionut@gmail.com>
Subject: Re: [PATCH] usbip: vudc: fix NULL pointer dereference in vep_dequeue
Date: Sat, 13 Jun 2026 02:32:09 +0800 [thread overview]
Message-ID: <202606130221.e57TS4Rk-lkp@intel.com> (raw)
In-Reply-To: <20260612114148.6849-1-jipaionut@gmail.com>
Hi Jipa,
kernel test robot noticed the following build warnings:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on usb/usb-next usb/usb-linus linus/master v7.1-rc7 next-20260611]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Jipa-Alexandru-Ionut/usbip-vudc-fix-NULL-pointer-dereference-in-vep_dequeue/20260612-195006
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link: https://lore.kernel.org/r/20260612114148.6849-1-jipaionut%40gmail.com
patch subject: [PATCH] usbip: vudc: fix NULL pointer dereference in vep_dequeue
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20260613/202606130221.e57TS4Rk-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260613/202606130221.e57TS4Rk-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202606130221.e57TS4Rk-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/usb/usbip/vudc_dev.c: In function 'vep_dequeue':
>> drivers/usb/usbip/vudc_dev.c:336:26: warning: variable 'req' set but not used [-Wunused-but-set-variable=]
336 | struct vrequest *req;
| ^~~
vim +/req +336 drivers/usb/usbip/vudc_dev.c
b6a0ca11186759 Igor Kotrasinski 2016-03-08 332
b6a0ca11186759 Igor Kotrasinski 2016-03-08 333 static int vep_dequeue(struct usb_ep *_ep, struct usb_request *_req)
b6a0ca11186759 Igor Kotrasinski 2016-03-08 334 {
b6a0ca11186759 Igor Kotrasinski 2016-03-08 335 struct vep *ep;
b6a0ca11186759 Igor Kotrasinski 2016-03-08 @336 struct vrequest *req;
b6a0ca11186759 Igor Kotrasinski 2016-03-08 337 struct vudc *udc;
b6a0ca11186759 Igor Kotrasinski 2016-03-08 338 struct vrequest *lst;
b6a0ca11186759 Igor Kotrasinski 2016-03-08 339 unsigned long flags;
b6a0ca11186759 Igor Kotrasinski 2016-03-08 340 int ret = -EINVAL;
b6a0ca11186759 Igor Kotrasinski 2016-03-08 341
b6a0ca11186759 Igor Kotrasinski 2016-03-08 342 if (!_ep || !_req)
b6a0ca11186759 Igor Kotrasinski 2016-03-08 343 return ret;
b6a0ca11186759 Igor Kotrasinski 2016-03-08 344
b6a0ca11186759 Igor Kotrasinski 2016-03-08 345 ep = to_vep(_ep);
b6a0ca11186759 Igor Kotrasinski 2016-03-08 346 req = to_vrequest(_req);
c21cd67cd337e6 Jipa Alexandru-Ionut 2026-06-12 347 udc = ep_to_vudc(ep);
b6a0ca11186759 Igor Kotrasinski 2016-03-08 348
b6a0ca11186759 Igor Kotrasinski 2016-03-08 349 if (!udc->driver)
b6a0ca11186759 Igor Kotrasinski 2016-03-08 350 return -ESHUTDOWN;
b6a0ca11186759 Igor Kotrasinski 2016-03-08 351
b6a0ca11186759 Igor Kotrasinski 2016-03-08 352 spin_lock_irqsave(&udc->lock, flags);
b6a0ca11186759 Igor Kotrasinski 2016-03-08 353 list_for_each_entry(lst, &ep->req_queue, req_entry) {
b6a0ca11186759 Igor Kotrasinski 2016-03-08 354 if (&lst->req == _req) {
b6a0ca11186759 Igor Kotrasinski 2016-03-08 355 list_del_init(&lst->req_entry);
b6a0ca11186759 Igor Kotrasinski 2016-03-08 356 _req->status = -ECONNRESET;
b6a0ca11186759 Igor Kotrasinski 2016-03-08 357 ret = 0;
b6a0ca11186759 Igor Kotrasinski 2016-03-08 358 break;
b6a0ca11186759 Igor Kotrasinski 2016-03-08 359 }
b6a0ca11186759 Igor Kotrasinski 2016-03-08 360 }
b6a0ca11186759 Igor Kotrasinski 2016-03-08 361 spin_unlock_irqrestore(&udc->lock, flags);
b6a0ca11186759 Igor Kotrasinski 2016-03-08 362
b6a0ca11186759 Igor Kotrasinski 2016-03-08 363 if (ret == 0)
b6a0ca11186759 Igor Kotrasinski 2016-03-08 364 usb_gadget_giveback_request(_ep, _req);
b6a0ca11186759 Igor Kotrasinski 2016-03-08 365
b6a0ca11186759 Igor Kotrasinski 2016-03-08 366 return ret;
b6a0ca11186759 Igor Kotrasinski 2016-03-08 367 }
b6a0ca11186759 Igor Kotrasinski 2016-03-08 368
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2026-06-12 18:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 11:41 [PATCH] usbip: vudc: fix NULL pointer dereference in vep_dequeue Jipa Alexandru-Ionut
2026-06-12 18:32 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202606130221.e57TS4Rk-lkp@intel.com \
--to=lkp@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=i@zenithal.me \
--cc=jipaionut@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.