From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04C00CD98CF for ; Sat, 13 Jun 2026 20:27:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 9957F41163; Sat, 13 Jun 2026 20:27:59 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id oqruvu1rnzAw; Sat, 13 Jun 2026 20:27:57 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 78E2E410C8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1781382477; bh=QMmcuE8DSjrHYXf/QWms+/WUULv13ijGbv3LUEQ15xM=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=V9Cz8rJVLuloJ1nDDHXn4ChbpQEfXFUrBiu6uQZDhm1MdILsnJIma9OEWO+3TybQI YPg3e7j+mnj7acPw648kogwqWyXJJfwGg7h3CFXpg3VATUL+YaNUoR5Zpr+K8/fdOQ ujhiaEU5XzRXRQhQpaOr1t/kfS2KnsrFcjFxbFHA7FW1136MO7kPcCY2ZIiTiGV+yu MmSprbtZIxkRbse20YNdmdRiI+IBw4OF/gr+YAx3mCZKFwS7n6YgI7VpEaK0JURfs3 T8ZhLil3NGMC2qGOese1Tba4aQ32A29JlTLrOGJUvyx2fiDGNASQl1+m9lYPHprKYF 67ZVNY8CsUqUQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 78E2E410C8; Sat, 13 Jun 2026 20:27:57 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists1.osuosl.org (Postfix) with ESMTP id 2248A322 for ; Sat, 13 Jun 2026 20:27:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 1375C841B9 for ; Sat, 13 Jun 2026 20:27:57 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id fRxHZVOqSqA9 for ; Sat, 13 Jun 2026 20:27:56 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 7343D8419A DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 7343D8419A Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) by smtp1.osuosl.org (Postfix) with ESMTPS id 7343D8419A for ; Sat, 13 Jun 2026 20:27:56 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id C5C3140412; Sat, 13 Jun 2026 20:27:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4BE71F000E9; Sat, 13 Jun 2026 20:27:54 +0000 (UTC) Date: Sat, 13 Jun 2026 13:27:53 -0700 From: Jakub Kicinski To: "Nitka, Grzegorz" Message-ID: <20260613132753.2b3d1f07@kernel.org> In-Reply-To: References: <20260607183045.1213735-1-grzegorz.nitka@intel.com> <20260607183045.1213735-4-grzegorz.nitka@intel.com> <5ad977af-9bbb-4376-b0a6-2b1867223145@redhat.com> <20be8f49-4d85-430b-a651-c4aecd172a57@redhat.com> <20260611104109.34063873@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781382475; bh=QMmcuE8DSjrHYXf/QWms+/WUULv13ijGbv3LUEQ15xM=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=KgpB7cChLyT+d4tgCLbidRVA08Bl5Xk8A6GLm6ZX3WBxB84nWepw1vCNruS88uc2i 5JTozl6uSmI+wawmrlUPl3Q7atMO3ByVqIyugMdMhixTTwj89Oc7eyK/Y3Mn+b1+Gz c/zg7u8KYBkCdmTp8A3gVzbLylXWReQeq1YsuhBNnt1JrJ8lnjRksue+yAq4zTmCwU gG96+1C3qh+cV+ZO9O1S/Qd+OW1TKtb/DxWIAg4/v7OC0BQbe+25uhsY4pS0WF2khP 3fWnOH+VsU/IkteKUnMmnM1MRVJt1mf3SjyRm0e06sJkQueLmTjJ7Z/n4lBpr+2yy8 iU2CjH56ZmNyw== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=KgpB7cCh Subject: Re: [Intel-wired-lan] [PATCH v14 net-next 03/13] dpll: fix stale iteration in dpll_pin_on_pin_unregister() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Vecera, Ivan" , "vadim.fedorenko@linux.dev" , "jiri@resnulli.us" , "edumazet@google.com" , "netdev@vger.kernel.org" , "richardcochran@gmail.com" , "donald.hunter@gmail.com" , "linux-kernel@vger.kernel.org" , "Kubalewski, Arkadiusz" , "Prathosh.Satish@microchip.com" , "andrew+netdev@lunn.ch" , "intel-wired-lan@lists.osuosl.org" , "horms@kernel.org" , "Kitszel, Przemyslaw" , "Nguyen, Anthony L" , Paolo Abeni , "davem@davemloft.net" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, 11 Jun 2026 18:36:14 +0000 Nitka, Grzegorz wrote: > For v14 patchset, I got only comments from Arek and Paolo. > In my opinion, after rethinking, Arek's concerns are not valid (explained in > the responses). Maybe I could squash some changes, but the final code would > remain the same as for v14. > > Paolo raised 'Fixes' tags which I added and critical divide-by-zero panic > Regarding 'Fixes' tag, It might be my fault or misunderstanding. > I can remove them if we want and re-send the series. > Regarding div-by-zero - see my comments about AI concern list below. > > Also, what was raised by AI, I unintentionally changed WARN_ON to WARN_ON_ONCE > in patch 2. I'd restore it to WARN_ON. Alright, let me apply this. But please investigate the situation with the notifications. Maybe there are two create notifications because we add more info to the second one? If not we should drop the duplicates.. YNL can monitor the notifications during tests if you need a repro. You can follow up with the fixes during the merge window. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20BFF125A0; Sat, 13 Jun 2026 20:27:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781382477; cv=none; b=uQ++2mljBKBE0xdGifjXLiLaQ1dg/8TcbBRzFAbIinzgQ+SX7Hf7Pg8PFHpptu6tWzaX/PJF3Po2AC35DisnYjpBMJ9QWYGq6wCEet4sO9VCT1nZIK+0FB8A2RA+jOrafxkTCncuvXAHE9jh4JqAyW2bc8sNg+ognumYKG4OGCU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781382477; c=relaxed/simple; bh=4ovALgOKX20p7BRaHz8M+StSi4whya61Xc6wqoKJ2BA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FHx5NZzJQsUc5WfsA6U1uWF67MYA/QYHA48v4WgvVKzzaPWTso3ahmzvNcfIFQEeh2NCmse/E8Li9/hyKYvMRnoyAgTzDTbVNz7Au1aCMgvfXtQlQnctPoPNc7gl/a094BimnWeVZWC44SROLtVk3bgjlywd9aKQMmzbFB/131Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KgpB7cCh; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KgpB7cCh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4BE71F000E9; Sat, 13 Jun 2026 20:27:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781382475; bh=QMmcuE8DSjrHYXf/QWms+/WUULv13ijGbv3LUEQ15xM=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=KgpB7cChLyT+d4tgCLbidRVA08Bl5Xk8A6GLm6ZX3WBxB84nWepw1vCNruS88uc2i 5JTozl6uSmI+wawmrlUPl3Q7atMO3ByVqIyugMdMhixTTwj89Oc7eyK/Y3Mn+b1+Gz c/zg7u8KYBkCdmTp8A3gVzbLylXWReQeq1YsuhBNnt1JrJ8lnjRksue+yAq4zTmCwU gG96+1C3qh+cV+ZO9O1S/Qd+OW1TKtb/DxWIAg4/v7OC0BQbe+25uhsY4pS0WF2khP 3fWnOH+VsU/IkteKUnMmnM1MRVJt1mf3SjyRm0e06sJkQueLmTjJ7Z/n4lBpr+2yy8 iU2CjH56ZmNyw== Date: Sat, 13 Jun 2026 13:27:53 -0700 From: Jakub Kicinski To: "Nitka, Grzegorz" Cc: Paolo Abeni , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" , "Oros, Petr" , "richardcochran@gmail.com" , "andrew+netdev@lunn.ch" , "Kitszel, Przemyslaw" , "Nguyen, Anthony L" , "Prathosh.Satish@microchip.com" , "Vecera, Ivan" , "jiri@resnulli.us" , "Kubalewski, Arkadiusz" , "vadim.fedorenko@linux.dev" , "donald.hunter@gmail.com" , "horms@kernel.org" , "davem@davemloft.net" , "edumazet@google.com" Subject: Re: [PATCH v14 net-next 03/13] dpll: fix stale iteration in dpll_pin_on_pin_unregister() Message-ID: <20260613132753.2b3d1f07@kernel.org> In-Reply-To: References: <20260607183045.1213735-1-grzegorz.nitka@intel.com> <20260607183045.1213735-4-grzegorz.nitka@intel.com> <5ad977af-9bbb-4376-b0a6-2b1867223145@redhat.com> <20be8f49-4d85-430b-a651-c4aecd172a57@redhat.com> <20260611104109.34063873@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 11 Jun 2026 18:36:14 +0000 Nitka, Grzegorz wrote: > For v14 patchset, I got only comments from Arek and Paolo. > In my opinion, after rethinking, Arek's concerns are not valid (explained in > the responses). Maybe I could squash some changes, but the final code would > remain the same as for v14. > > Paolo raised 'Fixes' tags which I added and critical divide-by-zero panic > Regarding 'Fixes' tag, It might be my fault or misunderstanding. > I can remove them if we want and re-send the series. > Regarding div-by-zero - see my comments about AI concern list below. > > Also, what was raised by AI, I unintentionally changed WARN_ON to WARN_ON_ONCE > in patch 2. I'd restore it to WARN_ON. Alright, let me apply this. But please investigate the situation with the notifications. Maybe there are two create notifications because we add more info to the second one? If not we should drop the duplicates.. YNL can monitor the notifications during tests if you need a repro. You can follow up with the fixes during the merge window.