All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI/sysfs: Use kstrtobool() to parse the ROM attribute input
Date: Sun, 14 Jun 2026 00:03:35 +0900	[thread overview]
Message-ID: <20260613150147.GA3086320@rocinante> (raw)
In-Reply-To: <20260612212254.GA659826@bhelgaas>

Hello,

> > Thus, parse the input with kstrtobool(), which handles common boolean
> > inputs such as "0", "1", "n", "y" or "off", "on", with or without a
> > trailing newline, so both of the above disable access, and update the
> > now stale comment.
> > 
> > As a side effect, input that does not parse as a boolean is rejected
> > with -EINVAL rather than enabling access.  The documented "0" and "1"
> > continue to work as before, and rejecting malformed input brings the
> > attribute in line with how sysfs attributes typically handle it.
[...]
> 
> Applied to pci/sysfs for v7.2, thanks!

Thank you!

I will follow-up with a series that updates other sysfs objects we have
accordingly with this preferred API over some of the hand-rolled ones we
currently have.

All the best,

	Krzysztof

      reply	other threads:[~2026-06-13 15:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-12 18:24 [PATCH] PCI/sysfs: Use kstrtobool() to parse the ROM attribute input Krzysztof Wilczyński
2026-06-12 18:35 ` sashiko-bot
2026-06-12 21:22 ` Bjorn Helgaas
2026-06-13 15:03   ` Krzysztof Wilczyński [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260613150147.GA3086320@rocinante \
    --to=kwilczynski@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.