From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8274D3242BA;
	Sat, 13 Jun 2026 23:59:53 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1781395194; cv=none; b=OiRgN1Q5kNss2jH2GxuavAnSxOkkaYPLZ9bkwzIqaAaxFAbfesd9NNcovRMOxyp1kop7savdnGZNGfgW6GJ9qtdY9TVdPv4n7rPPiHEzG13PlKCXnHbSTP788uSiLUoqlj0nDPtlmO/dktT8wsUU4IUjaMDDeaBV2uUIdfu7u/o=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1781395194; c=relaxed/simple;
	bh=AKPoNBVM5QLmdnhBqVQCCGBrkAVluDSMT793EJc23jo=;
	h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:
	 MIME-Version:Content-Type; b=bzoW2hq4dlyqrDc23/yPTk8iJyqkkwmajLbV88qbokc8+9LF4f4oprnEMMvaP+/PG8fuU51FeuQbo0zAjpvMdvrdY3uJdFvIxfv1/TQ8AYA00N8Tvc0/m7FRRUpwrnmgUJL4x0clxIqD2YLaYyV/E08VzQNqlEMXnbw1YCt3qzQ=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nCER2mMQ; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nCER2mMQ"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9ED61F000E9;
	Sat, 13 Jun 2026 23:59:52 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1781395193;
	bh=hoaO3paOlThs+FEBajI10NwH3K6hgSI4nk0u5G3a5ZI=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References;
	b=nCER2mMQw27f/mDzxmAuNXxbqC0/+22LHSQOjjsez7WWdBOsyifiHlFIQ7Xc9zWpT
	 Xpk1VAxM/nVel1ll4KNcaHVZFGZqQYuy18IBqCYUH+8nzIpa4w0ysrW1lUfQjqgZfs
	 dR6DuaddUW5+hRAqSfu+J7i4pRr02/jRyPrjBmWUhuSOXrwPSWqmzL1Ze8Zbu2k2En
	 PQnyPV9d8bA9z/HAULixu43dhH68oWszgQFSEffdRiL/FaX8Fn+lpvr4el/sIDmgwu
	 BVzpoLZj+AL/X14qCwPUWWTQqEnane44jlNl9WKkR8iUNonX2iMHGBrpC6ZWBjVKQo
	 KkwMFMay5ZHsQ==
Date: Sat, 13 Jun 2026 16:59:51 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: javen <javen_xu@realsil.com.cn>
Cc: <andrew@lunn.ch>, <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
 <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
 <freddy_gu@realsil.com.cn>, <nb@tipi-net.de>, <netdev@vger.kernel.org>,
 <linux-kernel@vger.kernel.org>, <daniel@makrotopia.org>,
 <vladimir.oltean@nxp.com>
Subject: Re: [PATCH net-next v5 2/4] net: phy: c45: add
 genphy_c45_config_master_slave()
Message-ID: <20260613165951.115d06b8@kernel.org>
In-Reply-To: <20260611031839.568-3-javen_xu@realsil.com.cn>
References: <20260611031839.568-1-javen_xu@realsil.com.cn>
	<20260611031839.568-3-javen_xu@realsil.com.cn>
Precedence: bulk
X-Mailing-List: netdev@vger.kernel.org
List-Id: <netdev.vger.kernel.org>
List-Subscribe: <mailto:netdev+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:netdev+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 11 Jun 2026 11:18:37 +0800 javen wrote:
> + * Returns negative errno code on failure, 0 if Master/Slave didn't change,
> + * or 1 if Master/Slave modes changed.

Returns:

the colon is needed otherwise:

Warning: drivers/net/phy/phy-c45.c:420 No description found for return value of 'genphy_c45_an_setup_master_slave'

There's also an AI review at 
https://sashiko.dev/#/patchset/20260611031839.568-3-javen_xu@realsil.com.cn
-- 
pw-bot: cr