[l1k:tsm_d0 1/1] drivers/crypto/ccp/sev-dev-tsm.c:43:21: error: incompatible pointer types passing 'struct pci_dev *' to parameter of type 'class_pm_runtime_active_t' (aka 'struct device *')

[kernel test robot <lkp@intel.com>]

tree:   https://github.com/l1k/linux tsm_d0
head:   5d1328bf1d1aa1bfefc2aa97b82783e053dccfda
commit: 5d1328bf1d1aa1bfefc2aa97b82783e053dccfda [1/1] PCI/TSM: Resume device to D0 for CMA-SPDM operation
config: x86_64-rhel-9.4-rust (https://download.01.org/0day-ci/archive/20260613/202606132016.W3OZXlo2-lkp@intel.com/config)
compiler: clang version 22.1.3 (https://github.com/llvm/llvm-project e9846648fd6183ee6d8cbdb4502213fcf902a211)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260613/202606132016.W3OZXlo2-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202606132016.W3OZXlo2-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/crypto/ccp/sev-dev-tsm.c:43:21: error: incompatible pointer types passing 'struct pci_dev *' to parameter of type 'class_pm_runtime_active_t' (aka 'struct device *') [-Wincompatible-pointer-types]
      43 |         PM_RUNTIME_ACQUIRE(dsm->tsm.base_tsm.pdev, pm);
         |                            ^~~~~~~~~~~~~~~~~~~~~~
   include/linux/pm_runtime.h:631:39: note: expanded from macro 'PM_RUNTIME_ACQUIRE'
     631 |         ACQUIRE(pm_runtime_active_try, _var)(_dev)
         |                                              ^~~~
   include/linux/pm_runtime.h:619:1: note: passing argument to parameter '_T' here
     619 | DEFINE_GUARD_COND(pm_runtime_active, _try,
         | ^
   include/linux/cleanup.h:419:33: note: expanded from macro 'DEFINE_GUARD_COND'
     419 | #define DEFINE_GUARD_COND(X...) CONCATENATE(DEFINE_GUARD_COND_, COUNT_ARGS(X))(X)
         |                                 ^
   include/linux/args.h:26:27: note: expanded from macro 'CONCATENATE'
      26 | #define CONCATENATE(a, b) __CONCAT(a, b)
         |                           ^
   include/linux/args.h:25:24: note: expanded from macro '__CONCAT'
      25 | #define __CONCAT(a, b) a ## b
         |                        ^
   <scratch space>:135:1: note: expanded from here
     135 | DEFINE_GUARD_COND_4
         | ^
   include/linux/cleanup.h:407:26: note: expanded from macro 'DEFINE_GUARD_COND_4'
     407 |                      class_##_name##_t _T) \
         |                                        ^
   drivers/crypto/ccp/sev-dev-tsm.c:44:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
      44 |         if (pm_ret = PM_RUNTIME_ACQUIRE_ERR(&pm))
         |             ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/crypto/ccp/sev-dev-tsm.c:44:13: note: place parentheses around the assignment to silence this warning
      44 |         if (pm_ret = PM_RUNTIME_ACQUIRE_ERR(&pm))
         |                    ^                            
         |             (                                   )
   drivers/crypto/ccp/sev-dev-tsm.c:44:13: note: use '==' to turn this assignment into an equality comparison
      44 |         if (pm_ret = PM_RUNTIME_ACQUIRE_ERR(&pm))
         |                    ^
         |                    ==
   1 warning and 1 error generated.


vim +43 drivers/crypto/ccp/sev-dev-tsm.c

    29	
    30	static int sev_tio_spdm_cmd(struct tio_dsm *dsm, int ret)
    31	{
    32		struct tsm_dsm_tio *dev_data = &dsm->data;
    33		struct tsm_spdm *spdm = &dev_data->spdm;
    34		int pm_ret;
    35	
    36		/* Check the main command handler response before entering the loop */
    37		if (ret == 0 && dev_data->psp_ret != SEV_RET_SUCCESS)
    38			return -EINVAL;
    39	
    40		if (ret <= 0)
    41			return ret;
    42	
  > 43		PM_RUNTIME_ACQUIRE(dsm->tsm.base_tsm.pdev, pm);
    44		if (pm_ret = PM_RUNTIME_ACQUIRE_ERR(&pm))
    45			return pm_ret;
    46	
    47		/* ret > 0 means "SPDM requested" */
    48		while (ret == PCI_DOE_FEATURE_CMA || ret == PCI_DOE_FEATURE_SSESSION) {
    49			ret = pci_doe(dsm->tsm.doe_mb, PCI_VENDOR_ID_PCI_SIG, ret,
    50				      spdm->req, spdm->req_len, spdm->rsp, spdm->rsp_len);
    51			if (ret < 0)
    52				break;
    53	
    54			WARN_ON_ONCE(ret == 0); /* The response should never be empty */
    55			spdm->rsp_len = ret;
    56			ret = sev_tio_continue(dev_data);
    57		}
    58	
    59		return ret;
    60	}
    61	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki